This weekend or early next week I will be pushing a couple of more patches to deal with some of the big TODOs (e.g. bulk). Then we can rename it and see if we can review the merge.
I don't intend to have it fully replace our built-in WSGI solution in Liberty. It's too late in the cycle to make that drastic of a switch. I just want to have it in the main tree and have the option of trying it out in Liberty. On Fri, Aug 28, 2015 at 4:11 PM, Salvatore Orlando <salv.orla...@gmail.com> wrote: > I'll leave to Kevin's more informed judgment to comment on whether it is > appropriate to merge: > > [1] is a list of patches still under review on the feature branch. Some of > them fix issues (like executing API actions), or implement TODOs > > This is the current list of TODOs: > salvatore@ubuntu:/opt/stack/neutron$ find ./neutron/newapi/ -name \*.py | > xargs grep -n "TODO" > ./neutron/newapi/hooks/context.py:50: # TODO(kevinbenton): is_admin > logic > ./neutron/newapi/hooks/notifier.py:22: # TODO(kevinbenton): implement > ./neutron/newapi/hooks/member_action.py:28: # TODO(salv-orlando): > This hook must go. Handling actions like this is > ./neutron/newapi/hooks/quota_enforcement.py:33: # > TODO(salv-orlando): This hook must go when adaptin the pecan code to > ./neutron/newapi/hooks/attribute_population.py:59: # > TODO(kevinbenton): the parent_id logic currently in base.py > ./neutron/newapi/hooks/ownership_validation.py:34: # > TODO(salvatore-orlando): consider whether this check can be folded > ./neutron/newapi/app.py:40: #TODO(kevinbenton): error templates > ./neutron/newapi/controllers/root.py:150: # TODO(kevinbenton): > allow fields after policy enforced fields present > ./neutron/newapi/controllers/root.py:160: # TODO(kevinbenton): bulk! > ./neutron/newapi/controllers/root.py:190: # TODO(kevinbenton): bulk? > ./neutron/newapi/controllers/root.py:197: # TODO(kevinbenton): bulk? > > In my opinion the pecan API now is "working-ish"; however we know it is > not yet 100% functionally equivalent; but most importantly we don't know > how it works. So far a few corners have bet cut when it comes to testing. > Even if "it works" it is therefore probably usable. Unfortunately I don't > know what are the criteria the core team evaluates for merging it back (and > I'm sure that for this release at least the home grown WSGI won't be > replaced). > > Salvatore > > [1] > https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:feature/pecan,n,z > > On 28 August 2015 at 22:51, Kyle Mestery <mest...@mestery.com> wrote: > >> Folks: >> >> Kevin wants to merge the pecan stuff, and I agree with him. I'm on >> vacation next week during Liberty-3, so Armando, Carl and Doug are running >> the show while I'm out. I would guess that if Kevin thinks it's ok to merge >> it in before Liberty-3, I'd go with his opinion and let it happen. If not, >> it can get an FFE and we can do it post Liberty-3. >> >> I'm sending this to the broader openstack-dev list so that everyone can >> be aware of this plan, and so that Ihar can help collapse things back next >> week with Doug on this. >> >> Thanks! >> Kyle >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Kevin Benton
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev