Hi Emilien, I don't think Murano team needs to be core on a Puppet module ether, current scheme was implemented per your proposal [1] and I am happy that we are ready to move Murano to the same scheme that is used with other projects.
I've updated ACL for puppet-murano project: https://review.openstack.org/223694 References: [1] http://lists.openstack.org/pipermail/openstack-dev/2015-June/067260.html On Tue, Sep 15, 2015 at 6:32 AM, Emilien Macchi <emil...@redhat.com> wrote: > > > On 09/15/2015 07:39 AM, Ivan Berezovskiy wrote: >> Emilien, >> >> puppet-murano module have a bunch of patches from Alexey Deryugin on >> review [0], which implements most of all Murano deployment stuff. >> Murano project was added to OpenStack namespace not so long ago, that's >> why I suggest to have murano-core rights on puppet-murano as they >> are till all these patches will be merged. >> Anyway, murano-core team doesn't merge any patches without OpenStack >> Puppet team approvals. > > [repeating what I said on IRC so it's official and public] > > I don't think Murano team needs to be core on a Puppet module. > All OpenStack modules are managed by one group, this is how we worked > until here and I don't think we want to change that.s > Project teams (Keystone, Nova, Neutron, etc) already use -1/+1 to review > Puppet code when they want to share feedback and they are very valuable, > we actually need it. > I don't see why we would do an exception for Murano. I would like Murano > team to continue to give their valuable feedback by -1/+1 patches but > it's the Puppet OpenStack team duty to decide if they merge the code or not. > > This collaboration is important and we need your experience to create > new modules, but please understand how Puppet OpenStack governance works > now. > > Thanks, > > >> [0] >> - >> https://review.openstack.org/#/q/status:open+project:openstack/puppet-murano+owner:%22Alexey+Deryugin+%253Caderyugin%2540mirantis.com%253E%22,n,z >> >> 2015-09-15 1:01 GMT+03:00 Matt Fischer <m...@mattfischer.com >> <mailto:m...@mattfischer.com>>: >> >> Emilien, >> >> I've discussed this with some of the Monasca puppet guys here who >> are doing most of the work. I think it probably makes sense to move >> to that model now, especially since the pace of development has >> slowed substantially. One blocker before to having it "big tent" was >> the lack of test coverage, so as long as we know that's a work in >> progress... I'd also like to get Brad Kiein's thoughts on this, but >> he's out of town this week. I'll ask him to reply when he is back. >> >> >> On Mon, Sep 14, 2015 at 3:44 PM, Emilien Macchi <emil...@redhat.com >> <mailto:emil...@redhat.com>> wrote: >> >> Hi, >> >> As a reminder, Puppet modules that are part of OpenStack are >> documented >> here [1]. >> >> I can see puppet-murano & puppet-mistral Gerrit permissions >> different >> from other modules, because Mirantis helped to bootstrap the >> module a >> few months ago. >> >> I think [2] the modules should be consistent in governance and only >> Puppet OpenStack group should be able to merge patches for these >> modules. >> >> Same question for puppet-monasca: if Monasca team wants their module >> under the big tent, I think they'll have to change Gerrit >> permissions to >> only have Puppet OpenStack able to merge patches. >> >> [1] >> >> http://governance.openstack.org/reference/projects/puppet-openstack.html >> [2] https://review.openstack.org/223313 >> >> Any feedback is welcome, >> -- >> Emilien Macchi >> >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> >> <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> >> -- >> Thanks, Ivan Berezovskiy >> MOS Puppet Team Lead >> at Mirantis <https://www.mirantis.com/> >> >> slack: iberezovskiy >> skype: bouhforever >> phone: + 7-960-343-42-46 >> >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > -- > Emilien Macchi > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Serg Melikyan, Senior Software Engineer at Mirantis, Inc. http://mirantis.com | smelik...@mirantis.com __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev