Hi everyone! I agree that wrong order of arguments misleads while debugging errors, BUT how we can prevent regression? Imo, this is not a good idea to make patches like https://review.openstack.org/#/c/64415/ in each release(without check in CI, such patches are redundant).
PS: This question relates not only for murano. On Thu, Sep 24, 2015 at 11:48 AM, Kekane, Abhishek < abhishek.kek...@nttdata.com> wrote: > Hi, > > There is a bug for this, you can add murano projects to this bug. > > https://bugs.launchpad.net/heat/+bug/1259292 > > Thanks, > > Abhishek Kekane > > -----Original Message----- > From: Bulat Gaifullin [mailto:bgaiful...@mirantis.com] > Sent: 24 September 2015 13:29 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [murano] Fix order of arguments in assertEqual > > +1 > > > On 24 Sep 2015, at 10:45, Tetiana Lashchova <tlashch...@mirantis.com> > wrote: > > > > Hi folks! > > > > Some tests in murano code use incorrect order of arguments in > assertEqual. > > The correct order expected by the testtools is > > > > def assertEqual(self, expected, observed, message=''): > > """Assert that 'expected' is equal to 'observed'. > > > > :param expected: The expected value. > > :param observed: The observed value. > > :param message: An optional message to include in the error. > > """ > > > > Error message has the following format: > > > > raise mismatch_error > > testtools.matchers._impl.MismatchError: !=: > > reference = <expected value> > > actual = <observed value> > > > > Use of arguments in incorrect order could make debug output very > confusing. > > Let's fix it to make debugging easier. > > > > Best regards, > > Tetiana Lashchova > > ______________________________________________________________________ > > ____ OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ______________________________________________________________________ > Disclaimer: This email and any attachments are sent in strictest confidence > for the sole use of the addressee and may contain legally privileged, > confidential, and proprietary data. If you are not the intended recipient, > please advise the sender by replying promptly to this email and then delete > and destroy this email and any attachments without any further use, copying > or forwarding. > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Best regards, Andrey Kurilin.
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev