On Mon, Nov 16, 2015 at 04:11:42PM EST, Paul Carver wrote: > This is a challenge. Personally, I haven't been able to get it all working > yet. But we're in a dilemma because we want to get good reviews of the code > before merging. Since the full functionality is quite a lot of code we > wanted to chop it into more easily reviewable chunks. Unfortunately that > makes it more difficult to pull it all in at once to test the whole thing > prior to completing the review and merge.
I would be concerned about that. I am sympathetic to the chicken and egg problem of a new repo and new code, but I briefly looked at both of those reviews and they both are quite large. 1K LOC is usually the upper limit for a sane patch set. It may be worth trying to break into smaller, more manageable pieces - even if the initial commits just create some empty classes and stubbed methods, and then later start introducing the actual method bodies in small pieces with good unit tests for each one. Small pieces. Tiny steps. My $0.02 USD -- Sean M. Collins __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
