On Tue, Jan 05, 2016 at 12:26:24PM +1300, Robert Collins wrote: > On 5 January 2016 at 12:04, Robert Collins <robe...@robertcollins.net> wrote: > ... > > Indeed - > > https://bitbucket.org/pypa/setuptools/commits/fb35fcade302fa828d34e6aff952ec2398f2c877?at=get_command_list > > - the failing bit AFAICT is indeed new code :/. > > > Ok, so I've paged this all in. Here's whats up, and some thoughts on fixing > it. > > Old pbr does indeed have a bug where 'setup.py test' will error with > that unguarded import of what isn't meant to be a dependency. > > The reason this started failing is that a bugfix to setuptools - so > that the existing pbr code that wraps commands can wrap commands only > added by setuptools plugins like 'wheel' was merged and included in a > setuptools release. > > This causes the pbr testr command to be loaded, which fails in old pbr. > > The right answer is a back port of the import guard to pbr < 1.0.0 and > a point release - 0.11.1. > > IMO that is :) > > I see that a workaround has been committed - installing testrepository > - but I'd hate for folk to cargo cult the idea that pbr could have a > runtime dependency on test-only tools like that.
Rob, thank you for looking deeper into this. Your conclusions sound logical to me and much saner than just pulling in testrepository. Matthias -- Matthias Runge <mru...@redhat.com> __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
