Hi,
The test case you pointed is for threshold alarm, so it is OK and expected that "composite_rule" is None. Checking test codes is good idea. You can add new tests when you found something missing by posting new patch. BR, Ryota > -----Original Message----- > From: li.yuanz...@zte.com.cn [mailto:li.yuanz...@zte.com.cn] > Sent: Thursday, May 19, 2016 12:27 PM > To: openstack-dev@lists.openstack.org > Cc: aji.zq...@gmail.com; ildiko.van...@ericsson.com; lianhao...@intel.com; > liusheng2...@gmail.com; Mibu Ryota(壬生 亮 > 太); Julien Danjou > Subject: [Openstack] [AodhClient] "composite alarm" unit test missing in > aodhclient ? > > HI All, > in aodhclient/tests/unit/test_alarm_cli.py[1] > <https://review.openstack.org/#/c/284022/7/aodhclient/tests/unit/test_alarm_cli.py> > , the "composite_rule" is None. > is the composite_rule test missing? and should we add it ? > > [1] > https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py > <https://github.com/openstack/python-aodhclient/blob/master/aodhclient/tests/unit/test_alarm_cli.py> > > Rajen(liyuanzhen) > > > -------------------------------------------------------- > ZTE Information Security Notice: The information contained in this mail (and > any attachment transmitted herewith) is > privileged and confidential and is intended for the exclusive use of the > addressee(s). If you are not an intended recipient, > any disclosure, reproduction, distribution or other dissemination or use of > the information contained is strictly prohibited. > If you have received this mail in error, please delete it and notify us > immediately. > > __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
