White working on the change series to implement the virtlogd feature I got feedback [1] to move code which creates parts of the libvirt.xml file from the "driver" module into the "guest" module. I'm a bit hesitant to do so as the responsibility of creating a valid libvirt.xml file is then spread across 3 modules: * driver.py * guest.py * designer.py I'm only looking for a guideline here (The "driver" module is humongous and I think it would be a good thing to have the "libvirt.xml" creation code outside of it). Thoughts?
References: [1] https://review.openstack.org/#/c/323761/2/nova/virt/libvirt/driver.py@4190 -- Regards, Markus Zoeller (markus_z) __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
