Too late. That's a backwards incompatible change that can mess with clients putting on cache busting nonce tokens and who knows what else.
On Thu, Jul 28, 2016 at 3:49 AM, Korzeniewski, Artur < artur.korzeniew...@intel.com> wrote: > Hi all, > > During integration of Subnet OVO into db code > get_subnet/update_subnet/delete [1], I have found and issue in API behavior > and strict object implementation for NeutronDbObject base class. > > > > The issue is that on REST API level, you can pass random filters and it > will not affect the result set. > > But in object implementation, we are checking if filters passed to > get_objects is valid field declared in object. If it does not exists, we > error out [2]: > > "Invalid input for operation: 'admin_state_up' is not supported for > filtering." > > > > So the question is: should we return error from object to API level that > filter passed in GET request is invalid? > > In my opinion we should not allow random strings to be passed as filters… > > > > > > Regards, > > Artur Korzeniewski > > IRC: korzen > > > > [1] https://review.openstack.org/#/c/321001 > > [2] > http://logs.openstack.org/01/321001/11/check/gate-neutron-dsvm-api/98d056e/console.html#_2016-07-27_14_47_10_906641 > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev