On 2017-01-20 14:36, Matt Riedemann wrote: > On 1/20/2017 2:22 AM, Sylvain Bauza wrote: >> >> >> Le 20/01/2017 04:16, Matt Riedemann a écrit : >>> On 1/19/2017 5:09 PM, Matt Riedemann wrote: >>>> On 1/19/2017 10:56 AM, Matt Riedemann wrote: >>>>> The py35 unit test job is broken for Nova until this patch is merged: >>>>> >>>>> https://review.openstack.org/#/c/422709/ >>>>> >>>>> So please hold off on the rechecks until that happens. >>>>> >>>> >>>> We're good to go again for rechecks. >>>> >>> >>> Just a heads up that if you still see py35 unit test failures with a >>> TypeError like this [1] then you need to rebase you patch. >>> >>> [1] >>> http://logs.openstack.org/37/410737/5/check/gate-nova-python35-db/4fec66c/console.html#_2017-01-20_01_56_21_021702 >>> >>> >>> >> >> Just for understanding correctly the context, which merged change fixes >> that, needing a rebase ? >> >> >> __________________________________________________________________________ >> >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > Not merged changes, changes in the check queue. I had noticed a couple > of approved changes yesterday were failing on oslo.serialization 2.16.0 > in upper-constraints so those needed to be rebased to pick this up: > > https://github.com/openstack/nova/commit/161799edaab21ea7b4f577766764768fa6c39e5d
You shouldn't need to rebase changes - we always rebase in check and gate queue before running tests. So, a simple "recheck" should be enough. Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev