Hey Darragh, No problem at all. Thanks for the feedback. I'll slowly start removing them from my commits and for future patches.
Thanks, Kien Ha On Fri, Jul 1, 2016 at 10:25 AM, Darragh Bailey <[email protected]> wrote: > Hi Kien, > > > I missed this email, but spotted this appearing in recent commits. > > > On 13 June 2016 at 03:28, Kien Ha <[email protected]> wrote: > >> >> On Sat, Jun 11, 2016 at 11:12 PM, Dong Ma <[email protected]> >> wrote: >> >>> Hello Kien Ha, >>> >>> Thanks for the contribution to the Jenkins job builder projects, have >>> one comment here, how about add your proposal document link or create a new >>> etherpad into the commit message of each patches as reference to keep >>> tracking the process. >>> >>> Vincent >>> >> > This kind goes outside of what is generally described as > https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages > > > The update to the mailing list is more than enough, let's keep the commits > describing the functional reason for the change, or if there is a separate > proposal spec/blueprint that covers changing to use the convert to xml > function in JJB, changes relevant can include a reference, otherwise lets > keep the commit messages focused on the change itself. > > > -- > Darragh Bailey > "Nothing is foolproof to a sufficiently talented fool" >
_______________________________________________ OpenStack-Infra mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
