I'm all for style checking. We may also want to include some syntax checking as well (bash -n <script>). I personally believe that, so long as the acceptance tests aren't overly strict, they provide a nice guide.
On Tue, Sep 29, 2015 at 12:43 PM, Joe Topjian <[email protected]> wrote: > So this will require bash scripts to adhere to bashate before being > accepted? Is it possible to have the check as non-voting? Does this open > the door to having other file types be checked? > > IMHO, it's more important for the OSOps project to foster collaboration > and contributions rather than worry about an accepted style. > > As an example, yesterday's commits used hard-tabs: > > https://review.openstack.org/#/c/228545/ > https://review.openstack.org/#/c/228534/ > > I think we're going to see a lot of variation of styles coming in. > > I don't want to come off as sounding ignorant or disrespectful to other > projects that have guidelines in place -- I fully understand and respect > those decisions. > > Joe > > On Tue, Sep 29, 2015 at 12:52 PM, JJ Asghar <[email protected]> wrote: > >> Awesome! That works! >> >> Best Regards, >> JJ Asghar >> c: 512.619.0722 t: @jjasghar irc: j^2 >> >> On 9/29/15 1:27 PM, Christian Berendt wrote: >> > On 09/29/2015 07:45 PM, JJ Asghar wrote: >> >> So this popped up today[1]. This seems like something that should be >> >> leveraged in our gates/validations? >> > >> > I prepared review requests to enable checks on the gates for >> > >> > * osops-tools-monitoring: https://review.openstack.org/#/c/229094/ >> > * osops-tools-generic: https://review.openstack.org/#/c/229043/ >> > >> > Christian. >> > >> >> >> _______________________________________________ >> OpenStack-operators mailing list >> [email protected] >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators >> > > > _______________________________________________ > OpenStack-operators mailing list > [email protected] > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators > > -- David W. Unix, because every barista in Seattle has an MCSE.
_______________________________________________ OpenStack-operators mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
