It needs to create the directory in the first place to enable caching.. But - If for whatever reason caching fails that should be no reason to blow up and present an error.
Its probably worth highlighting this code is in python-novaclient, not horizon. The vast majority of uses cases will be able to cache just fine. Anyway - The point is - cache if we can, but if we cant, lets not interrupt the user. Thanks, Kiall On Wed, Mar 21, 2012 at 12:42 PM, Kevin Jackson <ke...@linuxservices.co.uk>wrote: > If the code should just ignore the fact it can't create this directory - > what is the point of it needing to attempt to create the directory in the > first place? What is its purpose if its superfluous? > > try: > os.makedirs(cache_dir, 0755) > except OSError as e: > # NOTE(kiall): This is typicaly either permission denied while > # attempting to create the directory, or the directory > # already exists. Either way, don't fail. > pass > > Cheers, > Kev > > On 21 March 2012 12:29, Kiall Mac Innes <ki...@managedit.ie> wrote: > >> This should fix the issue - https://review.openstack.org/5608 >> >> It duplicates the fix from 5-10 lines below now that the dot files have >> been moved into a directory. >> >> Thanks, >> Kiall >> >> -- > Kevin Jackson > @itarchitectkev > > _______________________________________________ > Mailing list: https://launchpad.net/~openstack > Post to : openstack@lists.launchpad.net > Unsubscribe : https://launchpad.net/~openstack > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp