On Thu, Jun 28, 2012, Daniel P. Berrange <berra...@redhat.com> wrote: > On Thu, Jun 28, 2012 at 09:21:20AM -0700, Johannes Erdfelt wrote: > > What is the Signed-off-by tag used for? > > > > Your examples have yourself, but isn't that kind of implied by > > submitting the patch for review in the first place? [snip] > The only case where I see that it might be considered relevant, is if > the person submitting the patch to OpenStack, is not the same as the > person who wrote the patch. For example, if someone in Red Hat's QA > team (who isn't an OpenStack contributor) writes a patch for OpenStack > & gives it to me, then they'd typically include their own email addr > in a 'Signed-off-by' tag to indicate that they are the author & they > understand the contribution requirements of OpenStack. This indicates > to me that I can trust their patch & thus I'd be happy to add my own > email 'signed-off-by' line & submit it to OpenStack in my role as > someone who has agreed to the formal CLA. > > Since this tagging is a standard feature of GIT, it is quite typical > for people to add Signed-off-by tags on all their commits, to any > project, regardless of whether the project actually mandates this > as their submission policy. I certainly just do it out of habit > for all projects I contribute to. > > So in summary, you are perfectly ok to just ignore the whole > Signed-off-by concept in OpenStack, given the formal CLA reqired > for contributors already.
That sounds reasonable. Thanks for the explanation. JE _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp