But I think we should make our test cases environment agnostic.
I mean we can set the injected into False since our test cases can fail if it is True.
Forget it if I don't get the point.
Thanks
Yong Sheng Gong
-----openstack-bounces+gongysh=cn.ibm....@lists.launchpad.net wrote: -----
To: "openstack@lists.launchpad.net" <openstack@lists.launchpad.net>
From: Johannes Erdfelt
Sent by: openstack-bounces+gongysh=cn.ibm....@lists.launchpad.net
Date: 07/03/2012 06:57AM
Subject: Re: [Openstack] help me with the xenapi test
From: Johannes Erdfelt
Sent by: openstack-bounces+gongysh=cn.ibm....@lists.launchpad.net
Date: 07/03/2012 06:57AM
Subject: Re: [Openstack] help me with the xenapi test
On Mon, Jul 02, 2012, Salvatore Orlando <sorla...@nicira.com> wrote:
> I do not see any obvious reason for these failures, especially as they
> appear to occur when the vdi is created. If I recall it correctly, that
> code is stubbed out for unit tests, and it does not seem your patch
> un-stubs it.
It's not when the VDI is created, but when nova does injection of
configuration information to the instance. This should normally only
occur when flat_injected is True. The default is False.
This code path shouldn't happen in this test. The only place that sets
it to True is for the test_spawn_netinject_file test.
I can't reproduce the failure with the same branch on my development
system, so it appears to be a Jenkins problem.
JE
_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
> I do not see any obvious reason for these failures, especially as they
> appear to occur when the vdi is created. If I recall it correctly, that
> code is stubbed out for unit tests, and it does not seem your patch
> un-stubs it.
It's not when the VDI is created, but when nova does injection of
configuration information to the instance. This should normally only
occur when flat_injected is True. The default is False.
This code path shouldn't happen in this test. The only place that sets
it to True is for the test_spawn_netinject_file test.
I can't reproduce the failure with the same branch on my development
system, so it appears to be a Jenkins problem.
JE
_______________________________________________
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
