On 27.01.2014, at 11:45, Andreas Färber <afaer...@suse.de> wrote: > Am 27.01.2014 11:31, schrieb Alexander Graf: >> On 27.01.2014, at 11:11, Andreas Färber <afaer...@suse.de> wrote: >> >>> In particular I am not so happy about you guys hardcoding OMAP4 hacks in >>> generic code that is being reused by all u-boot-* packages with SPL. >> >> Uh - where exactly do we have OMAP4 hacks in generic code? > > The bulk of mlo-ext2.patch is in common/spl/spl_mmc.c! > > spl_mmc_load_image() is being patched with > + boot_mode = MMCSD_MODE_FAT; /* Fix OMAP4 boot */
Where is that an OMAP4 hack? It just sets the boot mode to FAT (which we reuse for ext2) rather than raw. > > And the 8 bytes I could save were due to my > - boot_mode = spl_boot_mode(); > +// boot_mode = spl_boot_mode(); > > Similarly, FAT handling code had been partially commented out in favor > of ext2: > > - err = mmc_load_image_fat(mmc, CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME); > +// err = mmc_load_image_fat(mmc, CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME); > + err = mmc_load_image_ext2(mmc, "u-boot.bin"); /* We use > u-boot.bin > file on first partition */ > > It really sucks that it's all a gross local hack that none of you > upstreamed with proper CONFIG_* guards since 2012. > My .gnu.hash patch I immediately submitted upstream after verifying that > u-boot-am335xevm builds without mlo-ext2.patch. That one's slightly less controversial too ;). Alex -- To unsubscribe, e-mail: opensuse-arm+unsubscr...@opensuse.org To contact the owner, e-mail: opensuse-arm+ow...@opensuse.org
