Hi Nishanth, On Thursday 05 June 2014 08:37:27 Nishanth Menon wrote: > On 06/05/2014 08:29 AM, Takashi Iwai wrote: > > Alexander Graf wrote: > >> On 04.06.14 09:28, Matwey V. Kornilov wrote: > >>> On 19.05.2014 14:02, Alexander Graf wrote: > >>>>> note: expected 'uint32_t *' but argument is of type 'dma_addr_t *' > >>> > >>> I've fixed that one, but can not figure out what is wrong now: > >>> > >>> https://build.opensuse.org/package/live_build_log/home:matwey:pcm051:13. > >>> 2/kernel-default/standard/armv7l>> > >> > >> If I had to guess I'd say someone forgot to put a few EXPORT_SYMBOLs > >> into the code and never tested whether compiling his v4l / video driver > >> actually works when it's compiled as a module. > > > > The problem is CONFIG_VIDEO_OMAP4=y while the whole V4L stuff is built > > as modules. You have to build V4L into kernel, too. > > That said, it's a Kconfig dependency issue. > > > > Looking at the code, though, omap4-iss driver itself is written to be > > built also as a module. But its Kconfig is bool, so the problem > > happens. Maybe a patch like below works? > > > > Takashi > > > > --- > > diff --git a/drivers/staging/media/omap4iss/Kconfig > > b/drivers/staging/media/omap4iss/Kconfig index 78b0fba7047e..0c3e3c1acd4f > > 100644 > > --- a/drivers/staging/media/omap4iss/Kconfig > > +++ b/drivers/staging/media/omap4iss/Kconfig > > @@ -1,5 +1,5 @@ > > > > config VIDEO_OMAP4 > > - bool "OMAP 4 Camera support" > > + tristate "OMAP 4 Camera support" > > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && I2C && ARCH_OMAP4 > > select VIDEOBUF2_DMA_CONTIG > > ---help--- > > +Sakari and Laurent. Full thread: > http://lists.opensuse.org/archive/opensuse-arm/2014-06/msg00004.html > > I agree, I see no reason for these to be bool.
There's no good reason for the option to be a boolean, but there's a bad reason :-/ The OMAP4 ISS driver calls the omap4_ctrl_pad_readl() and omap4_ctrl_pad_writel() functions, which are not exported. The right way to fix this would be to implement a control module driver for the OMAP4, but that's not a straightforward task, and I don't have time to do so at the moment. -- Regards, Laurent Pinchart -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
