Hello community,

here is the log from the commit of package yast2-storage for openSUSE:Factory 
checked in at 2017-06-07 13:08:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-storage.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-storage"

Wed Jun  7 13:08:40 2017 rev:292 rq:500042 version:3.2.14

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage/yast2-storage.changes      
2017-03-29 13:22:27.486385244 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-storage.new/yast2-storage.changes 
2017-06-07 13:08:42.305155301 +0200
@@ -1,0 +2,21 @@
+Tue May 30 16:53:14 CEST 2017 - shundham...@suse.de
+
+- Don't complain about unavailable NTFS packages if they are not
+  in the product's repo (bsc#1039830)
+- 3.2.14
+
+-------------------------------------------------------------------
+Tue May 23 11:02:17 UTC 2017 - igonzalezs...@suse.com
+
+- Read default subvolume name for Btrfs filesystems when using
+  the expert partitioner (bsc#1040154)
+- 3.2.13
+
+-------------------------------------------------------------------
+Fri May 19 11:54:48 UTC 2017 - knut.anders...@suse.com
+
+- During installation, mount efivarfs in /mnt/sys/firmware/efivars
+  if present in inst-sys (bsc#1037495)
+- 3.2.12
+
+-------------------------------------------------------------------

Old:
----
  yast2-storage-3.2.11.tar.bz2

New:
----
  yast2-storage-3.2.14.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-storage.spec ++++++
--- /var/tmp/diff_new_pack.m9jBlS/_old  2017-06-07 13:08:42.805084755 +0200
+++ /var/tmp/diff_new_pack.m9jBlS/_new  2017-06-07 13:08:42.809084190 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-storage
-Version:        3.2.11
+Version:        3.2.14
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build

++++++ yast2-storage-3.2.11.tar.bz2 -> yast2-storage-3.2.14.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-3.2.11/package/yast2-storage.changes 
new/yast2-storage-3.2.14/package/yast2-storage.changes
--- old/yast2-storage-3.2.11/package/yast2-storage.changes      2017-03-23 
10:55:36.734441739 +0100
+++ new/yast2-storage-3.2.14/package/yast2-storage.changes      2017-05-31 
11:00:47.613991997 +0200
@@ -1,4 +1,25 @@
 -------------------------------------------------------------------
+Tue May 30 16:53:14 CEST 2017 - shundham...@suse.de
+
+- Don't complain about unavailable NTFS packages if they are not
+  in the product's repo (bsc#1039830)
+- 3.2.14
+
+-------------------------------------------------------------------
+Tue May 23 11:02:17 UTC 2017 - igonzalezs...@suse.com
+
+- Read default subvolume name for Btrfs filesystems when using
+  the expert partitioner (bsc#1040154)
+- 3.2.13
+
+-------------------------------------------------------------------
+Fri May 19 11:54:48 UTC 2017 - knut.anders...@suse.com
+
+- During installation, mount efivarfs in /mnt/sys/firmware/efivars
+  if present in inst-sys (bsc#1037495)
+- 3.2.12
+
+-------------------------------------------------------------------
 Wed Mar 22 08:45:22 UTC 2017 - mfi...@suse.com
 
 - bnc#1026027
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-3.2.11/package/yast2-storage.spec 
new/yast2-storage-3.2.14/package/yast2-storage.spec
--- old/yast2-storage-3.2.11/package/yast2-storage.spec 2017-03-23 
10:55:36.734441739 +0100
+++ new/yast2-storage-3.2.14/package/yast2-storage.spec 2017-05-31 
11:00:47.613991997 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-storage
-Version:        3.2.11
+Version:        3.2.14
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-3.2.11/src/clients/inst_prepdisk.rb 
new/yast2-storage-3.2.14/src/clients/inst_prepdisk.rb
--- old/yast2-storage-3.2.11/src/clients/inst_prepdisk.rb       2017-03-23 
10:55:36.738441739 +0100
+++ new/yast2-storage-3.2.14/src/clients/inst_prepdisk.rb       2017-05-31 
11:00:47.613991997 +0200
@@ -36,6 +36,8 @@
 # possible return values: `back, `abort `next
 module Yast
   class InstPrepdiskClient < Client
+    EFIVARS_PATH = "/sys/firmware/efi/efivars".freeze
+
     def main
       textdomain "storage"
 
@@ -140,6 +142,7 @@
 
         MountTarget("/proc", "proc", "-t proc")
         MountTarget("/sys", "sysfs", "-t sysfs")
+        MountTarget(EFIVARS_PATH, "efivarfs", "-t efivarfs") if 
File.exists?(EFIVARS_PATH)
 
         # mounting /run for udev (bnc#717321)
         @cmd = Ops.add(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-storage-3.2.11/src/lib/storage/used_storage_features.rb 
new/yast2-storage-3.2.14/src/lib/storage/used_storage_features.rb
--- old/yast2-storage-3.2.11/src/lib/storage/used_storage_features.rb   
2017-03-23 10:55:36.750441739 +0100
+++ new/yast2-storage-3.2.14/src/lib/storage/used_storage_features.rb   
2017-05-31 11:00:47.629991997 +0200
@@ -95,6 +95,17 @@
           # Other
           FT_QUOTA:         "quota"
         }
+
+      # Storage-related packages that are nice to have, but not absolutely
+      # required.
+      #
+      # SLES-12 for example (unlike SLED-12) does not come with NTFS packages,
+      # so they cannot be installed. But there might already be an existing
+      # NTFS Windows partition on the disk; don't throw an error pop-up in that
+      # case, just log a warning (bsc#1039830).
+      #
+      OPTIONAL_PACKAGES = [ "ntfs-3g", "ntfsprogs" ]
+      #
       # configurable part ends here
       #======================================================================
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-3.2.11/src/modules/Storage.rb 
new/yast2-storage-3.2.14/src/modules/Storage.rb
--- old/yast2-storage-3.2.11/src/modules/Storage.rb     2017-03-23 
10:55:36.758441739 +0100
+++ new/yast2-storage-3.2.14/src/modules/Storage.rb     2017-05-31 
11:00:47.633991997 +0200
@@ -354,6 +354,9 @@
       @conts = getContainers
       log.info("InitLibstorage conts:#{@conts}")
 
+      # Initializes default subvolume name (bsc#1040154)
+      FileSystems.read_default_subvol_from_target unless Stage.initial
+
       true
     end
 
@@ -4864,12 +4867,22 @@
     end
 
 
-    # return list of missing packages in the running system
+    # Return list of missing packages in the running system
     def missing_packages
       used_features = Yast::StorageHelpers::UsedStorageFeatures.new(@sint)
       features = used_features.collect_features
       packages = used_features.feature_packages(features)
       packages = packages.delete_if { |package| Package.Installed(package) }
+      packages = packages.delete_if { |package| 
unavailable_optional_package?(package) }
+    end
+
+    # Return 'true' if a package is an optional package that is unavailable.
+    def unavailable_optional_package?(package)
+      return false unless 
Yast::StorageHelpers::UsedStorageFeatures::OPTIONAL_PACKAGES.include?(package)
+      log.info("Checking optional pkg #{package}")
+      return false if Package.Available(package)
+      log.warn("WARNING: Skipping unavailable filesystem support package 
#{package}")
+      true
     end
 
 
@@ -5982,6 +5995,7 @@
       used_features = Yast::StorageHelpers::UsedStorageFeatures.new(@sint)
       features = used_features.collect_features
       packages += used_features.feature_packages(features)
+      packages = packages.delete_if { |package| 
unavailable_optional_package?(package) }
 
       log.info("AddPackageList(): packages: #{packages}")
       packages
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-storage-3.2.11/test/storage_test.rb 
new/yast2-storage-3.2.14/test/storage_test.rb
--- old/yast2-storage-3.2.11/test/storage_test.rb       2017-03-23 
10:55:36.766441739 +0100
+++ new/yast2-storage-3.2.14/test/storage_test.rb       2017-05-31 
11:00:47.645991997 +0200
@@ -10,11 +10,38 @@
 describe "Yast::Storage" do
   subject { Yast::Storage }
 
-  before do
-    subject.InitLibstorage(false)
+  before { subject.main }
+
+  describe "#InitLibstorage" do
+    around do |example|
+      old_stage = Yast::Stage.stage
+      Yast::Stage.Set(stage)
+      example.run
+      Yast::Stage.Set(old_stage)
+    end
+
+    context "when running in the initial stage" do
+      let(:stage) { "initial" }
+
+      it "does not read the default subvolume from the target system" do
+        expect(Yast::FileSystems).to_not 
receive(:read_default_subvol_from_target)
+        subject.InitLibstorage(false)
+      end
+    end
+
+    context "when not running in the initial stage" do
+      let(:stage) { "normal" }
+
+      it "reads the default subvolume from the target system" do
+        expect(Yast::FileSystems).to receive(:read_default_subvol_from_target)
+        subject.InitLibstorage(false)
+      end
+    end
   end
 
   describe "#SetUserdata" do
+    before { subject.InitLibstorage(false) }
+
     it "sets given user data for a given device" do
       # non-zero error for device that does not exist
       expect(subject.SetUserdata("/dev/ice/does/not/exist", { "/" => 
"snapshots" })).not_to eq(0)
@@ -22,6 +49,8 @@
   end
 
   describe "#default_subvolume_name" do
+    before { subject.InitLibstorage(false) }
+
     it "returns the default subvolume name according to FileSystems" do
       expect(Yast::FileSystems).to 
receive(:default_subvol).and_return("SOME-VALUE")
       expect(subject.default_subvolume_name).to eq("SOME-VALUE")


Reply via email to