Hello community,
here is the log from the commit of package yast2-firewall for openSUSE:Factory
checked in at 2017-06-16 14:20:53
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-firewall (Old)
and /work/SRC/openSUSE:Factory/.yast2-firewall.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-firewall"
Fri Jun 16 14:20:53 2017 rev:54 rq:503618 version:3.2.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-firewall/yast2-firewall.changes
2017-04-12 17:10:34.995105739 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-firewall.new/yast2-firewall.changes
2017-06-16 14:20:57.379821532 +0200
@@ -1,0 +2,8 @@
+Wed Jun 14 07:37:51 UTC 2017 - mfi...@suse.com
+
+- bnc#1044045
+ - do not raise an internal error when pushing Add button when
+ "Service to Allow" list is empty
+- 3.2.0
+
+-------------------------------------------------------------------
Old:
----
yast2-firewall-3.1.7.tar.bz2
New:
----
yast2-firewall-3.2.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-firewall.spec ++++++
--- /var/tmp/diff_new_pack.B26CUP/_old 2017-06-16 14:20:57.879750994 +0200
+++ /var/tmp/diff_new_pack.B26CUP/_new 2017-06-16 14:20:57.883750430 +0200
@@ -17,7 +17,7 @@
Name: yast2-firewall
-Version: 3.1.7
+Version: 3.2.0
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-firewall-3.1.7.tar.bz2 -> yast2-firewall-3.2.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-firewall-3.1.7/package/yast2-firewall.changes
new/yast2-firewall-3.2.0/package/yast2-firewall.changes
--- old/yast2-firewall-3.1.7/package/yast2-firewall.changes 2017-04-10
14:25:02.844754989 +0200
+++ new/yast2-firewall-3.2.0/package/yast2-firewall.changes 2017-06-14
10:19:52.473240753 +0200
@@ -1,4 +1,12 @@
-------------------------------------------------------------------
+Wed Jun 14 07:37:51 UTC 2017 - mfi...@suse.com
+
+- bnc#1044045
+ - do not raise an internal error when pushing Add button when
+ "Service to Allow" list is empty
+- 3.2.0
+
+-------------------------------------------------------------------
Fri Apr 7 13:51:51 UTC 2017 - gso...@suse.com
- Inform the user if start/stop/restart fails bsc#962713
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-firewall-3.1.7/package/yast2-firewall.spec
new/yast2-firewall-3.2.0/package/yast2-firewall.spec
--- old/yast2-firewall-3.1.7/package/yast2-firewall.spec 2017-04-10
14:25:02.844754989 +0200
+++ new/yast2-firewall-3.2.0/package/yast2-firewall.spec 2017-06-14
10:19:52.473240753 +0200
@@ -17,7 +17,7 @@
Name: yast2-firewall
-Version: 3.1.7
+Version: 3.2.0
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-firewall-3.1.7/src/include/firewall/uifunctions.rb
new/yast2-firewall-3.2.0/src/include/firewall/uifunctions.rb
--- old/yast2-firewall-3.1.7/src/include/firewall/uifunctions.rb
2017-04-10 14:25:02.868754989 +0200
+++ new/yast2-firewall-3.2.0/src/include/firewall/uifunctions.rb
2017-06-14 10:19:52.513240753 +0200
@@ -651,7 +651,6 @@
# @return [Boolean] whether everything was ok or whether user wants is
despite the error
def CheckAdditionalServicesDefinition(services_definition)
if Builtins.regexpmatch(services_definition, ",")
- ports = Builtins.splitstring(services_definition, ",")
return Popup.YesNoHeadline(
# TRANSLATORS: popup headline
_("Invalid Additional Service Definition"),
@@ -950,6 +949,9 @@
add_service = Convert.to_string(
UI.QueryWidget(Id("allow_service_names"), :Value)
)
+
+ return nil if add_service.empty?
+
SuSEFirewall.SetServicesForZones([add_service], [current_zone], true)
RedrawAllowedServices(current_zone)
elsif ret == "remove_allowed_service"
