Hello community, here is the log from the commit of package cinnamon for openSUSE:Factory checked in at 2017-07-12 19:36:42 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/cinnamon (Old) and /work/SRC/openSUSE:Factory/.cinnamon.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "cinnamon" Wed Jul 12 19:36:42 2017 rev:19 rq:509696 version:3.4.4 Changes: -------- --- /work/SRC/openSUSE:Factory/cinnamon/cinnamon.changes 2017-06-29 15:17:27.109236261 +0200 +++ /work/SRC/openSUSE:Factory/.cinnamon.new/cinnamon.changes 2017-07-12 19:36:53.884787646 +0200 @@ -1,0 +2,20 @@ +Wed Jul 12 09:45:18 UTC 2017 - sor.ale...@meowr.ru + +- Require NetworkManager-gnome on openSUSE older than Leap 15.x + still (boo#1047540). + +------------------------------------------------------------------- +Sun Jul 9 12:20:12 UTC 2017 - sor.ale...@meowr.ru + +- Update to version 3.4.4: + * classicSwitcher.js: Fix hidpi issues. + * KeybindingWidgets.py: Fix parsing of accelerators that are + shifted but not alpha-numeric characters. + * xlet-settings.py: Do not crash when an invalid xlet id is + provided. + * window-list applet: Fix argument warning. + * Add an issue template. + * ui/settings: Handle undefined old settings values. + * hotCorner.js: Fix hover delay callback. + +------------------------------------------------------------------- Old: ---- Cinnamon-3.4.3.tar.gz New: ---- Cinnamon-3.4.4.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ cinnamon.spec ++++++ --- /var/tmp/diff_new_pack.7TLRn2/_old 2017-07-12 19:36:55.192602909 +0200 +++ /var/tmp/diff_new_pack.7TLRn2/_new 2017-07-12 19:36:55.196602343 +0200 @@ -21,7 +21,7 @@ %define _name Cinnamon %define _version 3.4.0 Name: cinnamon -Version: 3.4.3 +Version: 3.4.4 Release: 0 Summary: GNU/Linux Desktop featuring a traditional layout License: GPL-2.0+ AND LGPL-2.1 @@ -131,7 +131,7 @@ Requires: python-gobject-Gdk Requires: python3-gobject-Gdk %endif -%if 0%{?suse_version} > 1320 || (0%{?sle_version} >= 120300 && 0%{?is_opensuse}) +%if 0%{?suse_version} > 1320 Requires: NetworkManager-applet %else Requires: NetworkManager-gnome @@ -252,7 +252,6 @@ %glib2_gsettings_schema_postun %files -%defattr(-,root,root) %doc AUTHORS COPYING README.rst debian/changelog %dir %{_sysconfdir}/xdg/menus/ %config %{_sysconfdir}/xdg/menus/%{name}-applications.menu @@ -289,11 +288,9 @@ %{_datadir}/gtk-doc/* %files gschemas -%defattr(-,root,root) %{_datadir}/glib-2.0/schemas/org.cinnamon.gschema.xml %files gschemas-branding-upstream -%defattr(-,root,root) %doc README.Gsettings-overrides %{_datadir}/%{name}/theme/menu*.svg ++++++ Cinnamon-3.4.3.tar.gz -> Cinnamon-3.4.4.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/.github/ISSUE_TEMPLATE.md new/Cinnamon-3.4.4/.github/ISSUE_TEMPLATE.md --- old/Cinnamon-3.4.3/.github/ISSUE_TEMPLATE.md 1970-01-01 01:00:00.000000000 +0100 +++ new/Cinnamon-3.4.4/.github/ISSUE_TEMPLATE.md 2017-07-06 11:18:17.000000000 +0200 @@ -0,0 +1,21 @@ + +``` + * Cinnamon version (cinnamon --version) + * Distribution - (Mint 17.2, Arch, Fedora 25, etc...) + * Graphics hardware *and* driver used + * 32 or 64 bit + ``` + +**Issue** + + + +**Steps to reproduce** + + + +**Expected behaviour** + + + +**Other information** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/configure.ac new/Cinnamon-3.4.4/configure.ac --- old/Cinnamon-3.4.3/configure.ac 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/configure.ac 2017-07-06 11:18:17.000000000 +0200 @@ -1,5 +1,5 @@ AC_PREREQ(2.63) -AC_INIT([cinnamon],[3.4.3],[https://github.com/linuxmint/Cinnamon/issues],[cinnamon]) +AC_INIT([cinnamon],[3.4.4],[https://github.com/linuxmint/Cinnamon/issues],[cinnamon]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_SRCDIR([src/cinnamon-global.c]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/debian/changelog new/Cinnamon-3.4.4/debian/changelog --- old/Cinnamon-3.4.3/debian/changelog 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/debian/changelog 2017-07-06 11:18:17.000000000 +0200 @@ -1,3 +1,24 @@ +cinnamon (3.4.4) sonya; urgency=medium + + [ Michael Webster ] + * classicSwitcher.js: Fix hidpi issues. + * KeybindingWidgets.py: fix parsing of accelerators that are shifted but not alpha-numeric characters. + * xlet-settings.py: Don't crash when an invalid xlet id is provided. + + [ itzexor ] + * window-list applet: fix argument warning + + [ Michael Webster ] + * add issue template + + [ Jason Hicks ] + * ui/settings: Handle undefined old settings values + + [ Michael Webster ] + * hotCorner.js: Fix hover delay callback. + + -- Clement Lefebvre <r...@linuxmint.com> Thu, 06 Jul 2017 11:17:41 +0200 + cinnamon (3.4.3) sonya; urgency=medium [ Michael Webster ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/files/usr/share/cinnamon/applets/window-l...@cinnamon.org/applet.js new/Cinnamon-3.4.4/files/usr/share/cinnamon/applets/window-l...@cinnamon.org/applet.js --- old/Cinnamon-3.4.3/files/usr/share/cinnamon/applets/window-l...@cinnamon.org/applet.js 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/files/usr/share/cinnamon/applets/window-l...@cinnamon.org/applet.js 2017-07-06 11:18:17.000000000 +0200 @@ -887,7 +887,7 @@ } else { item = new PopupMenu.PopupIconMenuItem(_("Minimize"), "view-sort-ascending", St.IconType.SYMBOLIC); item.connect('activate', function() { - mw.minimize(global.get_current_time()); + mw.minimize(); }); } this.addMenuItem(item); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py new/Cinnamon-3.4.4/files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py --- old/Cinnamon-3.4.3/files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py 2017-07-06 11:18:17.000000000 +0200 @@ -216,11 +216,6 @@ shift_group_mask = keymap.get_modifier_mask(Gdk.ModifierIntent.SHIFT_GROUP) - if Gtk.accelerator_get_default_mod_mask() & accel_mods & shift_group_mask: - accel_mods &= ~shift_group_mask - group = 0 - group_mask_disabled = True - retval, keyval, effective_group, level, consumed_modifiers = \ keymap.translate_keyboard_state(event.hardware_keycode, accel_mods, group) @@ -236,11 +231,6 @@ accel_mods &= Gtk.accelerator_get_default_mod_mask() - accel_mods &= ~consumed_modifiers - - if accel_key != keyval: - accel_mods |= Gdk.ModifierType.SHIFT_MASK - if accel_mods == 0: if accel_key == Gdk.KEY_Escape: self.update_label() @@ -259,6 +249,8 @@ accel_string = Gtk.accelerator_name_with_keycode(None, accel_key, event.hardware_keycode, Gdk.ModifierType(accel_mods)) accel_label = Gtk.accelerator_get_label_with_keycode(None, accel_key, event.hardware_keycode, Gdk.ModifierType(accel_mods)) + # print("Storing %s as %s" % (accel_label, accel_string)) + if (accel_mods == 0 or accel_mods == Gdk.ModifierType.SHIFT_MASK) and event.hardware_keycode != 0: if ((keyval >= Gdk.KEY_a and keyval <= Gdk.KEY_z) or (keyval >= Gdk.KEY_A and keyval <= Gdk.KEY_Z) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/files/usr/share/cinnamon/cinnamon-settings/xlet-settings.py new/Cinnamon-3.4.4/files/usr/share/cinnamon/cinnamon-settings/xlet-settings.py --- old/Cinnamon-3.4.3/files/usr/share/cinnamon/cinnamon-settings/xlet-settings.py 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/files/usr/share/cinnamon/cinnamon-settings/xlet-settings.py 2017-07-06 11:18:17.000000000 +0200 @@ -119,7 +119,7 @@ self.xlet_meta = json.loads(raw_data) else: print("Could not find %s metadata for uuid %s - are you sure it's installed correctly?" % (self.type, self.uuid)) - self.quit() + quit() def build_window(self): self.window = Gtk.Window() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/js/ui/appSwitcher/classicSwitcher.js new/Cinnamon-3.4.4/js/ui/appSwitcher/classicSwitcher.js --- old/Cinnamon-3.4.3/js/ui/appSwitcher/classicSwitcher.js 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/js/ui/appSwitcher/classicSwitcher.js 2017-07-06 11:18:17.000000000 +0200 @@ -16,7 +16,6 @@ const WindowUtils = imports.misc.windowUtils; -const POPUP_APPICON_SIZE = 96; const POPUP_SCROLL_TIME = 0.10; // seconds const POPUP_DELAY_TIMEOUT = 150; // milliseconds const POPUP_FADE_OUT_TIME = 0.1; // seconds @@ -428,7 +427,7 @@ set_size: function(size) { if (this.showThumbnail){ this.icon = new St.Widget(); - let clones = WindowUtils.createWindowClone(this.window, size, size, true, true); + let clones = WindowUtils.createWindowClone(this.window, size * global.ui_scale, size * global.ui_scale, true, true); for (let i in clones) { let clone = clones[i]; this.icon.add_actor(clone.actor); @@ -444,6 +443,7 @@ icon_type: St.IconType.FULLCOLOR, icon_size: size }); } + size *= global.ui_scale; this._iconBin.set_size(size, size); this._iconBin.child = this.icon; } @@ -823,7 +823,7 @@ for(let i = 0; i < iconSizes.length; i++) { this._iconSize = iconSizes[i]; - height = iconSizes[i] + iconSpacing; + height = (iconSizes[i] * global.ui_scale) + iconSpacing; let w = height * this._items.length + totalSpacing; if (w <= availWidth) break; @@ -831,7 +831,7 @@ if (this._items.length == 1) { this._iconSize = iconSizes[0]; - height = iconSizes[0] + iconSpacing; + height = (iconSizes[0] * global.ui_scale) + iconSpacing; } for(let i = 0; i < this.icons.length; i++) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/js/ui/hotCorner.js new/Cinnamon-3.4.4/js/ui/hotCorner.js --- old/Cinnamon-3.4.3/js/ui/hotCorner.js 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/js/ui/hotCorner.js 2017-07-06 11:18:17.000000000 +0200 @@ -282,9 +282,12 @@ this.runAction(); } } + + this.hover_delay_id = 0; + return false; })); - this.hover_delay_id = 0; - return false; + + return Clutter.EVENT_PROPAGATE; }, _onCornerClicked: function() { @@ -296,7 +299,8 @@ if (this.shouldToggleOverviewOnClick()) this.rippleAnimation(); this.runAction(); - return true; + + return Clutter.EVENT_STOP; }, _onCornerLeft: function(actor, event) { @@ -307,14 +311,16 @@ if (event.get_related() != this.actor) this._entered = false; + // Consume event, otherwise this will confuse onEnvironsLeft - return true; + return Clutter.EVENT_STOP; }, _onEnvironsLeft: function(actor, event) { if (event.get_related() != this._corner) this._entered = false; - return false; + + return Clutter.EVENT_PROPAGATE; }, // Checks if the Activities button is currently sensitive to diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Cinnamon-3.4.3/js/ui/settings.js new/Cinnamon-3.4.4/js/ui/settings.js --- old/Cinnamon-3.4.3/js/ui/settings.js 2017-06-26 12:45:06.000000000 +0200 +++ new/Cinnamon-3.4.4/js/ui/settings.js 2017-07-06 11:18:17.000000000 +0200 @@ -553,7 +553,10 @@ let changed = false; for (let key in this.settingsData) { - if (this.settingsData[key].value === undefined) continue; + if (!this.settingsData[key] + || this.settingsData[key].value === undefined + || !oldSettings[key] + || oldSettings[key].value === undefined) continue; let oldValue = oldSettings[key].value; let value = this.settingsData[key].value;