Hello community, here is the log from the commit of package snack for openSUSE:Factory checked in at 2017-11-04 19:29:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/snack (Old) and /work/SRC/openSUSE:Factory/.snack.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "snack" Sat Nov 4 19:29:59 2017 rev:19 rq:538814 version:2.2.10 Changes: -------- --- /work/SRC/openSUSE:Factory/snack/snack.changes 2011-09-23 12:46:32.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.snack.new/snack.changes 2017-11-04 19:30:29.858471755 +0100 @@ -1,0 +2,7 @@ +Fri Nov 3 16:30:06 UTC 2017 - m...@suse.com + +- bnc#793860: CVE-2012-6303: heap based overflow: + snack-CVE-2012-6303.patch +- Drop the demos, they violate too many rpmlint rules. + +------------------------------------------------------------------- New: ---- snack-CVE-2012-6303.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ snack.spec ++++++ --- /var/tmp/diff_new_pack.3wdSDp/_old 2017-11-04 19:30:31.390415780 +0100 +++ /var/tmp/diff_new_pack.3wdSDp/_new 2017-11-04 19:30:31.390415780 +0100 @@ -1,7 +1,7 @@ # -# spec file for package snack (Version 2.2.10) +# spec file for package snack # -# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -15,23 +15,27 @@ # Please submit bugfixes or comments via http://bugs.opensuse.org/ # -# norootforbuild - Name: snack -BuildRequires: alsa-devel libvorbis-devel python tk-devel xorg-x11-devel +BuildRequires: alsa-devel +BuildRequires: libvorbis-devel +BuildRequires: python +BuildRequires: tk-devel +BuildRequires: xorg-x11-devel Summary: Sound Extension for Tcl/Tk and Python -Version: 2.2.10 -Release: 192 +License: GPL-2.0+ Group: Development/Libraries/Tcl -Requires: tcl tk +Version: 2.2.10 +Release: 0 +Requires: tcl +Requires: tk %{py_requires} -License: GPL-2.0+ Url: http://www.speech.kth.se/snack Source0: %{name}%{version}.tar.bz2 Source1: snack-rpmlintrc Patch0: snack.patch Patch1: snack-alsa.patch +Patch2: snack-CVE-2012-6303.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -60,11 +64,12 @@ %setup -q -n %{name}%{version} %patch0 %patch1 +%patch2 -p 1 chmod 644 BSD.txt changes README COPYING doc/* ext/* chmod 755 ext/configure %build -export CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing" +export CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -Wno-unused-variable -Wno-unused-but-set-variable" cd unix ./configure \ --prefix=%_prefix \ @@ -92,7 +97,6 @@ %files %defattr(-, root, root,-) %_libdir/lib* -%doc demos %defattr(644, root, root, 755) %doc BSD.txt changes README COPYING doc/* ext %tclscriptdir/* ++++++ snack-CVE-2012-6303.patch ++++++ Index: snack2.2.10/generic/jkSoundFile.c =================================================================== --- snack2.2.10.orig/generic/jkSoundFile.c +++ snack2.2.10/generic/jkSoundFile.c @@ -1793,7 +1793,14 @@ static int GetHeaderBytes(Sound *s, Tcl_Interp *interp, Tcl_Channel ch, char *buf, int len) { - int rlen = Tcl_Read(ch, &buf[s->firstNRead], len - s->firstNRead); + int rlen; + + if (len > max(CHANNEL_HEADER_BUFFER, HEADBUF)){ + Tcl_AppendResult(interp, "Excessive header size", NULL); + return TCL_ERROR; + } + + rlen = Tcl_Read(ch, &buf[s->firstNRead], len - s->firstNRead); if (rlen < len - s->firstNRead){ Tcl_AppendResult(interp, "Failed reading header bytes", NULL);
