Hello community, here is the log from the commit of package gnome-pomodoro for openSUSE:Factory checked in at 2017-11-22 11:22:17 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-pomodoro (Old) and /work/SRC/openSUSE:Factory/.gnome-pomodoro.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-pomodoro" Wed Nov 22 11:22:17 2017 rev:10 rq:544187 version:0.13.4 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-pomodoro/gnome-pomodoro.changes 2017-09-15 22:32:05.928809795 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-pomodoro.new/gnome-pomodoro.changes 2017-11-22 11:22:23.781408747 +0100 @@ -1,0 +2,15 @@ +Tue Nov 21 10:08:26 UTC 2017 - mvet...@suse.com + +- Update to 0.13.4: + + Add and update various translations. + + Fix hiding notifications during pomodoro. + + Update sound file in canberra cache. + + Log timer entries in database. + + Simple blur effect for the notification dialog. + + Display screen notification timer only on primary monitor. + + Display notifications despite timer being paused. + + gnome: Use Shell D-Bus instead of gsettings. + + Wait for plugins capabilities during startup. + + Various bugfixes. + +------------------------------------------------------------------- @@ -5,5 +20,5 @@ - + Fix hiding notifications during pomodoro - + Update sound file in canberra cache - + Simplify Utils.Patch class - + Update and add translations - + Mark as compatible with GNOME 3.26 + + Fix hiding notifications during pomodoro. + + Update sound file in canberra cache. + + Simplify Utils.Patch class. + + Update and add translations. + + Mark as compatible with GNOME 3.26. Old: ---- 0.13.3.tar.gz New: ---- 0.13.4.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-pomodoro.spec ++++++ --- /var/tmp/diff_new_pack.qK9ig3/_old 2017-11-22 11:22:24.865369359 +0100 +++ /var/tmp/diff_new_pack.qK9ig3/_new 2017-11-22 11:22:24.865369359 +0100 @@ -19,7 +19,7 @@ %global __requires_exclude typelib\\(Meta\\) Name: gnome-pomodoro -Version: 0.13.3 +Version: 0.13.4 Release: 0 Summary: A time management utility for GNOME License: GPL-3.0+ ++++++ 0.13.3.tar.gz -> 0.13.4.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.13.3/NEWS new/gnome-pomodoro-0.13.4/NEWS --- old/gnome-pomodoro-0.13.3/NEWS 2017-09-06 20:56:05.000000000 +0200 +++ new/gnome-pomodoro-0.13.4/NEWS 2017-11-20 23:54:09.000000000 +0100 @@ -1,3 +1,8 @@ +2017-11-20 Kamil Prusko <kamilpru...@gmail.com> + Release version 0.13.4: + + * Fix for causing gnome-shell segfault (thanks @berenddeschouwer and @3v1n0) + 2017-09-06 Kamil Prusko <kamilpru...@gmail.com> Release version 0.13.3: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.13.3/configure.ac new/gnome-pomodoro-0.13.4/configure.ac --- old/gnome-pomodoro-0.13.3/configure.ac 2017-09-06 20:56:05.000000000 +0200 +++ new/gnome-pomodoro-0.13.4/configure.ac 2017-11-20 23:54:09.000000000 +0100 @@ -1,6 +1,6 @@ AC_PREREQ([2.69]) AC_INIT([gnome-pomodoro], - [0.13.3], + [0.13.4], [https://github.com/codito/gnome-pomodoro/issues], [gnome-pomodoro], [http://gnomepomodoro.org]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.13.3/data/Makefile.am new/gnome-pomodoro-0.13.4/data/Makefile.am --- old/gnome-pomodoro-0.13.3/data/Makefile.am 2017-09-06 20:56:05.000000000 +0200 +++ new/gnome-pomodoro-0.13.4/data/Makefile.am 2017-11-20 23:54:09.000000000 +0100 @@ -27,7 +27,7 @@ @APPSTREAM_XML_RULES@ $(appstream_XML): $(appstream_in_files) - $(AM_V_GEN) $(MSGFMT) --xml -d $(top_srcdir)/po --template $< -o $@ + $(AM_V_GEN) cp $< $@ EXTRA_DIST = \ $(appstream_in_files) \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.13.3/plugins/gnome/extension/dialogs.js new/gnome-pomodoro-0.13.4/plugins/gnome/extension/dialogs.js --- old/gnome-pomodoro-0.13.3/plugins/gnome/extension/dialogs.js 2017-09-06 20:56:05.000000000 +0200 +++ new/gnome-pomodoro-0.13.4/plugins/gnome/extension/dialogs.js 2017-11-20 23:54:09.000000000 +0100 @@ -101,14 +101,15 @@ y_align: Clutter.ActorAlign.END, visible: false }); this.actor.add_actor(this._container); + this.actor.connect('destroy', Lang.bind(this, this._onActorDestroy)); - Main.messageTray.connect('source-added', Lang.bind(this, this._onSourceAdded)); - Main.messageTray.connect('source-removed', Lang.bind(this, this._onSourceRemoved)); + this._onSourceAddedId = Main.messageTray.connect('source-added', Lang.bind(this, this._onSourceAdded)); + this._onSourceRemovedId = Main.messageTray.connect('source-removed', Lang.bind(this, this._onSourceRemoved)); let sources = Main.messageTray.getSources(); sources.forEach(Lang.bind(this, function(source) { this._onSourceAdded(null, source); })); - Main.overview.connect('showing', Lang.bind(this, this._updateVisibility)); + this._overviewShowingId = Main.overview.connect('showing', Lang.bind(this, this._updateVisibility)); }, _onSourceAdded: function(tray, source) { @@ -116,23 +117,35 @@ return; } - source.connect('count-updated', Lang.bind(this, this._updateCount)); - this._sources.push(source); + let sourceInfo = { + source: source, + countUpdatedId: source.connect('count-updated', Lang.bind(this, this._updateCount)) + }; + this._sources.push(sourceInfo); this._updateCount(); }, _onSourceRemoved: function(tray, source) { - this._sources.splice(this._sources.indexOf(source), 1); - this._updateCount(); + let index, sourceInfo; + + for (index=0; index < this._sources.length; index++) { + sourceInfo = this._sources[index]; + if (sourceInfo.source === source) { + sourceInfo.source.disconnect(sourceInfo.countUpdatedId); + this._sources.splice(index, 1); + this._updateCount(); + break; + } + } }, _updateCount: function() { let count = 0; let hasChats = false; this._sources.forEach(Lang.bind(this, - function(source) { - count += source.indicatorCount; - hasChats |= source.isChat; + function(sourceInfo) { + count += sourceInfo.source.unseenCount || sourceInfo.source.indicatorCount; + hasChats |= sourceInfo.source.isChat; })); this._count = count; @@ -151,8 +164,40 @@ let visible = (this._count > 0); this.actor.visible = visible; + }, + + _disconnectSignals: function() { + let sourceInfo; + + if (this._onSourceAddedId) { + Main.messageTray.disconnect(this._onSourceAddedId); + this._onSourceAddedId = 0; + } + if (this._onSourceRemovedId) { + Main.messageTray.disconnect(this._onSourceRemovedId); + this._onSourceRemovedId = 0; + } + + if (this._overviewShowingId) { + Main.overview.disconnect(this._overviewShowingId); + this._overviewShowingId = 0; + } + + while (this._sources.length > 0) { + sourceInfo = this._sources.pop(); + sourceInfo.source.disconnect(sourceInfo.countUpdatedId); + } + }, + + _onActorDestroy: function() { + if (this._destroyed) + return; + this._destroyed = true; + this._disconnectSignals(); + this.emit('destroy'); } }); +Signals.addSignalMethods(MessagesIndicator.prototype); /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.13.3/plugins/gnome/extension/indicator.js new/gnome-pomodoro-0.13.4/plugins/gnome/extension/indicator.js --- old/gnome-pomodoro-0.13.3/plugins/gnome/extension/indicator.js 2017-09-06 20:56:05.000000000 +0200 +++ new/gnome-pomodoro-0.13.4/plugins/gnome/extension/indicator.js 2017-11-20 23:54:09.000000000 +0100 @@ -70,6 +70,9 @@ this.parent(indicator.actor, St.Align.START, St.Side.TOP); this._timerUpdateId = 0; + this._isRunning = false; + this._isPaused = false; + this._timerState = undefined; this.actor.add_style_class_name('extension-pomodoro-indicator-menu');