Hello community, here is the log from the commit of package yast2-bootloader for openSUSE:Factory checked in at 2018-02-02 22:18:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-bootloader (Old) and /work/SRC/openSUSE:Factory/.yast2-bootloader.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-bootloader" Fri Feb 2 22:18:18 2018 rev:250 rq:570915 version:4.0.14 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-bootloader/yast2-bootloader.changes 2018-01-17 21:44:11.830841902 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-bootloader.new/yast2-bootloader.changes 2018-02-02 22:18:19.768947531 +0100 @@ -1,0 +2,6 @@ +Tue Jan 30 11:22:10 UTC 2018 - jreidin...@suse.com + +- fix crash when clicking link in proposal (bsc#1078227) +- 4.0.14 + +------------------------------------------------------------------- Old: ---- yast2-bootloader-4.0.13.tar.bz2 New: ---- yast2-bootloader-4.0.14.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-bootloader.spec ++++++ --- /var/tmp/diff_new_pack.M9icPX/_old 2018-02-02 22:18:20.524912239 +0100 +++ /var/tmp/diff_new_pack.M9icPX/_new 2018-02-02 22:18:20.532911866 +0100 @@ -17,7 +17,7 @@ Name: yast2-bootloader -Version: 4.0.13 +Version: 4.0.14 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-bootloader-4.0.13.tar.bz2 -> yast2-bootloader-4.0.14.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-4.0.13/package/yast2-bootloader.changes new/yast2-bootloader-4.0.14/package/yast2-bootloader.changes --- old/yast2-bootloader-4.0.13/package/yast2-bootloader.changes 2018-01-16 18:14:01.000000000 +0100 +++ new/yast2-bootloader-4.0.14/package/yast2-bootloader.changes 2018-01-30 12:37:25.000000000 +0100 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Tue Jan 30 11:22:10 UTC 2018 - jreidin...@suse.com + +- fix crash when clicking link in proposal (bsc#1078227) +- 4.0.14 + +------------------------------------------------------------------- Tue Jan 16 16:51:54 UTC 2018 - jreidin...@suse.com - fix crash for getting partition to activate when stage1 device diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-4.0.13/package/yast2-bootloader.spec new/yast2-bootloader-4.0.14/package/yast2-bootloader.spec --- old/yast2-bootloader-4.0.13/package/yast2-bootloader.spec 2018-01-16 18:14:01.000000000 +0100 +++ new/yast2-bootloader-4.0.14/package/yast2-bootloader.spec 2018-01-30 12:37:25.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-bootloader -Version: 4.0.13 +Version: 4.0.14 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-4.0.13/src/lib/bootloader/proposal_client.rb new/yast2-bootloader-4.0.14/src/lib/bootloader/proposal_client.rb --- old/yast2-bootloader-4.0.13/src/lib/bootloader/proposal_client.rb 2018-01-16 18:14:01.000000000 +0100 +++ new/yast2-bootloader-4.0.14/src/lib/bootloader/proposal_client.rb 2018-01-30 12:37:25.000000000 +0100 @@ -221,11 +221,12 @@ def single_click_action(option, value) stage1 = ::Bootloader::BootloaderFactory.current.stage1 - locations = stage1.available_locations - device = locations[option.to_sym] or raise "invalid option #{option}" - log.info "single_click_action #{option} #{value.inspect} #{device}" + devices = option.to_sym == :mbr ? stage1.boot_disk_names : stage1.boot_partition_names + log.info "single_click_action #{option} #{value.inspect} #{devices}" - value ? stage1.add_udev_device(device) : stage1.remove_device(device) + devices.each do |device| + value ? stage1.add_udev_device(device) : stage1.remove_device(device) + end Yast::Bootloader.proposed_cfg_changed = true end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-bootloader-4.0.13/test/bootloader_proposal_client_test.rb new/yast2-bootloader-4.0.14/test/bootloader_proposal_client_test.rb --- old/yast2-bootloader-4.0.13/test/bootloader_proposal_client_test.rb 2018-01-16 18:14:01.000000000 +0100 +++ new/yast2-bootloader-4.0.14/test/bootloader_proposal_client_test.rb 2018-01-30 12:37:25.000000000 +0100 @@ -7,16 +7,6 @@ describe Bootloader::ProposalClient do before do - allow_any_instance_of(::Bootloader::Stage1).to( - receive(:available_locations) - .and_return( - mbr: "/dev/sda", - boot: "/dev/sda1" - ) - ) - - allow_any_instance_of(::Bootloader::Stage1).to receive(:propose) - Bootloader::BootloaderFactory.clear_cache allow(Yast::Bootloader).to receive(:Reset) @@ -58,7 +48,7 @@ end it "sets to true that proposed cfg changed" do - subject.ask_user("chosen_id" => "disable_boot_mbr") + subject.ask_user("chosen_id" => "disable_boot_boot") expect(Yast::Bootloader.proposed_cfg_changed).to be true end