Hello community, here is the log from the commit of package gstreamer-plugins-ugly for openSUSE:Factory checked in at 2018-02-03 15:37:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gstreamer-plugins-ugly (Old) and /work/SRC/openSUSE:Factory/.gstreamer-plugins-ugly.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gstreamer-plugins-ugly" Sat Feb 3 15:37:27 2018 rev:47 rq:570558 version:1.12.4 Changes: -------- --- /work/SRC/openSUSE:Factory/gstreamer-plugins-ugly/gstreamer-plugins-ugly.changes 2017-12-21 11:27:12.849779096 +0100 +++ /work/SRC/openSUSE:Factory/.gstreamer-plugins-ugly.new/gstreamer-plugins-ugly.changes 2018-02-03 15:37:28.583456704 +0100 @@ -1,0 +2,6 @@ +Tue Jan 23 18:49:26 UTC 2018 - bjorn....@gmail.com + +- Add gst-ugly-amrnwbdec-fixes.patch: Fixes for amr plugins, only + built on third party. + +------------------------------------------------------------------- New: ---- gst-ugly-amrnwbdec-fixes.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gstreamer-plugins-ugly.spec ++++++ --- /var/tmp/diff_new_pack.16yKNV/_old 2018-02-03 15:37:29.431417097 +0100 +++ /var/tmp/diff_new_pack.16yKNV/_new 2018-02-03 15:37:29.443416536 +0100 @@ -32,6 +32,9 @@ Url: http://gstreamer.freedesktop.org/ Source: https://gstreamer.freedesktop.org/src/gst-plugins-ugly/%{_name}-%{version}.tar.xz Source99: baselibs.conf +# PATCH-FIX-UPSTREAM gst-ugly-amrnwbdec-fixes.patch bjorn....@gmail.com -- Fixes for amr plugins, only built on third party +Patch0: gst-ugly-amrnwbdec-fixes.patch + BuildRequires: gcc-c++ BuildRequires: gtk-doc >= 1.12 BuildRequires: liba52-devel @@ -123,6 +126,7 @@ %prep %setup -q -n %{_name}-%{version} +%patch0 -p1 %build export PYTHON=/usr/bin/python3 ++++++ gst-ugly-amrnwbdec-fixes.patch ++++++ >From 6f2c1259b3ed66944ffeb48096a9c04677682480 Mon Sep 17 00:00:00 2001 From: Edward Hervey <edw...@centricular.com> Date: Wed, 3 Jan 2018 16:02:08 +0100 Subject: amrwbdec: Don't use g_return_*_if_fail() on data parsing Those functions can be disabled. Instead just use the (existing) function. CID #1427093 --- ext/amrwbdec/amrwbdec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ext/amrwbdec/amrwbdec.c b/ext/amrwbdec/amrwbdec.c index f90b7b7..cf05d95 100644 --- a/ext/amrwbdec/amrwbdec.c +++ b/ext/amrwbdec/amrwbdec.c @@ -172,14 +172,12 @@ gst_amrwbdec_parse (GstAudioDecoder * dec, GstAdapter * adapter, gint block, mode; size = gst_adapter_available (adapter); - g_return_val_if_fail (size > 0, GST_FLOW_ERROR); + if (size < 1) + return GST_FLOW_ERROR; gst_audio_decoder_get_parse_state (dec, &sync, &eos); /* need to peek data to get the size */ - if (size < 1) - return GST_FLOW_ERROR; - gst_adapter_copy (adapter, header, 0, 1); mode = (header[0] >> 3) & 0x0F; block = block_size[mode]; -- cgit v1.1 >From d7f845f05bb2ed59f7434d11b70e2a694f246b59 Mon Sep 17 00:00:00 2001 From: Edward Hervey <edw...@centricular.com> Date: Wed, 3 Jan 2018 16:02:08 +0100 Subject: amrnbdec: Don't use g_return_*_if_fail() on data parsing Those functions can be disabled. Instead just use the (existing) function. CID #1427121 --- ext/amrnb/amrnbdec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ext/amrnb/amrnbdec.c b/ext/amrnb/amrnbdec.c index 653f1c5..8f2c422 100644 --- a/ext/amrnb/amrnbdec.c +++ b/ext/amrnb/amrnbdec.c @@ -241,14 +241,12 @@ gst_amrnbdec_parse (GstAudioDecoder * dec, GstAdapter * adapter, gint block, mode; size = gst_adapter_available (adapter); - g_return_val_if_fail (size > 0, GST_FLOW_ERROR); + if (size < 1) + return GST_FLOW_ERROR; gst_audio_decoder_get_parse_state (dec, &sync, &eos); /* need to peek data to get the size */ - if (size < 1) - return GST_FLOW_ERROR; - gst_adapter_copy (adapter, head, 0, 1); /* get size */ -- cgit v1.1