Hello community,
here is the log from the commit of package switcheroo-control for
openSUSE:Factory checked in at 2018-02-22 15:03:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/switcheroo-control (Old)
and /work/SRC/openSUSE:Factory/.switcheroo-control.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "switcheroo-control"
Thu Feb 22 15:03:05 2018 rev:3 rq:578930 version:1.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/switcheroo-control/switcheroo-control.changes
2017-09-29 11:56:18.554994634 +0200
+++
/work/SRC/openSUSE:Factory/.switcheroo-control.new/switcheroo-control.changes
2018-02-22 15:03:08.228512211 +0100
@@ -1,0 +2,11 @@
+Tue Feb 20 23:23:27 UTC 2018 - luc1...@linuxmail.org
+
+- Add systemd-rpm-macros BuildRequires and service_add_*
+ pre/post/preun/postun scriptlets for switcheroo-control.service
+ to comply with openSUSE's Guidelines.
+- Pass --with-systemdsystemunitdir=%{_unitdir} parameter to
+ configure to correct the systemd unit file's location.
+- Adopt the use of %make_install macro rather than raw make
+ command, following the best practices.
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ switcheroo-control.spec ++++++
--- /var/tmp/diff_new_pack.zFTLGZ/_old 2018-02-22 15:03:10.496430629 +0100
+++ /var/tmp/diff_new_pack.zFTLGZ/_new 2018-02-22 15:03:10.496430629 +0100
@@ -26,9 +26,9 @@
Source0:
https://github.com/hadess/switcheroo-control/releases/download/1.2/%{name}-%{version}.tar.xz
Source1: %{name}-rpmlintrc
BuildRequires: gtk-doc
+BuildRequires: systemd-rpm-macros
BuildRequires: pkgconfig
BuildRequires: pkgconfig(gio-2.0)
-BuildRoot: %{_tmppath}/%{name}-%{version}-build
%{?systemd_requires}
%description
@@ -46,16 +46,32 @@
%setup -q
%build
-%configure --enable-gtk-doc
+%configure \
+ --with-systemdsystemunitdir=%{_unitdir} \
+ --enable-gtk-doc
make %{?_smp_mflags}
%install
-make %{?_smp_mflags} DESTDIR=%{buildroot} install
+%make_install
+
+%pre
+%service_add_pre switcheroo-control.service
+
+%post
+%service_add_post switcheroo-control.service
+
+%preun
+%service_del_preun switcheroo-control.service
+
+%postun
+%service_del_postun switcheroo-control.service
%files
%defattr(-,root,root)
-%doc NEWS README.md COPYING
+%license COPYING
+%doc NEWS README
%{_sbindir}/switcheroo-control
+%{_unitdir}/switcheroo-control.service
# Own dirs to avoid depending on dbus while building.
%dir %{_sysconfdir}/dbus-1
%dir %{_sysconfdir}/dbus-1/system.d
@@ -63,6 +79,6 @@
%files doc
%defattr(-,root,root)
-%{_datadir}/gtk-doc/html/%{name}/
+%doc %{_datadir}/gtk-doc/html/%{name}/
%changelog
