Hello community,

here is the log from the commit of package yast2-samba-client for 
openSUSE:Factory checked in at 2018-05-01 22:37:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-samba-client (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-samba-client.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-samba-client"

Tue May  1 22:37:56 2018 rev:94 rq:601935 version:4.0.2

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-samba-client/yast2-samba-client.changes    
2018-03-04 11:50:07.043526661 +0100
+++ 
/work/SRC/openSUSE:Factory/.yast2-samba-client.new/yast2-samba-client.changes   
    2018-05-01 22:37:58.388167083 +0200
@@ -1,0 +2,13 @@
+Fri Apr 27 13:36:58 UTC 2018 - palcant...@suse.de
+
+- yast-samba-client fails to join if /etc/samba/smb.conf or
+  /etc/krb5.conf don't exist; (bsc#1089938)
+- 4.0.2
+
+-------------------------------------------------------------------
+Fri Apr 27 08:43:58 UTC 2018 - knut.anders...@suse.com
+
+- Use firewalld samba service definition (bsc#1083456)
+- 4.0.1
+
+-------------------------------------------------------------------

Old:
----
  yast2-samba-client-4.0.0.tar.bz2

New:
----
  yast2-samba-client-4.0.2.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-samba-client.spec ++++++
--- /var/tmp/diff_new_pack.lZ7ZCG/_old  2018-05-01 22:37:59.124140294 +0200
+++ /var/tmp/diff_new_pack.lZ7ZCG/_new  2018-05-01 22:37:59.128140149 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-samba-client
-Version:        4.0.0
+Version:        4.0.2
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build

++++++ yast2-samba-client-4.0.0.tar.bz2 -> yast2-samba-client-4.0.2.tar.bz2 
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-samba-client-4.0.0/package/yast2-samba-client.changes 
new/yast2-samba-client-4.0.2/package/yast2-samba-client.changes
--- old/yast2-samba-client-4.0.0/package/yast2-samba-client.changes     
2018-02-05 12:30:04.000000000 +0100
+++ new/yast2-samba-client-4.0.2/package/yast2-samba-client.changes     
2018-04-27 16:03:57.000000000 +0200
@@ -1,4 +1,17 @@
 -------------------------------------------------------------------
+Fri Apr 27 13:36:58 UTC 2018 - palcant...@suse.de
+
+- yast-samba-client fails to join if /etc/samba/smb.conf or
+  /etc/krb5.conf don't exist; (bsc#1089938)
+- 4.0.2
+
+-------------------------------------------------------------------
+Fri Apr 27 08:43:58 UTC 2018 - knut.anders...@suse.com
+
+- Use firewalld samba service definition (bsc#1083456)
+- 4.0.1
+
+-------------------------------------------------------------------
 Fri Feb  2 17:03:31 UTC 2018 - knut.anders...@suse.com
 
 - SuSEFirewall2 replaced by firewalld (fate#323460)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-samba-client-4.0.0/package/yast2-samba-client.spec 
new/yast2-samba-client-4.0.2/package/yast2-samba-client.spec
--- old/yast2-samba-client-4.0.0/package/yast2-samba-client.spec        
2018-02-05 12:30:04.000000000 +0100
+++ new/yast2-samba-client-4.0.2/package/yast2-samba-client.spec        
2018-04-27 16:03:57.000000000 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-samba-client
-Version:        4.0.0
+Version:        4.0.2
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-samba-client-4.0.0/src/include/samba-client/dialogs.rb 
new/yast2-samba-client-4.0.2/src/include/samba-client/dialogs.rb
--- old/yast2-samba-client-4.0.0/src/include/samba-client/dialogs.rb    
2018-02-05 12:30:04.000000000 +0100
+++ new/yast2-samba-client-4.0.2/src/include/samba-client/dialogs.rb    
2018-04-27 16:03:57.000000000 +0200
@@ -557,7 +557,7 @@
       text_fam = _("Start File Alteration Monitor")
 
       firewall_widget = CWMFirewallInterfaces.CreateOpenFirewallWidget(
-        { "services" => ["samba-server"], "display_details" => true }
+        { "services" => ["samba"], "display_details" => true }
       )
       firewall_layout = Ops.get_term(firewall_widget, "custom_widget", VBox())
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-samba-client-4.0.0/src/modules/SambaAD.pm 
new/yast2-samba-client-4.0.2/src/modules/SambaAD.pm
--- old/yast2-samba-client-4.0.0/src/modules/SambaAD.pm 2018-02-05 
12:30:04.000000000 +0100
+++ new/yast2-samba-client-4.0.2/src/modules/SambaAD.pm 2018-04-27 
16:03:57.000000000 +0200
@@ -49,6 +49,9 @@
     FALSE => 0,
 };
 
+# create a dummy smb.conf file only for performing the libnet commands
+my $dummy_conf_file = SCR->Read (".target.tmpdir") . "/dummy-smb.conf";
+SCR->Write (".target.string", $dummy_conf_file, "");
 
 # Active Directory server
 my $ads                = "";
@@ -128,7 +131,7 @@
 
     y2milestone ("get ads: workgroup: $workgroup");
     
-    if (Mode->config ()) {
+    if (Mode->config () || !$workgroup) {
        return "";
     }
 
@@ -151,7 +154,7 @@
                chop $tmpserver;
            }
            if ($tmpserver) {
-               my $cmd = "LANG=C net ads lookup -S $tmpserver";
+               my $cmd = "LANG=C net -s $dummy_conf_file ads lookup -S 
$tmpserver";
                $out    = SCR->Execute (".target.bash_output", $cmd);
                if ($out->{"exit"} eq 0) {
                    foreach my $l (split (/\n/,$out->{"stdout"} || "")) {
@@ -228,7 +231,7 @@
        }
     }
     if ($server eq "") {
-       my $out = SCR->Execute (".target.bash_output", "LANG=C net LOOKUP DC 
$workgroup");
+       my $out = SCR->Execute (".target.bash_output", "LANG=C net -s 
$dummy_conf_file LOOKUP DC $workgroup");
        y2debug ("net LOOKUP DC $workgroup: ", Dumper ($out));
        if ($out->{"exit"} eq 0) {
            foreach my $line (split (/\n/,$out->{"stdout"} || "")) {
@@ -240,7 +243,7 @@
        }
     }
     if ($server ne "" &&
-       SCR->Execute (".target.bash", "net ads lookup -U% -S $server") ne 0) {
+       SCR->Execute (".target.bash", "net -s $dummy_conf_file ads lookup -U% 
-S $server") ne 0) {
        $server = "";
     }
     y2milestone ("returning server: $server");
@@ -293,7 +296,7 @@
 
     return "" if $server eq "";
 
-    my $out    = SCR->Execute (".target.bash_output", "net ads lookup -S 
$server | grep 'Pre-Win2k Domain' | cut -f 2");
+    my $out    = SCR->Execute (".target.bash_output", "net -s $dummy_conf_file 
ads lookup -S $server | grep 'Pre-Win2k Domain' | cut -f 2");
 
     y2debug ("net ads lookup -S $server: ", Dumper ($out));
     if ($out->{"exit"} ne 0 || $out->{"stdout"} eq "") {
@@ -326,7 +329,7 @@
 
     return "" if $server eq "";
 
-    my $out    = SCR->Execute (".target.bash_output", "net ads info -S $server 
| grep Realm | cut -f 2 -d ' '");
+    my $out    = SCR->Execute (".target.bash_output", "net -s $dummy_conf_file 
ads info -S $server | grep Realm | cut -f 2 -d ' '");
     
     y2debug ("net ads info -S $server: ", Dumper ($out));
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-samba-client-4.0.0/src/modules/SambaNetJoin.pm 
new/yast2-samba-client-4.0.2/src/modules/SambaNetJoin.pm
--- old/yast2-samba-client-4.0.0/src/modules/SambaNetJoin.pm    2018-02-05 
12:30:04.000000000 +0100
+++ new/yast2-samba-client-4.0.2/src/modules/SambaNetJoin.pm    2018-04-27 
16:03:57.000000000 +0200
@@ -323,6 +323,9 @@
               return __("Unable to proceed with join: Inconsistent cluster 
state");
             }
         }
+       # do not allow samba create and use a local krb5 conf that would 
override ours
+       $glb_overrides{"create krb5 conf"} = "no";
+
        $cmd            = "KRB5_CONFIG=$krb_file ";
        SCR->Write (".target.string", $krb_file, "[realms]\n\t$realm = {\n\tkdc 
= $server\n\t}\n");
     }
@@ -379,9 +382,7 @@
 
     my ($self, $domain, $user, $passwd) = @_;
     
-    my $tmpdir         = SCR->Read (".target.tmpdir");
     my $realm          = SambaAD->Realm ();
-    
     my $cmd = "net ads leave -U '"
        . String->Quote ($user) . "%" . String->Quote ($passwd) . "'";
 


Reply via email to