Hello community,
here is the log from the commit of package unzip for openSUSE:Factory checked
in at 2018-10-22 11:06:36
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/unzip (Old)
and /work/SRC/openSUSE:Factory/.unzip.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "unzip"
Mon Oct 22 11:06:36 2018 rev:44 rq:643125 version:6.00
Changes:
--------
--- /work/SRC/openSUSE:Factory/unzip/unzip-rcc.changes 2018-07-04
23:53:27.980002354 +0200
+++ /work/SRC/openSUSE:Factory/.unzip.new/unzip-rcc.changes 2018-10-22
11:06:57.236091138 +0200
@@ -1,0 +2,6 @@
+Thu Oct 11 14:49:01 UTC 2018 - kstreit...@suse.com
+
+- Add unzip60-cfactorstr_overflow.patch to fix buffer overflow in
+ list.c [bsc#1110194]
+
+-------------------------------------------------------------------
--- /work/SRC/openSUSE:Factory/unzip/unzip.changes 2018-07-04
23:53:28.000002333 +0200
+++ /work/SRC/openSUSE:Factory/.unzip.new/unzip.changes 2018-10-22
11:06:58.244090295 +0200
@@ -1,0 +2,6 @@
+Thu Oct 11 14:49:01 UTC 2018 - kstreit...@suse.com
+
+- Add unzip60-cfactorstr_overflow.patch to fix buffer overflow in
+ list.c [bsc#1110194] [CVE-2018-18384]
+
+-------------------------------------------------------------------
New:
----
unzip60-cfactorstr_overflow.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ unzip-rcc.spec ++++++
--- /var/tmp/diff_new_pack.fEDKWI/_old 2018-10-22 11:06:59.340089380 +0200
+++ /var/tmp/diff_new_pack.fEDKWI/_new 2018-10-22 11:06:59.344089376 +0200
@@ -59,6 +59,7 @@
Patch19: CVE-2018-1000035.patch
Patch20: Fix-CVE-2014-9636-unzip-buffer-overflow.patch
Patch21: unzip60-total_disks_zero.patch
+Patch22: unzip60-cfactorstr_overflow.patch
Requires(post): update-alternatives
Requires(postun): update-alternatives
Recommends: %{_name}-doc
@@ -104,6 +105,7 @@
%patch19 -p0
%patch20 -p1
%patch21 -p1
+%patch22 -p1
%build
export RPM_OPT_FLAGS="%{optflags} \
++++++ unzip.spec ++++++
--- /var/tmp/diff_new_pack.fEDKWI/_old 2018-10-22 11:06:59.364089360 +0200
+++ /var/tmp/diff_new_pack.fEDKWI/_new 2018-10-22 11:06:59.368089356 +0200
@@ -59,6 +59,7 @@
Patch19: CVE-2018-1000035.patch
Patch20: Fix-CVE-2014-9636-unzip-buffer-overflow.patch
Patch21: unzip60-total_disks_zero.patch
+Patch22: unzip60-cfactorstr_overflow.patch
Requires(post): update-alternatives
Requires(postun): update-alternatives
Recommends: %{_name}-doc
@@ -104,6 +105,7 @@
%patch19 -p0
%patch20 -p1
%patch21 -p1
+%patch22 -p1
%build
export RPM_OPT_FLAGS="%{optflags} \
++++++ unzip60-cfactorstr_overflow.patch ++++++
--- unzip60/list.c
+++ unzip60/list.c
@@ -97,7 +97,7 @@ int list_files(__G) /* return PK-type
{
int do_this_file=FALSE, cfactor, error, error_in_archive=PK_COOL;
#ifndef WINDLL
- char sgn, cfactorstr[10];
+ char sgn, cfactorstr[1+10+1+1]; /* <sgn><int>%NUL */
int longhdr=(uO.vflag>1);
#endif
int date_format;
@@ -389,9 +389,9 @@ int list_files(__G) /* return PK-type
}
#else /* !WINDLL */
if (cfactor == 100)
- sprintf(cfactorstr, LoadFarString(CompFactor100));
+ snprintf(cfactorstr, sizeof(cfactorstr),
LoadFarString(CompFactor100));
else
- sprintf(cfactorstr, LoadFarString(CompFactorStr), sgn,
cfactor);
+ snprintf(cfactorstr, sizeof(cfactorstr),
LoadFarString(CompFactorStr), sgn, cfactor);
if (longhdr)
Info(slide, 0, ((char *)slide, LoadFarString(LongHdrStats),
FmZofft(G.crec.ucsize, "8", "u"), methbuf,
@@ -471,9 +471,9 @@ int list_files(__G) /* return PK-type
#else /* !WINDLL */
if (cfactor == 100)
- sprintf(cfactorstr, LoadFarString(CompFactor100));
+ snprintf(cfactorstr, sizeof(cfactorstr),
LoadFarString(CompFactor100));
else
- sprintf(cfactorstr, LoadFarString(CompFactorStr), sgn, cfactor);
+ snprintf(cfactorstr, sizeof(cfactorstr),
LoadFarString(CompFactorStr), sgn, cfactor);
if (longhdr) {
Info(slide, 0, ((char *)slide, LoadFarString(LongFileTrailer),
FmZofft(tot_ucsize, "8", "u"), FmZofft(tot_csize, "8", "u"),
