Hello community,
here is the log from the commit of package yast2-isns for openSUSE:Factory
checked in at 2019-01-03 18:05:57
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-isns (Old)
and /work/SRC/openSUSE:Factory/.yast2-isns.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-isns"
Thu Jan 3 18:05:57 2019 rev:36 rq:655079 version:4.1.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-isns/yast2-isns.changes 2018-09-05
13:48:48.214282606 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-isns.new.28833/yast2-isns.changes
2019-01-03 18:05:58.516175170 +0100
@@ -1,0 +2,18 @@
+Wed Dec 5 08:36:21 UTC 2018 - jreidin...@suse.com
+
+- always use absolute path to binaries (bsc#1118291)
+- escape properly shell arguments (bsc#1118291)
+- 4.1.4
+
+-------------------------------------------------------------------
+Sun Nov 25 16:45:44 UTC 2018 - Stasiek Michalski <hel...@mailbox.org>
+
+- Provide icon with module (boo#1109310)
+- 4.1.3
+
+-------------------------------------------------------------------
+Tue Oct 16 16:42:49 CEST 2018 - sch...@suse.de
+
+- Added license file to spec.
+
+-------------------------------------------------------------------
Old:
----
yast2-isns-4.1.2.tar.bz2
New:
----
yast2-isns-4.1.4.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-isns.spec ++++++
--- /var/tmp/diff_new_pack.amRufq/_old 2019-01-03 18:05:58.888174840 +0100
+++ /var/tmp/diff_new_pack.amRufq/_new 2019-01-03 18:05:58.892174836 +0100
@@ -17,7 +17,7 @@
Name: yast2-isns
-Version: 4.1.2
+Version: 4.1.4
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -68,5 +68,7 @@
%{yast_desktopdir}/isns.desktop
%{yast_scrconfdir}/*.scr
%doc %{yast_docdir}
+%{yast_icondir}
+%license COPYING
%changelog
++++++ yast2-isns-4.1.2.tar.bz2 -> yast2-isns-4.1.4.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-isns-4.1.2/package/yast2-isns.changes
new/yast2-isns-4.1.4/package/yast2-isns.changes
--- old/yast2-isns-4.1.2/package/yast2-isns.changes 2018-08-23
17:56:10.000000000 +0200
+++ new/yast2-isns-4.1.4/package/yast2-isns.changes 2018-12-05
10:36:57.000000000 +0100
@@ -1,4 +1,22 @@
-------------------------------------------------------------------
+Wed Dec 5 08:36:21 UTC 2018 - jreidin...@suse.com
+
+- always use absolute path to binaries (bsc#1118291)
+- escape properly shell arguments (bsc#1118291)
+- 4.1.4
+
+-------------------------------------------------------------------
+Sun Nov 25 16:45:44 UTC 2018 - Stasiek Michalski <hel...@mailbox.org>
+
+- Provide icon with module (boo#1109310)
+- 4.1.3
+
+-------------------------------------------------------------------
+Tue Oct 16 16:42:49 CEST 2018 - sch...@suse.de
+
+- Added license file to spec.
+
+-------------------------------------------------------------------
Thu Aug 23 14:31:13 UTC 2018 - dgonza...@suse.com
- Update calls to YaST2 systemd classes (related to fate#319428)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-isns-4.1.2/package/yast2-isns.spec
new/yast2-isns-4.1.4/package/yast2-isns.spec
--- old/yast2-isns-4.1.2/package/yast2-isns.spec 2018-08-23
17:56:10.000000000 +0200
+++ new/yast2-isns-4.1.4/package/yast2-isns.spec 2018-12-05
10:36:57.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-isns
-Version: 4.1.2
+Version: 4.1.4
Release: 0
License: GPL-2.0-only
Group: System/YaST
@@ -65,3 +65,5 @@
%{yast_desktopdir}/isns.desktop
%{yast_scrconfdir}/*.scr
%doc %{yast_docdir}
+%{yast_icondir}
+%license COPYING
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-isns-4.1.2/src/Makefile.am
new/yast2-isns-4.1.4/src/Makefile.am
--- old/yast2-isns-4.1.2/src/Makefile.am 2018-08-23 17:56:10.000000000
+0200
+++ new/yast2-isns-4.1.4/src/Makefile.am 2018-12-05 10:36:57.000000000
+0100
@@ -23,6 +23,13 @@
desktop_DATA = \
desktop/isns.desktop
-EXTRA_DIST = $(module_DATA) $(client_DATA) $(ynclude_DATA) $(scrconf_DATA)
$(desktop_DATA)
+symbolicdir = @icondir@/hicolor/symbolic/apps
+symbolic_DATA = \
+ icons/hicolor/symbolic/apps/yast-isns-symbolic.svg
+scalabledir = @icondir@/hicolor/scalable/apps
+scalable_DATA = \
+ icons/hicolor/scalable/apps/yast-isns.svg
-include $(top_srcdir)/Makefile.am.common
\ No newline at end of file
+EXTRA_DIST = $(module_DATA) $(client_DATA) $(ynclude_DATA) $(scrconf_DATA)
$(desktop_DATA) $(symbolic_DATA) $(scalable_DATA)
+
+include $(top_srcdir)/Makefile.am.common
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-isns-4.1.2/src/desktop/isns.desktop
new/yast2-isns-4.1.4/src/desktop/isns.desktop
--- old/yast2-isns-4.1.2/src/desktop/isns.desktop 2018-08-23
17:56:10.000000000 +0200
+++ new/yast2-isns-4.1.4/src/desktop/isns.desktop 2018-12-05
10:36:57.000000000 +0100
@@ -15,7 +15,7 @@
X-SuSE-YaST-AutoInstResource=isns
X-SuSE-YaST-Keywords=internet,storage,name,network,server,devices,iscsi,scsi
-Icon=yast-iscsi-server
+Icon=yast-isns
Exec=xdg-su -c "/sbin/yast2 isns"
Name=iSNS Server
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-isns-4.1.2/src/icons/hicolor/scalable/apps/yast-isns.svg
new/yast2-isns-4.1.4/src/icons/hicolor/scalable/apps/yast-isns.svg
--- old/yast2-isns-4.1.2/src/icons/hicolor/scalable/apps/yast-isns.svg
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-isns-4.1.4/src/icons/hicolor/scalable/apps/yast-isns.svg
2018-12-05 10:36:57.000000000 +0100
@@ -0,0 +1,68 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg width="128" height="128" version="1.1" viewBox="0 0 128 128.00001"
xmlns="http://www.w3.org/2000/svg";>
+<defs>
+<linearGradient id="h" x1="10" x2="10" y1="3" y2="37"
gradientTransform="matrix(2,0,0,2,-2e-7,2)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#acaba8" offset="0"/>
+<stop stop-color="#cac9c6" offset="1"/>
+</linearGradient>
+<linearGradient id="f" x1="3" x2="29" y1="17" y2="17"
gradientTransform="matrix(4,0,0,4,0,-20)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#9a9996" offset="0"/>
+<stop stop-color="#deddda" offset=".037101"/>
+<stop stop-color="#9a9996" offset=".076507"/>
+<stop stop-color="#9a9996" offset=".92289"/>
+<stop stop-color="#deddda" offset=".96229"/>
+<stop stop-color="#9a9996" offset="1"/>
+</linearGradient>
+<linearGradient id="b" x1="13.17" x2="13" y1="21" y2="11"
gradientTransform="matrix(4,0,0,4,0,-24)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#f6f5f4" offset="0"/>
+<stop stop-color="#deddda" offset="1"/>
+</linearGradient>
+<linearGradient id="a" x1="13.17" x2="13" y1="21" y2="11"
gradientTransform="matrix(4,0,0,4,0,-12)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#f6f5f4" offset="0"/>
+<stop stop-color="#deddda" offset="1"/>
+</linearGradient>
+<linearGradient id="g" x1="10" x2="10" y1="3" y2="37"
gradientTransform="matrix(2,0,0,2,-4e-7,14)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#acaba8" offset="0"/>
+<stop stop-color="#cac9c6" offset="1"/>
+</linearGradient>
+<linearGradient id="c" x1="3" x2="29" y1="17" y2="17"
gradientTransform="matrix(4,0,0,4,0,-8)" gradientUnits="userSpaceOnUse">
+<stop stop-color="#9a9996" offset="0"/>
+<stop stop-color="#deddda" offset=".037101"/>
+<stop stop-color="#9a9996" offset=".076507"/>
+<stop stop-color="#9a9996" offset=".92289"/>
+<stop stop-color="#deddda" offset=".96229"/>
+<stop stop-color="#9a9996" offset="1"/>
+</linearGradient>
+</defs>
+<rect x="12" y="32" width="104" height="68" ry="8" stroke-width="4"/>
+<rect x="12" y="24" width="104" height="68" ry="8" fill="url(#c)"
stroke-width="4"/>
+<rect x="12" y="20" width="104" height="68" ry="8" fill="url(#g)"
stroke-width="4"/>
+<rect x="108" y="80" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="108" y="24" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="52" y="24" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="20" y="24" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="20" y="80" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="52" y="80" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<path d="m32 28a4.0004 4.0004 0 0 0 -4 4c0 2.2565-1.7435 4-4 4a4.0004 4.0004 0
0 0 -4 4v32a4.0004 4.0004 0 0 0 4 4c2.2565 0 4 1.7435 4 4a4.0004 4.0004 0 0 0 4
4h12a4.0004 4.0004 0 0 0 4 -4c0-2.2538 1.7396-3.9959 3.9922-4 0.0426 0.0014
0.08632 0.0052 0.125 8e-3a4.0004 4.0004 0 0 0 0.56248 -8e-3h6.5624c5.1432
4.8128 11.847 7.9952 18.898 8 7.3304 0 14.614-3.0198
19.797-8.2032s8.2032-12.466
8.2032-19.797-3.0198-14.614-8.2032-19.797c-5.1832-5.1832-12.466-8.2032-19.797-8.2032a4.0004
4.0004 0 0 0 -8e-3 0c-7.0416 0.0104-13.73 3.1955-18.867 8h-7.2656c-2.2565
0-4-1.7435-4-4a4.0004 4.0004 0 0 0 -4 -4z" fill="#acaba8" stroke-width="4"/>
+<path d="m32 24a4.0004 4.0004 0 0 0 -4 4c0 2.2565-1.7435 4-4 4a4.0004 4.0004 0
0 0 -4 4v32a4.0004 4.0004 0 0 0 4 4c2.2565 0 4 1.7435 4 4a4.0004 4.0004 0 0 0 4
4h12a4.0004 4.0004 0 0 0 4 -4c0-2.2538 1.7396-3.9959 3.9922-4 0.0426 0.0014
0.08632 0.0052 0.125 8e-3a4.0004 4.0004 0 0 0 0.56248 -8e-3h6.5624c5.1432
4.8128 11.847 7.9952 18.898 8 7.3304 0 14.614-3.0198
19.797-8.2032s8.2032-12.466
8.2032-19.797-3.0198-14.614-8.2032-19.797c-5.1832-5.1832-12.466-8.2032-19.797-8.2032a4.0004
4.0004 0 0 0 -8e-3 0c-7.0416 0.0104-13.73 3.1955-18.867 8h-7.2656c-2.2565
0-4-1.7435-4-4a4.0004 4.0004 0 0 0 -4 -4z" fill="url(#a)" stroke-width="4"/>
+<rect x="72" y="40" width="16" height="16" ry="8" fill="#adaba7"
fill-opacity=".9959" stroke-width="4"/>
+<rect x="72" y="44" width="16" height="16" ry="8" fill="#cac9c6"
fill-opacity=".9959" stroke-width="4"/>
+<rect x="12" y="20" width="104" height="68" ry="8" stroke-width="4"/>
+<rect x="12" y="12" width="104" height="68" ry="8" fill="url(#f)"
stroke-width="4"/>
+<rect x="12" y="8" width="104" height="68" ry="8" fill="url(#h)"
stroke-width="4"/>
+<rect x="108" y="68" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="108" y="12" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="52" y="12" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="20" y="12" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="20" y="68" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<rect x="52" y="68" width="4" height="4" ry="2" fill="#77767b"
stroke-width="4"/>
+<path d="m32 16a4.0004 4.0004 0 0 0 -4 4c0 2.2565-1.7435 4-4 4a4.0004 4.0004 0
0 0 -4 4v32a4.0004 4.0004 0 0 0 4 4c2.2565 0 4 1.7435 4 4a4.0004 4.0004 0 0 0 4
4h12a4.0004 4.0004 0 0 0 4 -4c0-2.2538 1.7396-3.9959 3.9922-4 0.0426 0.0014
0.08632 0.0052 0.125 8e-3a4.0004 4.0004 0 0 0 0.56248 -8e-3h6.5624c5.1432
4.8128 11.847 7.9952 18.898 8 7.3304 0 14.614-3.0198
19.797-8.2032s8.2032-12.466
8.2032-19.797-3.0198-14.614-8.2032-19.797c-5.1832-5.1832-12.466-8.2032-19.797-8.2032a4.0004
4.0004 0 0 0 -8e-3 0c-7.0416 0.0106-13.73 3.1955-18.867 8h-7.2656c-2.2565
0-4-1.7435-4-4a4.0004 4.0004 0 0 0 -4 -4z" fill="#acaba8" stroke-width="4"/>
+<path d="m32 12a4.0004 4.0004 0 0 0 -4 4c0 2.2565-1.7435 4-4 4a4.0004 4.0004 0
0 0 -4 4v32a4.0004 4.0004 0 0 0 4 4c2.2565 0 4 1.7435 4 4a4.0004 4.0004 0 0 0 4
4h12a4.0004 4.0004 0 0 0 4 -4c0-2.2538 1.7396-3.9959 3.9922-4 0.0426 0.0014
0.08632 0.0052 0.125 8e-3a4.0004 4.0004 0 0 0 0.56248 -8e-3h6.5624c5.1432
4.8128 11.847 7.9952 18.898 8 7.3304 0 14.614-3.0198
19.797-8.2032s8.2032-12.466
8.2032-19.797-3.0198-14.614-8.2032-19.797c-5.1832-5.1832-12.466-8.2032-19.797-8.2032a4.0004
4.0004 0 0 0 -8e-3 0c-7.0416 0.0106-13.73 3.1955-18.867 8h-7.2656c-2.2565
0-4-1.7435-4-4a4.0004 4.0004 0 0 0 -4 -4z" fill="url(#b)" stroke-width="4"/>
+<rect x="72" y="28" width="16" height="16" ry="8" fill="#adaba7"
fill-opacity=".9959" stroke-width="4"/>
+<rect x="72" y="32" width="16" height="16" ry="8" fill="#cac9c6"
fill-opacity=".9959" stroke-width="4"/>
+<rect x="48" y="108" width="32" height="12" ry="4" fill="#613583"
stroke-width="4"/>
+<rect x="16" y="112" width="96" height="4" ry="0" fill="#613583"
stroke-width="4"/>
+<rect x="60" y="96" width="8" height="12" fill="#a347ba" stroke-width="4"/>
+<rect x="48" y="104" width="32" height="12" ry="4" fill="#a347ba"
stroke-width="4"/>
+<rect x="16" y="108" width="96" height="4" ry="0" fill="#a347ba"
stroke-width="4"/>
+</svg>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-isns-4.1.2/src/icons/hicolor/symbolic/apps/yast-isns-symbolic.svg
new/yast2-isns-4.1.4/src/icons/hicolor/symbolic/apps/yast-isns-symbolic.svg
--- old/yast2-isns-4.1.2/src/icons/hicolor/symbolic/apps/yast-isns-symbolic.svg
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-isns-4.1.4/src/icons/hicolor/symbolic/apps/yast-isns-symbolic.svg
2018-12-05 10:36:57.000000000 +0100
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg"; width="16" height="16">
+ <path d="M 5 0 C 4.446 0 4 0.446 4 1 L 4 2 L 3 2 C 2.446 2 2 2.446 2 3 L 2
13 C 2 13.554 2.4461129 13.988814 3 14 L 8 14 L 8 15 L 3 15 L 3 16 L 10 16 L 10
15 L 10 14 L 10 13 L 3 13 L 3 3 L 4 3 L 4 11 C 4 11.554 4.446 12 5 12 L 10 12 L
10 10 L 14 10 L 14 1 C 14 0.446 13.554 0 13 0 L 5 0 z M 9 1 C 11.216 1 13 2.784
13 5 C 13 7.216 11.216 9 9 9 L 5 9 L 5 5 C 5 2.784 6.784 1 9 1 z M 9 3 C 7.892
3 7 3.892 7 5 C 7 6.108 7.892 7 9 7 C 10.108 7 11 6.108 11 5 C 11 3.892 10.108
3 9 3 z M 11 11 L 11 16 L 16 16 L 16 11 L 11 11 z M 12 12 L 13 12 L 13 13 L 14
13 L 14 12 L 15 12 L 15 14 L 14 14 L 14 15 L 13 15 L 13 14 L 12 14 L 12 12 z "
fill="#c0bfbc" />
+</svg>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-isns-4.1.2/src/modules/IsnsServer.rb
new/yast2-isns-4.1.4/src/modules/IsnsServer.rb
--- old/yast2-isns-4.1.2/src/modules/IsnsServer.rb 2018-08-23
17:56:10.000000000 +0200
+++ new/yast2-isns-4.1.4/src/modules/IsnsServer.rb 2018-12-05
10:36:57.000000000 +0100
@@ -13,6 +13,7 @@
require "yast2/system_service"
require "y2firewall/firewalld"
require "yast2/systemd/socket"
+require "shellwords"
module Yast
class IsnsServerClass < Module
@@ -254,27 +255,27 @@
def addDDMember(dd_id, iqn)
y2milestone("addDDMember #{iqn} to #{dd_id}")
- isnsadm("--dd-register dd-id=#{dd_id} dd-member-name=#{iqn}")
+ isnsadm("--dd-register dd-id=#{dd_id.shellescape}
dd-member-name=#{iqn.shellescape}")
end
def addDD(iqn)
y2milestone("addDD #{iqn}")
- isnsadm("--dd-register dd-name=#{iqn}")
+ isnsadm("--dd-register dd-name=#{iqn.shellescape}")
end
def deleteISCSI(id)
y2milestone("deleteISCSI: #{id}")
- isnsadm("--deregister iscsi-name=#{id}")
+ isnsadm("--deregister iscsi-name=#{id.shellescape}")
end
def deleteDDMember(dd_id, iqn)
y2milestone("deleteDDMember #{iqn} from #{dd_id}")
- isnsadm("--dd-deregister #{dd_id} dd-member-name=#{iqn}")
+ isnsadm("--dd-deregister #{dd_id.shellescape}
dd-member-name=#{iqn.shellescape}")
end
def deleteDD(id)
y2milestone("deleteDD: #{id}")
- isnsadm("--dd-deregister #{id}")
+ isnsadm("--dd-deregister #{id.shellescape}")
end
# Read all iscsi-server settings
@@ -363,7 +364,8 @@
private
def isnsadm(params, ret_result = false)
- command = "isnsadm --local #{params}"
+ # cannot shellescape here as more params can be passed
+ command = "/usr/sbin/isnsadm --local #{params}"
y2debug("Executing #{command}")
res = SCR.Execute(path(".target.bash_output"), command, {})
@@ -392,7 +394,7 @@
y2error("We aren't control node. Only default DD shown.")
end
- stdout = isnsadm("--query #{query}", true)["stdout"]
+ stdout = isnsadm("--query #{query.shellescape}", true)["stdout"]
parse_obj(stdout)
end
@@ -402,7 +404,7 @@
y2error("We aren't control node. Only default DD shown.")
end
- objects = isnsadm("--list #{type}", true)["stdout"].split(/Object
\d+:\n/)
+ objects = isnsadm("--list #{type.shellescape}",
true)["stdout"].split(/Object \d+:\n/)
temp = []
objects.each do |obj|
