Hello community, here is the log from the commit of package gthumb for openSUSE:Factory checked in at 2019-01-10 15:23:37 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gthumb (Old) and /work/SRC/openSUSE:Factory/.gthumb.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gthumb" Thu Jan 10 15:23:37 2019 rev:90 rq:664157 version:3.6.2 Changes: -------- --- /work/SRC/openSUSE:Factory/gthumb/gthumb.changes 2018-10-11 11:50:36.390393292 +0200 +++ /work/SRC/openSUSE:Factory/.gthumb.new.28833/gthumb.changes 2019-01-10 15:23:39.402310868 +0100 @@ -1,0 +2,6 @@ +Wed Dec 19 16:35:36 UTC 2018 - Dan Čermák <dcer...@suse.com> + +- Add fix_double_free_dlg-contact-sheet_c.patch: + fix for bsc#1113749 / CVE-2018-18718 + +------------------------------------------------------------------- New: ---- fix_double_free_dlg-contact-sheet_c.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gthumb.spec ++++++ --- /var/tmp/diff_new_pack.bCKvty/_old 2019-01-10 15:23:39.838310417 +0100 +++ /var/tmp/diff_new_pack.bCKvty/_new 2019-01-10 15:23:39.838310417 +0100 @@ -25,6 +25,8 @@ Group: Productivity/Graphics/Viewers URL: https://wiki.gnome.org/Apps/gthumb Source0: https://download.gnome.org/sources/gthumb/3.6/%{name}-%{version}.tar.xz +# PATCH-FIX-UPSTREAM fix_double_free_dlg-contact-sheet_c.patch bsc#1113749 +Patch0: fix_double_free_dlg-contact-sheet_c.patch BuildRequires: bison BuildRequires: fdupes BuildRequires: flex @@ -86,7 +88,7 @@ %lang_package %prep -%setup -q +%autosetup -p1 translation-update-upstream %build ++++++ fix_double_free_dlg-contact-sheet_c.patch ++++++ diff --git a/extensions/contact_sheet/dlg-contact-sheet.c b/extensions/contact_sheet/dlg-contact-sheet.c index 0297e0db..9b38e16d 100644 --- a/extensions/contact_sheet/dlg-contact-sheet.c +++ b/extensions/contact_sheet/dlg-contact-sheet.c @@ -350,10 +350,7 @@ add_themes_from_dir (DialogData *data, key_file = g_key_file_new (); if (! g_key_file_load_from_data (key_file, buffer, size, G_KEY_FILE_NONE, NULL)) { - g_key_file_free (key_file); - g_free (buffer); - g_object_unref (file); - g_object_unref (file_info); + goto cleanup; } theme = gth_contact_sheet_theme_new_from_key_file (key_file); @@ -369,6 +366,7 @@ add_themes_from_dir (DialogData *data, -1); _g_object_unref (preview); + cleanup: g_key_file_free (key_file); g_free (buffer); g_object_unref (file);
