Hello community,

here is the log from the commit of package kfilemetadata5 for openSUSE:Factory 
checked in at 2019-02-14 14:30:07
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kfilemetadata5 (Old)
 and      /work/SRC/openSUSE:Factory/.kfilemetadata5.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "kfilemetadata5"

Thu Feb 14 14:30:07 2019 rev:68 rq:674333 version:5.55.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/kfilemetadata5/kfilemetadata5.changes    
2019-01-21 10:19:55.882100556 +0100
+++ /work/SRC/openSUSE:Factory/.kfilemetadata5.new.28833/kfilemetadata5.changes 
2019-02-14 14:30:15.287737950 +0100
@@ -1,0 +2,22 @@
+Tue Feb 12 07:03:30 UTC 2019 - wba...@tmo.at
+
+- Add fix-build-with-cmake-3.5.patch to fix build with cmake 3.5.2
+  on Leap 42.3
+
+-------------------------------------------------------------------
+Sun Feb 10 22:03:07 UTC 2019 - lbeltr...@kde.org
+
+- Update to 5.55.0
+  * New feature release
+  * For more details please see:
+  * https://www.kde.org/announcements/kde-frameworks-5.55.0.php
+- Changes since 5.54.0:
+  * harmonize testing data
+  * exiv2extractor: add support for bmp, gif, webp, tga
+  * Fix failing test of exiv gps data
+  * Test empty and zero gps data
+  * Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
+  * Use more https in links
+  * add support for more mimetypes to taglibwriter
+
+-------------------------------------------------------------------

Old:
----
  kfilemetadata-5.54.0.tar.xz

New:
----
  fix-build-with-cmake-3.5.patch
  kfilemetadata-5.55.0.tar.xz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ kfilemetadata5.spec ++++++
--- /var/tmp/diff_new_pack.R3ezXx/_old  2019-02-14 14:30:15.887737673 +0100
+++ /var/tmp/diff_new_pack.R3ezXx/_new  2019-02-14 14:30:15.891737671 +0100
@@ -16,7 +16,7 @@
 #
 
 
-%define _tar_path 5.54
+%define _tar_path 5.55
 # Full KF5 version (e.g. 5.33.0)
 %{!?_kf5_version: %global _kf5_version %{version}}
 # Last major and minor KF5 version (e.g. 5.33)
@@ -24,7 +24,7 @@
 %bcond_without ffmpeg
 %bcond_without lang
 Name:           kfilemetadata5
-Version:        5.54.0
+Version:        5.55.0
 Release:        0
 Summary:        Library for extracting Metadata
 License:        GPL-2.0-or-later AND LGPL-2.1-or-later AND LGPL-3.0-only
@@ -32,6 +32,8 @@
 URL:            https://www.kde.org
 Source:         
http://download.kde.org/stable/frameworks/%{_tar_path}/kfilemetadata-%{version}.tar.xz
 Source1:        baselibs.conf
+# PATCH-FIX-UPSTREAM
+Patch0:         fix-build-with-cmake-3.5.patch
 BuildRequires:  extra-cmake-modules >= %{_kf5_bugfix_version}
 BuildRequires:  karchive-devel >= %{_kf5_bugfix_version}
 BuildRequires:  kf5-filesystem
@@ -69,6 +71,7 @@
 
 %prep
 %setup -q -n kfilemetadata-%{version}
+%autopatch -p1
 
 %build
   %cmake_kf5 -d build -- -DCMAKE_INSTALL_LOCALEDIR=%{_kf5_localedir}

++++++ fix-build-with-cmake-3.5.patch ++++++
>From 1632a6972279d150aeb8de9e1cf0000ba1c3c380 Mon Sep 17 00:00:00 2001
From: Wolfgang Bauer <wba...@tmo.at>
Date: Tue, 12 Feb 2019 10:31:01 +0100
Subject: Fix build with cmake 3.5

VERSION_GREATER_EQUAL requires cmake 3.7 or higher.
So use NOT VERSION_LESS instead, which is logically equivalent and also
works with older cmake versions.
Differential Revision: https://phabricator.kde.org/D18941
---
 src/extractors/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/extractors/CMakeLists.txt b/src/extractors/CMakeLists.txt
index 8795b48..6b4859c 100644
--- a/src/extractors/CMakeLists.txt
+++ b/src/extractors/CMakeLists.txt
@@ -36,7 +36,7 @@ if(LibExiv2_FOUND)
         KF5::FileMetaData
         LibExiv2::LibExiv2
     )
-    if(${LibExiv2_VERSION} VERSION_GREATER_EQUAL 0.26)
+    if(NOT ${LibExiv2_VERSION} VERSION_LESS 0.26)
         target_compile_definitions(kfilemetadata_exiv2extractor PRIVATE 
"-DHAVE_WEBP_SUPPORT")
     endif()
 
-- 
cgit v1.1

++++++ kfilemetadata-5.54.0.tar.xz -> kfilemetadata-5.55.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/CMakeLists.txt 
new/kfilemetadata-5.55.0/CMakeLists.txt
--- old/kfilemetadata-5.54.0/CMakeLists.txt     2019-01-06 21:21:52.000000000 
+0100
+++ new/kfilemetadata-5.55.0/CMakeLists.txt     2019-02-03 00:56:53.000000000 
+0100
@@ -1,15 +1,15 @@
 cmake_minimum_required(VERSION 3.5)
 
-set(KF5_VERSION "5.54.0") # handled by release scripts
-set(KF5_DEP_VERSION "5.54.0") # handled by release scripts
+set(KF5_VERSION "5.55.0") # handled by release scripts
+set(KF5_DEP_VERSION "5.55.0") # handled by release scripts
 project(KFileMetaData VERSION ${KF5_VERSION})
 
 include(FeatureSummary)
-find_package(ECM 5.54.0  NO_MODULE)
+find_package(ECM 5.55.0  NO_MODULE)
 set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake 
Modules." URL 
"https://projects.kde.org/projects/kdesupport/extra-cmake-modules";)
 feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND 
FATAL_ON_MISSING_REQUIRED_PACKAGES)
 
-set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake" ${ECM_MODULE_PATH} 
${ECM_KDE_MODULE_DIR})
+set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake" ${ECM_MODULE_PATH})
 
 include(KDEInstallDirs)
 include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
@@ -31,7 +31,7 @@
                   SOVERSION 3)
 
 # Dependencies
-set(REQUIRED_QT_VERSION 5.9.0)
+set(REQUIRED_QT_VERSION 5.10.0)
 
 find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE COMPONENTS Xml)
 
@@ -44,12 +44,12 @@
 
 find_package(Poppler 0.12.1 COMPONENTS Qt5)
 set_package_properties(Poppler PROPERTIES DESCRIPTION "A PDF rendering library"
-                       URL "http://poppler.freedesktop.org"; TYPE OPTIONAL
+                       URL "https://poppler.freedesktop.org/"; TYPE OPTIONAL
                        PURPOSE "Support for PDF files")
 
 find_package(Taglib 1.11.1)
 set_package_properties(Taglib PROPERTIES DESCRIPTION "Id3 tag reader"
-                       URL "http://developer.kde.org/~wheeler/taglib.html"; 
TYPE OPTIONAL
+                       URL "https://taglib.org/"; TYPE OPTIONAL
                        PURPOSE "Support for music metadata")
 
 find_package(LibExiv2 0.21)
@@ -61,7 +61,7 @@
 find_package(FFmpeg 57.40 COMPONENTS AVFORMAT)
 find_package(FFmpeg 55.27 COMPONENTS AVUTIL)
 set_package_properties(FFmpeg PROPERTIES DESCRIPTION "Video Tag reader"
-                       URL "http://ffmpeg.org"; TYPE OPTIONAL
+                       URL "https://ffmpeg.org/"; TYPE OPTIONAL
                        PURPOSE "Support for video metadata")
 
 if (FFmpeg_AVFORMAT_FOUND)
@@ -71,18 +71,18 @@
 
 find_package(EPub)
 set_package_properties(EPub PROPERTIES DESCRIPTION "Ebook epub reader"
-                       URL "http://sourceforge.net/projects/ebook-tools"; TYPE 
OPTIONAL
+                       URL "https://sourceforge.net/projects/ebook-tools/"; 
TYPE OPTIONAL
                        PURPOSE "Support for epub metadata")
 
 find_package(CatDoc)
 set_package_properties(CatDoc PROPERTIES DESCRIPTION "catdoc executable"
-                       URL "http://www.wagner.pp.ru/~vitus/software/catdoc/"; 
TYPE RUNTIME
+                       URL "https://www.wagner.pp.ru/~vitus/software/catdoc/"; 
TYPE RUNTIME
                        PURPOSE "Extract text from office 98 files - RUNTIME 
dependency")
 
 if ( CMAKE_SYSTEM_NAME MATCHES "Linux" )
     find_package(Xattr)
     set_package_properties(Xattr PROPERTIES DESCRIPTION "library libattr "
-        URL "http://savannah.nongnu.org/projects/attr";
+        URL "https://savannah.nongnu.org/projects/attr";
         TYPE REQUIRED
         PURPOSE "Extended attribute shared library")
 endif()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kfilemetadata-5.54.0/autotests/exiv2extractortest.cpp 
new/kfilemetadata-5.55.0/autotests/exiv2extractortest.cpp
--- old/kfilemetadata-5.54.0/autotests/exiv2extractortest.cpp   2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/autotests/exiv2extractortest.cpp   2019-02-03 
00:56:53.000000000 +0100
@@ -28,6 +28,7 @@
 #include <QDir>
 
 using namespace KFileMetaData;
+using namespace KFileMetaData::Property;
 
 QString Exiv2ExtractorTest::testFilePath(const QString& fileName) const
 {
@@ -44,15 +45,37 @@
     QCOMPARE(result.types().size(), 1);
     QCOMPARE(result.types().constFirst(), Type::Image);
 
-    using namespace KFileMetaData::Property;
-
-    QCOMPARE(result.properties().value(PhotoGpsLatitude).toDouble(), 41.411);
-    QCOMPARE(result.properties().value(PhotoGpsLongitude).toDouble(), 2.173);
-    QVERIFY(qAbs(result.properties().value(PhotoGpsAltitude).toDouble() - 
12.2) <  0.0001);
     QCOMPARE(result.properties().value(Artist).toString(), 
QStringLiteral("Artist"));
     QCOMPARE(result.properties().value(Description).toString(), 
QStringLiteral("Description"));
     QCOMPARE(result.properties().value(Copyright).toString(), 
QStringLiteral("Copyright"));
     QCOMPARE(result.properties().value(Generator).toString(), 
QStringLiteral("digiKam-5.9.0"));
 }
 
+void Exiv2ExtractorTest::testGPS()
+{
+    Exiv2Extractor plugin{this};
+
+    SimpleExtractionResult result(testFilePath("test.jpg"), "image/jpeg");
+    plugin.extract(&result);
+
+    QCOMPARE(result.properties().value(PhotoGpsLatitude).toDouble(), 41.411);
+    QCOMPARE(result.properties().value(PhotoGpsLongitude).toDouble(), 2.173);
+    QCOMPARE(result.properties().value(PhotoGpsAltitude).toDouble(), 12.2);
+
+    SimpleExtractionResult resultEmpty(testFilePath("test_no_gps.jpg"), 
"image/jpeg");
+    plugin.extract(&resultEmpty);
+    QVERIFY(!resultEmpty.properties().contains(PhotoGpsLatitude));
+    QVERIFY(!resultEmpty.properties().contains(PhotoGpsLongitude));
+    QVERIFY(!resultEmpty.properties().contains(PhotoGpsAltitude));
+
+    SimpleExtractionResult resultZero(testFilePath("test_zero_gps.jpg"), 
"image/jpeg");
+    plugin.extract(&resultZero);
+    QVERIFY(resultZero.properties().contains(PhotoGpsLatitude));
+    QVERIFY(resultZero.properties().contains(PhotoGpsLongitude));
+    QVERIFY(resultZero.properties().contains(PhotoGpsAltitude));
+    QCOMPARE(resultZero.properties().value(PhotoGpsLatitude).toDouble(), 0.0);
+    QCOMPARE(resultZero.properties().value(PhotoGpsLongitude).toDouble(), 0.0);
+    QCOMPARE(resultZero.properties().value(PhotoGpsAltitude).toDouble(), 0.0);
+}
+
 QTEST_GUILESS_MAIN(Exiv2ExtractorTest)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/autotests/exiv2extractortest.h 
new/kfilemetadata-5.55.0/autotests/exiv2extractortest.h
--- old/kfilemetadata-5.54.0/autotests/exiv2extractortest.h     2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/autotests/exiv2extractortest.h     2019-02-03 
00:56:53.000000000 +0100
@@ -31,6 +31,7 @@
 
 private Q_SLOTS:
     void test();
+    void testGPS();
 };
 
 #endif // EXIV2EXTRACTORTEST_H
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test.flac and 
new/kfilemetadata-5.55.0/autotests/samplefiles/test.flac differ
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test.ogg and 
new/kfilemetadata-5.55.0/autotests/samplefiles/test.ogg differ
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test.opus and 
new/kfilemetadata-5.55.0/autotests/samplefiles/test.opus differ
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test.spx and 
new/kfilemetadata-5.55.0/autotests/samplefiles/test.spx differ
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test_no_gps.jpg and 
new/kfilemetadata-5.55.0/autotests/samplefiles/test_no_gps.jpg differ
Binary files old/kfilemetadata-5.54.0/autotests/samplefiles/test_zero_gps.jpg 
and new/kfilemetadata-5.55.0/autotests/samplefiles/test_zero_gps.jpg differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/autotests/taglibwritertest.cpp 
new/kfilemetadata-5.55.0/autotests/taglibwritertest.cpp
--- old/kfilemetadata-5.54.0/autotests/taglibwritertest.cpp     2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/autotests/taglibwritertest.cpp     2019-02-03 
00:56:53.000000000 +0100
@@ -95,6 +95,30 @@
     QTest::addColumn<QString>("stringSuffix");
 
 
+    QTest::addRow("aiff")
+        << QStringLiteral("aif")
+        << QStringLiteral("audio/x-aiff")
+        << QString()
+        ;
+
+    QTest::addRow("aiff_unicode")
+        << QStringLiteral("aif")
+        << QStringLiteral("audio/x-aiff")
+        << unicodeTestStringSuffix
+        ;
+
+    QTest::addRow("ape")
+        << QStringLiteral("ape")
+        << QStringLiteral("audio/x-ape")
+        << QString()
+        ;
+
+    QTest::addRow("ape_unicode")
+        << QStringLiteral("ape")
+        << QStringLiteral("audio/x-ape")
+        << unicodeTestStringSuffix
+        ;
+
     QTest::addRow("flac")
         << QStringLiteral("flac")
         << QStringLiteral("audio/flac")
@@ -166,6 +190,54 @@
         << QStringLiteral("audio/opus")
         << unicodeTestStringSuffix
         ;
+
+    QTest::addRow("speex")
+        << QStringLiteral("spx")
+        << QStringLiteral("audio/speex")
+        << QString()
+        ;
+
+    QTest::addRow("speex_unicode")
+        << QStringLiteral("spx")
+        << QStringLiteral("audio/speex")
+        << unicodeTestStringSuffix
+        ;
+
+    QTest::addRow("wav")
+        << QStringLiteral("wav")
+        << QStringLiteral("audio/wav")
+        << QString()
+        ;
+
+    QTest::addRow("wav_unicode")
+        << QStringLiteral("wav")
+        << QStringLiteral("audio/wav")
+        << unicodeTestStringSuffix
+        ;
+
+    QTest::addRow("wavpack")
+        << QStringLiteral("wv")
+        << QStringLiteral("audio/x-wavpack")
+        << QString()
+        ;
+
+    QTest::addRow("wavpack_unicode")
+        << QStringLiteral("wv")
+        << QStringLiteral("audio/x-wavpack")
+        << unicodeTestStringSuffix
+        ;
+
+    QTest::addRow("wma")
+        << QStringLiteral("wma")
+        << QStringLiteral("audio/x-ms-wma")
+        << QString()
+        ;
+
+    QTest::addRow("wma_unicode")
+        << QStringLiteral("wma")
+        << QStringLiteral("audio/x-ms-wma")
+        << unicodeTestStringSuffix
+        ;
 }
 
 QTEST_GUILESS_MAIN(TagLibWriterTest)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/po/fr/kfilemetadata5.po 
new/kfilemetadata-5.55.0/po/fr/kfilemetadata5.po
--- old/kfilemetadata-5.54.0/po/fr/kfilemetadata5.po    2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/po/fr/kfilemetadata5.po    2019-02-03 
00:56:53.000000000 +0100
@@ -2,14 +2,14 @@
 # This file is distributed under the same license as the PACKAGE package.
 # Vincent PINON <vpi...@kde.org>, 2014, 2016, 2017.
 # Sebastien Renard <ren...@kde.org>, 2014, 2015.
-# Simon Depiets <sdepi...@gmail.com>, 2017, 2018.
+# Simon Depiets <sdepi...@gmail.com>, 2017, 2018, 2019.
 #
 msgid ""
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: http://bugs.kde.org\n";
 "POT-Creation-Date: 2018-11-17 03:48+0100\n"
-"PO-Revision-Date: 2018-09-21 15:06+0800\n"
+"PO-Revision-Date: 2019-01-22 12:22+0800\n"
 "Last-Translator: Simon Depiets <sdepi...@gmail.com>\n"
 "Language-Team: French <kde-francoph...@kde.org>\n"
 "Language: fr\n"
@@ -467,9 +467,7 @@
 msgstr "Modèle de création"
 
 #: src/propertyinfo.cpp:517
-#, fuzzy, kde-format
-#| msgctxt "@label the URL a file was originally downloded from"
-#| msgid "Downloaded From"
+#, kde-format
 msgctxt "@label the URL a file was originally downloaded from"
 msgid "Downloaded From"
 msgstr "Téléchargé depuis"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/po/zh_CN/kfilemetadata5.po 
new/kfilemetadata-5.55.0/po/zh_CN/kfilemetadata5.po
--- old/kfilemetadata-5.54.0/po/zh_CN/kfilemetadata5.po 2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/po/zh_CN/kfilemetadata5.po 2019-02-03 
00:56:53.000000000 +0100
@@ -10,7 +10,7 @@
 "Project-Id-Version: kdeorg\n"
 "Report-Msgid-Bugs-To: http://bugs.kde.org\n";
 "POT-Creation-Date: 2018-11-17 03:48+0100\n"
-"PO-Revision-Date: 2019-01-05 20:42\n"
+"PO-Revision-Date: 2019-01-27 22:57\n"
 "Last-Translator: guoyunhe <i...@guoyunhe.me>\n"
 "Language-Team: Chinese Simplified\n"
 "Language: zh_CN\n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/src/extractors/CMakeLists.txt 
new/kfilemetadata-5.55.0/src/extractors/CMakeLists.txt
--- old/kfilemetadata-5.54.0/src/extractors/CMakeLists.txt      2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/src/extractors/CMakeLists.txt      2019-02-03 
00:56:53.000000000 +0100
@@ -36,6 +36,9 @@
         KF5::FileMetaData
         LibExiv2::LibExiv2
     )
+    if(${LibExiv2_VERSION} VERSION_GREATER_EQUAL 0.26)
+        target_compile_definitions(kfilemetadata_exiv2extractor PRIVATE 
"-DHAVE_WEBP_SUPPORT")
+    endif()
 
     set_target_properties(kfilemetadata_exiv2extractor PROPERTIES 
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kfilemetadata")
     install(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kfilemetadata-5.54.0/src/extractors/exiv2extractor.cpp 
new/kfilemetadata-5.55.0/src/extractors/exiv2extractor.cpp
--- old/kfilemetadata-5.54.0/src/extractors/exiv2extractor.cpp  2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/src/extractors/exiv2extractor.cpp  2019-02-03 
00:56:53.000000000 +0100
@@ -19,6 +19,7 @@
 
 
 #include "exiv2extractor.h"
+#include <cmath>
 #include <QDebug>
 
 using namespace KFileMetaData;
@@ -32,11 +33,16 @@
 namespace
 {
 static const QStringList supportedMimeTypes = {
+    QStringLiteral("image/bmp"),
+    QStringLiteral("image/gif"),
     QStringLiteral("image/jp2"),
     QStringLiteral("image/jpeg"),
     QStringLiteral("image/pgf"),
     QStringLiteral("image/png"),
     QStringLiteral("image/tiff"),
+#ifdef HAVE_WEBP_SUPPORT
+    QStringLiteral("image/webp"),
+#endif
     QStringLiteral("image/x-exv"),
     QStringLiteral("image/x-canon-cr2"),
     QStringLiteral("image/x-canon-crw"),
@@ -48,6 +54,7 @@
     QStringLiteral("image/x-pentax-pef"),
     QStringLiteral("image/x-photoshop"),
     QStringLiteral("image/x-samsung-srw"),
+    QStringLiteral("image/x-tga"),
 };
 
 QString toString(const Exiv2::Value& value)
@@ -210,15 +217,15 @@
     if (!longRef.isEmpty() && longRef[0] == 'W')
         longitude *= -1;
 
-    if (latitude != 0.0) {
+    if (!std::isnan(latitude)) {
         result->add(Property::PhotoGpsLatitude, latitude);
     }
 
-    if (longitude != 0.0) {
+    if (!std::isnan(longitude)) {
         result->add(Property::PhotoGpsLongitude, longitude);
     }
 
-    if (altitude != 0.0) {
+    if (!std::isnan(altitude)) {
         result->add(Property::PhotoGpsAltitude, altitude);
     }
 }
@@ -246,7 +253,7 @@
         d = (*it).toRational(0).second;
 
         if (d == 0.0) {
-            return 0.0;
+            return std::numeric_limits<double>::quiet_NaN();
         }
 
         double deg = n / d;
@@ -278,20 +285,22 @@
         return deg;
     }
 
-    return 0.0;
+    return std::numeric_limits<double>::quiet_NaN();
 }
 
 double Exiv2Extractor::fetchGpsAltitude(const Exiv2::ExifData& data)
 {
-    double alt = 0.0;
+    double alt = std::numeric_limits<double>::quiet_NaN();
     Exiv2::ExifData::const_iterator it = 
data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitude"));
     if (it != data.end()) {
-        alt = it->value().toFloat();
+        auto ratio = it->value().toRational();
         it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));
-        if (it != data.end()) {
+        if ((ratio.second != 0) && (it != data.end())) {
             auto altRef = it->value().toLong();
             if (altRef) {
-                alt = alt * -1;
+                alt = -1.0 * ratio.first / ratio.second;
+            } else {
+                alt = 1.0 * ratio.first / ratio.second;
             }
         }
     }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kfilemetadata-5.54.0/src/extractors/taglibextractor.cpp 
new/kfilemetadata-5.55.0/src/extractors/taglibextractor.cpp
--- old/kfilemetadata-5.54.0/src/extractors/taglibextractor.cpp 2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/src/extractors/taglibextractor.cpp 2019-02-03 
00:56:53.000000000 +0100
@@ -1076,7 +1076,7 @@
 
 // TAG information (incomplete).
 // https://xiph.org/vorbis/doc/v-comment.html
-// http://help.mp3tag.de/main_tags.html
+// https://help.mp3tag.de/main_tags.html
 // http://id3.org/
 // 
https://www.legroom.net/2009/05/09/ogg-vorbis-and-flac-comment-field-recommendations
 // https://kodi.wiki/view/Music_tagging#Tags_Kodi_reads
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kfilemetadata-5.54.0/src/writers/taglibwriter.cpp 
new/kfilemetadata-5.55.0/src/writers/taglibwriter.cpp
--- old/kfilemetadata-5.54.0/src/writers/taglibwriter.cpp       2019-01-06 
21:21:52.000000000 +0100
+++ new/kfilemetadata-5.55.0/src/writers/taglibwriter.cpp       2019-02-03 
00:56:53.000000000 +0100
@@ -39,10 +39,18 @@
     QStringLiteral("audio/mpeg3"),
     QStringLiteral("audio/ogg"),
     QStringLiteral("audio/opus"),
+    QStringLiteral("audio/speex"),
+    QStringLiteral("audio/wav"),
+    QStringLiteral("audio/x-aiff"),
+    QStringLiteral("audio/x-ape"),
     QStringLiteral("audio/x-mpeg"),
+    QStringLiteral("audio/x-ms-wma"),
     QStringLiteral("audio/x-musepack"),
     QStringLiteral("audio/x-opus+ogg"),
+    QStringLiteral("audio/x-speex"),
     QStringLiteral("audio/x-vorbis+ogg"),
+    QStringLiteral("audio/x-wav"),
+    QStringLiteral("audio/x-wavpack"),
 };
 
 QStringList TagLibWriter::writeMimetypes() const


Reply via email to