Hello community, here is the log from the commit of package fwbuilder for openSUSE:Factory checked in at 2019-02-15 10:03:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/fwbuilder (Old) and /work/SRC/openSUSE:Factory/.fwbuilder.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "fwbuilder" Fri Feb 15 10:03:58 2019 rev:17 rq:676246 version:5.3.7 Changes: -------- --- /work/SRC/openSUSE:Factory/fwbuilder/fwbuilder.changes 2018-02-13 10:29:36.716642802 +0100 +++ /work/SRC/openSUSE:Factory/.fwbuilder.new.28833/fwbuilder.changes 2019-02-15 10:04:32.559584260 +0100 @@ -1,0 +2,5 @@ +Thu Feb 14 15:22:46 UTC 2019 - matthias.gerst...@suse.com + +- Add fix-bsc1124647-segfault.patch: Fix crash described in bsc#1124647 + +------------------------------------------------------------------- New: ---- fix-bsc1124647-segfault.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ fwbuilder.spec ++++++ --- /var/tmp/diff_new_pack.aBbVQ2/_old 2019-02-15 10:04:33.647583908 +0100 +++ /var/tmp/diff_new_pack.aBbVQ2/_new 2019-02-15 10:04:33.647583908 +0100 @@ -1,7 +1,7 @@ # # spec file for package fwbuilder # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -20,11 +20,12 @@ Version: 5.3.7 Release: 0 Summary: Firewall Builder -License: GPL-2.0+ +License: GPL-2.0-or-later Group: Productivity/Networking/Security Url: http://www.fwbuilder.org/ Source: https://github.com/fwbuilder/fwbuilder/archive/v%{version}.tar.gz Patch0: fwbuilder-qmake-without-flags.patch +Patch1: fix-bsc1124647-segfault.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: autoconf BuildRequires: automake @@ -57,6 +58,7 @@ %prep %autosetup -p1 +#%%patch1 -p1 %build NOCONFIGURE=1 ./autogen.sh "--with-qmake=qmake-qt5" ++++++ fix-bsc1124647-segfault.patch ++++++ Index: fwbuilder-5.3.7/src/libgui/ObjectManipulator.cpp =================================================================== --- fwbuilder-5.3.7.orig/src/libgui/ObjectManipulator.cpp +++ fwbuilder-5.3.7/src/libgui/ObjectManipulator.cpp @@ -112,7 +112,7 @@ ObjectManipulator::~ObjectManipulator() } ObjectManipulator::ObjectManipulator(QWidget *parent): - QWidget(parent), current_tree_view(0) + QWidget(parent), current_tree_view(0), lastClickedItem(0) { m_objectManipulator = new Ui::ObjectManipulator_q; m_objectManipulator->setupUi(this); Index: fwbuilder-5.3.7/src/libgui/ObjectManipulator_create_new.cpp =================================================================== --- fwbuilder-5.3.7.orig/src/libgui/ObjectManipulator_create_new.cpp +++ fwbuilder-5.3.7/src/libgui/ObjectManipulator_create_new.cpp @@ -249,8 +249,11 @@ void ObjectManipulator::createNewObject( //directly move object to it's subfolder list<FWObject*> newObjs; newObjs.push_back(new_obj); - moveItems(lastClickedItem, newObjs); - lastClickedItem = NULL; + if (lastClickedItem!=NULL) + { + moveItems(lastClickedItem, newObjs); + lastClickedItem = NULL; + } m_project->undoStack->push(macro); }
