Hello community,
here is the log from the commit of package rubygem-actionview-5.2 for
openSUSE:Factory checked in at 2019-04-01 12:35:50
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rubygem-actionview-5.2 (Old)
and /work/SRC/openSUSE:Factory/.rubygem-actionview-5.2.new.25356 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-actionview-5.2"
Mon Apr 1 12:35:50 2019 rev:6 rq:689679 version:5.2.3
Changes:
--------
---
/work/SRC/openSUSE:Factory/rubygem-actionview-5.2/rubygem-actionview-5.2.changes
2019-03-14 15:03:46.083633999 +0100
+++
/work/SRC/openSUSE:Factory/.rubygem-actionview-5.2.new.25356/rubygem-actionview-5.2.changes
2019-04-01 12:35:55.881843617 +0200
@@ -1,0 +2,20 @@
+Fri Mar 29 05:50:48 UTC 2019 - Stephan Kulow <co...@suse.com>
+
+- updated to version 5.2.3
+ see installed CHANGELOG.md
+
+ ## Rails 5.2.3 (March 27, 2019) ##
+
+ * Prevent non-primary mouse keys from triggering Rails UJS click handlers.
+ Firefox fires click events even if the click was triggered by
non-primary mouse keys such as right- or scroll-wheel-clicks.
+ For example, right-clicking a link such as the one described below (with
an underlying ajax request registered on click) should not cause that request
to occur.
+
+ ```
+ <%= link_to 'Remote', remote_path, class: 'remote', remote: true, data:
{ type: :json } %>
+ ```
+
+ Fixes #34541
+
+ *Wolfgang Hobmaier*
+
+-------------------------------------------------------------------
Old:
----
actionview-5.2.2.1.gem
New:
----
actionview-5.2.3.gem
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ rubygem-actionview-5.2.spec ++++++
--- /var/tmp/diff_new_pack.WyzLOm/_old 2019-04-01 12:35:57.929844619 +0200
+++ /var/tmp/diff_new_pack.WyzLOm/_new 2019-04-01 12:35:57.961844634 +0200
@@ -12,7 +12,7 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
@@ -24,7 +24,7 @@
#
Name: rubygem-actionview-5.2
-Version: 5.2.2.1
+Version: 5.2.3
Release: 0
%define mod_name actionview
%define mod_full_name %{mod_name}-%{version}
@@ -36,9 +36,9 @@
%endif
# /MANUAL
BuildRoot: %{_tmppath}/%{name}-%{version}-build
-BuildRequires: ruby-macros >= 5
BuildRequires: %{ruby >= 2.2.2}
BuildRequires: %{rubygem gem2rpm}
+BuildRequires: ruby-macros >= 5
Url: http://rubyonrails.org
Source: https://rubygems.org/gems/%{mod_full_name}.gem
Source1: gem2rpm.yml
++++++ actionview-5.2.2.1.gem -> actionview-5.2.3.gem ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md
--- old/CHANGELOG.md 2019-03-13 17:47:08.000000000 +0100
+++ new/CHANGELOG.md 2019-03-28 04:00:56.000000000 +0100
@@ -1,3 +1,18 @@
+## Rails 5.2.3 (March 27, 2019) ##
+
+* Prevent non-primary mouse keys from triggering Rails UJS click handlers.
+ Firefox fires click events even if the click was triggered by non-primary
mouse keys such as right- or scroll-wheel-clicks.
+ For example, right-clicking a link such as the one described below (with
an underlying ajax request registered on click) should not cause that request
to occur.
+
+ ```
+ <%= link_to 'Remote', remote_path, class: 'remote', remote: true, data: {
type: :json } %>
+ ```
+
+ Fixes #34541
+
+ *Wolfgang Hobmaier*
+
+
## Rails 5.2.2.1 (March 11, 2019) ##
* No changes.
Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_view/digestor.rb
new/lib/action_view/digestor.rb
--- old/lib/action_view/digestor.rb 2019-03-13 17:47:08.000000000 +0100
+++ new/lib/action_view/digestor.rb 2019-03-28 04:00:56.000000000 +0100
@@ -70,13 +70,11 @@
end
private
- def find_template(finder, *args)
+ def find_template(finder, name, prefixes, partial, keys)
finder.disable_cache do
- if format = finder.rendered_format
- finder.find_all(*args, formats: [format]).first ||
finder.find_all(*args).first
- else
- finder.find_all(*args).first
- end
+ format = finder.rendered_format
+ result = finder.find_all(name, prefixes, partial, keys, formats:
[format]).first if format
+ result || finder.find_all(name, prefixes, partial, keys).first
end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_view/gem_version.rb
new/lib/action_view/gem_version.rb
--- old/lib/action_view/gem_version.rb 2019-03-13 17:47:08.000000000 +0100
+++ new/lib/action_view/gem_version.rb 2019-03-28 04:00:56.000000000 +0100
@@ -9,8 +9,8 @@
module VERSION
MAJOR = 5
MINOR = 2
- TINY = 2
- PRE = "1"
+ TINY = 3
+ PRE = nil
STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_view/helpers/form_helper.rb
new/lib/action_view/helpers/form_helper.rb
--- old/lib/action_view/helpers/form_helper.rb 2019-03-13 17:47:08.000000000
+0100
+++ new/lib/action_view/helpers/form_helper.rb 2019-03-28 04:00:56.000000000
+0100
@@ -1971,7 +1971,7 @@
convert_to_legacy_options(options)
- fields_for(scope || model, model, **options, &block)
+ fields_for(scope || model, model, options, &block)
end
# Returns a label tag tailored for labelling an input field for a
specified attribute (identified by +method+) on an object
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/action_view/helpers/text_helper.rb
new/lib/action_view/helpers/text_helper.rb
--- old/lib/action_view/helpers/text_helper.rb 2019-03-13 17:47:08.000000000
+0100
+++ new/lib/action_view/helpers/text_helper.rb 2019-03-28 04:00:56.000000000
+0100
@@ -228,7 +228,7 @@
# pluralize(2, 'Person', locale: :de)
# # => 2 Personen
def pluralize(count, singular, plural_arg = nil, plural: plural_arg,
locale: I18n.locale)
- word = if (count == 1 || count =~ /^1(\.0+)?$/)
+ word = if (count == 1 || count.to_s =~ /^1(\.0+)?$/)
singular
else
plural || singular.pluralize(locale)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/assets/compiled/rails-ujs.js
new/lib/assets/compiled/rails-ujs.js
--- old/lib/assets/compiled/rails-ujs.js 2019-03-13 17:47:08.000000000
+0100
+++ new/lib/assets/compiled/rails-ujs.js 2019-03-28 04:00:56.000000000
+0100
@@ -32,12 +32,17 @@
(function() {
(function() {
- var cspNonce;
+ var nonce;
- cspNonce = Rails.cspNonce = function() {
- var meta;
- meta = document.querySelector('meta[name=csp-nonce]');
- return meta && meta.content;
+ nonce = null;
+
+ Rails.loadCSPNonce = function() {
+ var ref;
+ return nonce = (ref = document.querySelector("meta[name=csp-nonce]"))
!= null ? ref.content : void 0;
+ };
+
+ Rails.cspNonce = function() {
+ return nonce != null ? nonce : Rails.loadCSPNonce();
};
}).call(this);
@@ -616,22 +621,24 @@
return setData(form, 'ujs:submit-button-formmethod',
button.getAttribute('formmethod'));
};
- Rails.handleMetaClick = function(e) {
- var data, link, metaClick, method;
+ Rails.preventInsignificantClick = function(e) {
+ var data, insignificantMetaClick, link, metaClick, method,
primaryMouseKey;
link = this;
method = (link.getAttribute('data-method') || 'GET').toUpperCase();
data = link.getAttribute('data-params');
metaClick = e.metaKey || e.ctrlKey;
- if (metaClick && method === 'GET' && !data) {
+ insignificantMetaClick = metaClick && method === 'GET' && !data;
+ primaryMouseKey = e.button === 0;
+ if (!primaryMouseKey || insignificantMetaClick) {
return e.stopImmediatePropagation();
}
};
}).call(this);
(function() {
- var $, CSRFProtection, delegate, disableElement, enableElement, fire,
formSubmitButtonClick, getData, handleConfirm, handleDisabledElement,
handleMetaClick, handleMethod, handleRemote, refreshCSRFTokens;
+ var $, CSRFProtection, delegate, disableElement, enableElement, fire,
formSubmitButtonClick, getData, handleConfirm, handleDisabledElement,
handleMethod, handleRemote, loadCSPNonce, preventInsignificantClick,
refreshCSRFTokens;
- fire = Rails.fire, delegate = Rails.delegate, getData = Rails.getData, $
= Rails.$, refreshCSRFTokens = Rails.refreshCSRFTokens, CSRFProtection =
Rails.CSRFProtection, enableElement = Rails.enableElement, disableElement =
Rails.disableElement, handleDisabledElement = Rails.handleDisabledElement,
handleConfirm = Rails.handleConfirm, handleRemote = Rails.handleRemote,
formSubmitButtonClick = Rails.formSubmitButtonClick, handleMetaClick =
Rails.handleMetaClick, handleMethod = Rails.handleMethod;
+ fire = Rails.fire, delegate = Rails.delegate, getData = Rails.getData, $
= Rails.$, refreshCSRFTokens = Rails.refreshCSRFTokens, CSRFProtection =
Rails.CSRFProtection, loadCSPNonce = Rails.loadCSPNonce, enableElement =
Rails.enableElement, disableElement = Rails.disableElement,
handleDisabledElement = Rails.handleDisabledElement, handleConfirm =
Rails.handleConfirm, preventInsignificantClick =
Rails.preventInsignificantClick, handleRemote = Rails.handleRemote,
formSubmitButtonClick = Rails.formSubmitButtonClick, handleMethod =
Rails.handleMethod;
if ((typeof jQuery !== "undefined" && jQuery !== null) && (jQuery.ajax
!= null)) {
if (jQuery.rails) {
@@ -665,12 +672,13 @@
delegate(document, Rails.linkDisableSelector, 'ajax:stopped',
enableElement);
delegate(document, Rails.buttonDisableSelector, 'ajax:complete',
enableElement);
delegate(document, Rails.buttonDisableSelector, 'ajax:stopped',
enableElement);
+ delegate(document, Rails.linkClickSelector, 'click',
preventInsignificantClick);
delegate(document, Rails.linkClickSelector, 'click',
handleDisabledElement);
delegate(document, Rails.linkClickSelector, 'click', handleConfirm);
- delegate(document, Rails.linkClickSelector, 'click', handleMetaClick);
delegate(document, Rails.linkClickSelector, 'click', disableElement);
delegate(document, Rails.linkClickSelector, 'click', handleRemote);
delegate(document, Rails.linkClickSelector, 'click', handleMethod);
+ delegate(document, Rails.buttonClickSelector, 'click',
preventInsignificantClick);
delegate(document, Rails.buttonClickSelector, 'click',
handleDisabledElement);
delegate(document, Rails.buttonClickSelector, 'click', handleConfirm);
delegate(document, Rails.buttonClickSelector, 'click', disableElement);
@@ -688,10 +696,12 @@
});
delegate(document, Rails.formSubmitSelector, 'ajax:send',
disableElement);
delegate(document, Rails.formSubmitSelector, 'ajax:complete',
enableElement);
+ delegate(document, Rails.formInputClickSelector, 'click',
preventInsignificantClick);
delegate(document, Rails.formInputClickSelector, 'click',
handleDisabledElement);
delegate(document, Rails.formInputClickSelector, 'click',
handleConfirm);
delegate(document, Rails.formInputClickSelector, 'click',
formSubmitButtonClick);
document.addEventListener('DOMContentLoaded', refreshCSRFTokens);
+ document.addEventListener('DOMContentLoaded', loadCSPNonce);
return window._rails_loaded = true;
};
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/metadata new/metadata
--- old/metadata 2019-03-13 17:47:08.000000000 +0100
+++ new/metadata 2019-03-28 04:00:56.000000000 +0100
@@ -1,14 +1,14 @@
--- !ruby/object:Gem::Specification
name: actionview
version: !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
platform: ruby
authors:
- David Heinemeier Hansson
autorequire:
bindir: bin
cert_chain: []
-date: 2019-03-13 00:00:00.000000000 Z
+date: 2019-03-28 00:00:00.000000000 Z
dependencies:
- !ruby/object:Gem::Dependency
name: activesupport
@@ -16,14 +16,14 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
- !ruby/object:Gem::Dependency
name: builder
requirement: !ruby/object:Gem::Requirement
@@ -92,28 +92,28 @@
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
type: :development
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
- !ruby/object:Gem::Dependency
name: activemodel
requirement: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
type: :development
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
requirements:
- - '='
- !ruby/object:Gem::Version
- version: 5.2.2.1
+ version: 5.2.3
description: Simple, battle-tested conventions and helpers for building web
pages.
email: da...@loudthinking.com
executables: []
@@ -230,8 +230,8 @@
licenses:
- MIT
metadata:
- source_code_uri: https://github.com/rails/rails/tree/v5.2.2.1/actionview
- changelog_uri:
https://github.com/rails/rails/blob/v5.2.2.1/actionview/CHANGELOG.md
+ source_code_uri: https://github.com/rails/rails/tree/v5.2.3/actionview
+ changelog_uri:
https://github.com/rails/rails/blob/v5.2.3/actionview/CHANGELOG.md
post_install_message:
rdoc_options: []
require_paths:
