Hello community,
here is the log from the commit of package libvirt for openSUSE:Factory checked
in at 2019-05-22 10:53:04
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libvirt (Old)
and /work/SRC/openSUSE:Factory/.libvirt.new.5148 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libvirt"
Wed May 22 10:53:04 2019 rev:283 rq:704537 version:5.3.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/libvirt/libvirt.changes 2019-05-21
10:35:52.331262918 +0200
+++ /work/SRC/openSUSE:Factory/.libvirt.new.5148/libvirt.changes
2019-05-22 10:53:13.747242186 +0200
@@ -1,0 +2,10 @@
+Tue May 21 17:15:09 UTC 2019 - James Fehlig <jfeh...@suse.com>
+
+- admin: reject clients unless their UID matches the server UID
+ CVE-2019-10132
+ 96f41cd7-admin-reject-clients.patch,
+ f111e094-locking-restrict-sockets-to-mode-0600.patch,
+ e37bd65f-logging-restrict-sockets-to-mode-0600.patch
+ bsc#1134348
+
+-------------------------------------------------------------------
New:
----
96f41cd7-admin-reject-clients.patch
e37bd65f-logging-restrict-sockets-to-mode-0600.patch
f111e094-locking-restrict-sockets-to-mode-0600.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libvirt.spec ++++++
--- /var/tmp/diff_new_pack.U3V7aD/_old 2019-05-22 10:53:16.943239256 +0200
+++ /var/tmp/diff_new_pack.U3V7aD/_new 2019-05-22 10:53:16.959239242 +0200
@@ -339,6 +339,9 @@
# Upstream patches
Patch0: 5cd9db3a-cputest-add-data-E3-1225-v5.patch
Patch1: 538d8735-cpu_map-Define-md-clear-CPUID-bit.patch
+Patch2: 96f41cd7-admin-reject-clients.patch
+Patch3: f111e094-locking-restrict-sockets-to-mode-0600.patch
+Patch4: e37bd65f-logging-restrict-sockets-to-mode-0600.patch
# Patches pending upstream review
Patch100: libxl-dom-reset.patch
Patch101: network-don-t-use-dhcp-authoritative-on-static-netwo.patch
@@ -874,6 +877,9 @@
%setup -q
%patch0 -p1
%patch1 -p1
+%patch2 -p1
+%patch3 -p1
+%patch4 -p1
%patch100 -p1
%patch101 -p1
%patch150 -p1
++++++ 96f41cd7-admin-reject-clients.patch ++++++
commit 96f41cd765c9e525fe28ee5abbfbf4a79b3720c7
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: Tue Apr 30 17:26:13 2019 +0100
admin: reject clients unless their UID matches the current UID
The admin protocol RPC messages are only intended for use by the user
running the daemon. As such they should not be allowed for any client
UID that does not match the server UID.
Fixes CVE-2019-10132
Reviewed-by: Ján Tomko <jto...@redhat.com>
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Index: libvirt-5.3.0/src/admin/admin_server_dispatch.c
===================================================================
--- libvirt-5.3.0.orig/src/admin/admin_server_dispatch.c
+++ libvirt-5.3.0/src/admin/admin_server_dispatch.c
@@ -64,6 +64,28 @@ remoteAdmClientNew(virNetServerClientPtr
void *opaque)
{
struct daemonAdmClientPrivate *priv;
+ uid_t clientuid;
+ gid_t clientgid;
+ pid_t clientpid;
+ unsigned long long timestamp;
+
+ if (virNetServerClientGetUNIXIdentity(client,
+ &clientuid,
+ &clientgid,
+ &clientpid,
+ ×tamp) < 0)
+ return NULL;
+
+ VIR_DEBUG("New client pid %lld uid %lld",
+ (long long)clientpid,
+ (long long)clientuid);
+
+ if (geteuid() != clientuid) {
+ virReportRestrictedError(_("Disallowing client %lld with uid %lld"),
+ (long long)clientpid,
+ (long long)clientuid);
+ return NULL;
+ }
if (VIR_ALLOC(priv) < 0)
return NULL;
++++++ e37bd65f-logging-restrict-sockets-to-mode-0600.patch ++++++
commit e37bd65f9948c1185456b2cdaa3bd6e875af680f
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: Tue Apr 30 17:27:41 2019 +0100
logging: restrict sockets to mode 0600
The virtlogd daemon's only intended client is the libvirtd daemon. As
such it should never allow clients from other user accounts to connect.
The code already enforces this and drops clients from other UIDs, but
we can get earlier (and thus stronger) protection against DoS by setting
the socket permissions to 0600
Fixes CVE-2019-10132
Reviewed-by: Ján Tomko <jto...@redhat.com>
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Index: libvirt-5.3.0/src/logging/virtlogd-admin.socket.in
===================================================================
--- libvirt-5.3.0.orig/src/logging/virtlogd-admin.socket.in
+++ libvirt-5.3.0/src/logging/virtlogd-admin.socket.in
@@ -5,6 +5,7 @@ Before=libvirtd.service
[Socket]
ListenStream=@localstatedir@/run/libvirt/virtlogd-admin-sock
Service=virtlogd.service
+SocketMode=0600
[Install]
WantedBy=sockets.target
Index: libvirt-5.3.0/src/logging/virtlogd.socket.in
===================================================================
--- libvirt-5.3.0.orig/src/logging/virtlogd.socket.in
+++ libvirt-5.3.0/src/logging/virtlogd.socket.in
@@ -4,6 +4,7 @@ Before=libvirtd.service
[Socket]
ListenStream=@localstatedir@/run/libvirt/virtlogd-sock
+SocketMode=0600
[Install]
WantedBy=sockets.target
++++++ f111e094-locking-restrict-sockets-to-mode-0600.patch ++++++
commit f111e09468693909b1f067aa575efdafd9a262a1
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: Tue Apr 30 16:51:37 2019 +0100
locking: restrict sockets to mode 0600
The virtlockd daemon's only intended client is the libvirtd daemon. As
such it should never allow clients from other user accounts to connect.
The code already enforces this and drops clients from other UIDs, but
we can get earlier (and thus stronger) protection against DoS by setting
the socket permissions to 0600
Fixes CVE-2019-10132
Reviewed-by: Ján Tomko <jto...@redhat.com>
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Index: libvirt-5.3.0/src/locking/virtlockd-admin.socket.in
===================================================================
--- libvirt-5.3.0.orig/src/locking/virtlockd-admin.socket.in
+++ libvirt-5.3.0/src/locking/virtlockd-admin.socket.in
@@ -5,6 +5,7 @@ Before=libvirtd.service
[Socket]
ListenStream=@localstatedir@/run/libvirt/virtlockd-admin-sock
Service=virtlockd.service
+SocketMode=0600
[Install]
WantedBy=sockets.target
Index: libvirt-5.3.0/src/locking/virtlockd.socket.in
===================================================================
--- libvirt-5.3.0.orig/src/locking/virtlockd.socket.in
+++ libvirt-5.3.0/src/locking/virtlockd.socket.in
@@ -4,6 +4,7 @@ Before=libvirtd.service
[Socket]
ListenStream=@localstatedir@/run/libvirt/virtlockd-sock
+SocketMode=0600
[Install]
WantedBy=sockets.target
