Hello community,
here is the log from the commit of package python-spyder-notebook for
openSUSE:Factory checked in at 2019-06-04 12:13:23
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-spyder-notebook (Old)
and /work/SRC/openSUSE:Factory/.python-spyder-notebook.new.5148 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-spyder-notebook"
Tue Jun 4 12:13:23 2019 rev:4 rq:707326 version:0.1.4
Changes:
--------
---
/work/SRC/openSUSE:Factory/python-spyder-notebook/python-spyder-notebook.changes
2018-12-24 11:47:44.321115563 +0100
+++
/work/SRC/openSUSE:Factory/.python-spyder-notebook.new.5148/python-spyder-notebook.changes
2019-06-04 12:13:40.111795678 +0200
@@ -1,0 +2,17 @@
+Mon Jun 3 17:04:50 UTC 2019 - Todd R <toddrme2...@gmail.com>
+
+- Fix jupyter dependencies.
+- Update to 0.1.4
+ This is a bug fix release, mainly to resolve an incompatibility with Spyder
3.3.2.
+ + Issues Closed
+ * Resolve CI test failures with Python 2
+ * Update handling of temp directory for Spyder 3.3.2
+ * Update tests for pytest v4
+ * Remove untitled notebooks after they are closed
+ + Pull Requests Merged
+ * PR: Delete file when closing notebook if in temp dir
+ * PR: Specify Qt 5 in CI test script
+ * PR: Use test fixture as pytest intends it
+ * PR: Fix Spyder 3.3.2 import of TEMPDIR
+
+-------------------------------------------------------------------
Old:
----
spyder-notebook-0.1.3.tar.gz
New:
----
spyder-notebook-0.1.4.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ python-spyder-notebook.spec ++++++
--- /var/tmp/diff_new_pack.gYMrae/_old 2019-06-04 12:13:43.115794694 +0200
+++ /var/tmp/diff_new_pack.gYMrae/_new 2019-06-04 12:13:43.115794694 +0200
@@ -1,7 +1,7 @@
#
# spec file for package python-spyder-notebook
#
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,20 +12,19 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
%{?!python_module:%define python_module() python-%{**} python3-%{**}}
Name: python-spyder-notebook
-Version: 0.1.3
+Version: 0.1.4
Release: 0
Summary: Jupyter notebook integration with Spyder
License: MIT
Group: Development/Languages/Python
Url: https://github.com/spyder-ide/spyder-notebook
Source:
https://files.pythonhosted.org/packages/source/s/spyder-notebook/spyder-notebook-%{version}.tar.gz
-BuildRequires: %{python_module devel}
BuildRequires: %{python_module setuptools}
BuildRequires: fdupes
BuildRequires: python-rpm-macros
@@ -44,8 +43,8 @@
Summary: Jupyter Notebook plugin for the Spyder IDE
Group: Development/Languages/Python
Requires: python-QtPy
-Requires: python-jupyter_nbformat
-Requires: python-jupyter_notebook >= 4.3
+Requires: python-nbformat
+Requires: python-notebook >= 4.3
Requires: python-psutil
Requires: python-requests
Requires: spyder >= 3.2.0
@@ -61,8 +60,8 @@
Summary: Jupyter Notebook plugin for the Spyder3 IDE
Group: Development/Languages/Python
Requires: python3-QtPy
-Requires: python3-jupyter_nbformat
-Requires: python3-jupyter_notebook >= 4.3
+Requires: python3-nbformat
+Requires: python3-notebook >= 4.3
Requires: python3-psutil
Requires: python3-requests
Requires: spyder3 >= 3.2.0
@@ -86,13 +85,11 @@
%python_expand %fdupes %{buildroot}%{$python_sitelib}
%files -n spyder-notebook
-%defattr(-,root,root,-)
%doc CHANGELOG.md README.md
%license LICENSE
%{python2_sitelib}/*
%files -n spyder3-notebook
-%defattr(-,root,root,-)
%doc CHANGELOG.md README.md
%license LICENSE
%{python3_sitelib}/*
++++++ spyder-notebook-0.1.3.tar.gz -> spyder-notebook-0.1.4.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/spyder-notebook-0.1.3/CHANGELOG.md
new/spyder-notebook-0.1.4/CHANGELOG.md
--- old/spyder-notebook-0.1.3/CHANGELOG.md 2018-09-01 11:00:31.000000000
+0200
+++ new/spyder-notebook-0.1.4/CHANGELOG.md 2018-12-22 19:43:05.000000000
+0100
@@ -1,3 +1,26 @@
+## Version 0.1.4 (2018/12/22)
+
+This is a bug fix release, mainly to resolve an incompatibility with Spyder
3.3.2.
+
+### Issues Closed
+
+* [Issue 183](https://github.com/spyder-ide/spyder-notebook/issues/183) -
Resolve CI test failures with Python 2 ([PR
182](https://github.com/spyder-ide/spyder-notebook/pull/182))
+* [Issue 181](https://github.com/spyder-ide/spyder-notebook/issues/181) -
Update handling of temp directory for Spyder 3.3.2 ([PR
178](https://github.com/spyder-ide/spyder-notebook/pull/178))
+* [Issue 179](https://github.com/spyder-ide/spyder-notebook/issues/179) -
Update tests for pytest v4 ([PR
180](https://github.com/spyder-ide/spyder-notebook/pull/180))
+* [Issue 172](https://github.com/spyder-ide/spyder-notebook/issues/172) -
Remove untitled notebooks after they are closed ([PR
190](https://github.com/spyder-ide/spyder-notebook/pull/190))
+
+In this release 4 issues were closed.
+
+### Pull Requests Merged
+
+* [PR 190](https://github.com/spyder-ide/spyder-notebook/pull/190) - PR:
Delete file when closing notebook if in temp dir
([172](https://github.com/spyder-ide/spyder-notebook/issues/172))
+* [PR 182](https://github.com/spyder-ide/spyder-notebook/pull/182) - PR:
Specify Qt 5 in CI test script
([183](https://github.com/spyder-ide/spyder-notebook/issues/183))
+* [PR 180](https://github.com/spyder-ide/spyder-notebook/pull/180) - PR: Use
test fixture as pytest intends it
([179](https://github.com/spyder-ide/spyder-notebook/issues/179))
+* [PR 178](https://github.com/spyder-ide/spyder-notebook/pull/178) - PR: Fix
Spyder 3.3.2 import of TEMPDIR
([181](https://github.com/spyder-ide/spyder-notebook/issues/181))
+
+In this release 4 pull requests were closed.
+
+
## Version 0.1.3 (2018/09/01)
This is a bug fix release, which resolves some problems reported by our users.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/spyder-notebook-0.1.3/PKG-INFO
new/spyder-notebook-0.1.4/PKG-INFO
--- old/spyder-notebook-0.1.3/PKG-INFO 2018-09-01 12:14:47.000000000 +0200
+++ new/spyder-notebook-0.1.4/PKG-INFO 2018-12-22 19:46:12.000000000 +0100
@@ -1,6 +1,6 @@
Metadata-Version: 1.1
Name: spyder-notebook
-Version: 0.1.3
+Version: 0.1.4
Summary: Jupyter notebook integration with Spyder
Home-page: https://github.com/spyder-ide/spyder-notebook
Author: Spyder Development Team
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/spyder-notebook-0.1.3/spyder_notebook/_version.py
new/spyder-notebook-0.1.4/spyder_notebook/_version.py
--- old/spyder-notebook-0.1.3/spyder_notebook/_version.py 2018-09-01
12:14:27.000000000 +0200
+++ new/spyder-notebook-0.1.4/spyder_notebook/_version.py 2018-12-22
19:44:17.000000000 +0100
@@ -1,3 +1,3 @@
"""Version File."""
-VERSION_INFO = (0, 1, 3)
+VERSION_INFO = (0, 1, 4)
__version__ = '.'.join(map(str, VERSION_INFO))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/spyder-notebook-0.1.3/spyder_notebook/notebookplugin.py
new/spyder-notebook-0.1.4/spyder_notebook/notebookplugin.py
--- old/spyder-notebook-0.1.3/spyder_notebook/notebookplugin.py 2018-09-01
12:13:28.000000000 +0200
+++ new/spyder-notebook-0.1.4/spyder_notebook/notebookplugin.py 2018-12-22
19:36:50.000000000 +0100
@@ -25,12 +25,20 @@
from spyder.config.base import _
from spyder.config.main import CONF
from spyder.utils import icon_manager as ima
-from spyder.utils.programs import TEMPDIR
from spyder.utils.qthelpers import (create_action, create_toolbutton,
add_actions, MENU_SEPARATOR)
from spyder.widgets.tabs import Tabs
try:
+ # Spyder >= 3.3.2
+ from spyder.utils.programs import get_temp_dir
+except ImportError:
+ # Spyder < 3.3.2
+ from spyder.utils.programs import TEMPDIR
+
+ def get_temp_dir():
+ return TEMPDIR
+try:
# Spyder 4
from spyder.api.plugins import SpyderPluginWidget
except ImportError:
@@ -42,7 +50,7 @@
from .widgets.client import NotebookClient
-NOTEBOOK_TMPDIR = osp.join(TEMPDIR, 'notebooks')
+NOTEBOOK_TMPDIR = osp.join(get_temp_dir(), 'notebooks')
FILTER_TITLE = _("Jupyter notebooks")
FILES_FILTER = "{} (*.ipynb)".format(FILTER_TITLE)
PACKAGE_PATH = osp.dirname(__file__)
@@ -379,6 +387,14 @@
client.shutdown_kernel()
client.close()
+ # Delete notebook file if it is in temporary directory
+ filename = client.get_filename()
+ if filename.startswith(get_temp_dir()):
+ try:
+ os.remove(filename)
+ except EnvironmentError:
+ pass
+
# Note: notebook index may have changed after closing related widgets
self.tabwidget.removeTab(self.tabwidget.indexOf(client))
self.clients.remove(client)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/spyder-notebook-0.1.3/spyder_notebook/tests/test_plugin.py
new/spyder-notebook-0.1.4/spyder_notebook/tests/test_plugin.py
--- old/spyder-notebook-0.1.3/spyder_notebook/tests/test_plugin.py
2018-09-01 12:13:28.000000000 +0200
+++ new/spyder-notebook-0.1.4/spyder_notebook/tests/test_plugin.py
2018-12-22 19:36:50.000000000 +0100
@@ -102,13 +102,13 @@
# Fixtures
# =============================================================================
@pytest.fixture
-def setup_notebook(qtbot):
+def notebook(qtbot):
"""Set up the Notebook plugin."""
- notebook = NotebookPlugin(None, testing=True)
- qtbot.addWidget(notebook)
- notebook.create_new_client()
- notebook.show()
- return notebook
+ notebook_plugin = NotebookPlugin(None, testing=True)
+ qtbot.addWidget(notebook_plugin)
+ notebook_plugin.create_new_client()
+ notebook_plugin.show()
+ return notebook_plugin
@pytest.fixture(scope='module')
@@ -124,11 +124,8 @@
# Tests
# =============================================================================
@flaky(max_runs=3)
-def test_hide_header(qtbot):
+def test_hide_header(notebook, qtbot):
"""Test that the kernel header is hidden."""
- # Create notebook
- notebook = setup_notebook(qtbot)
-
# Wait for prompt
nbwidget = notebook.get_current_nbwidget()
qtbot.waitUntil(lambda: prompt_present(nbwidget), timeout=NOTEBOOK_UP)
@@ -143,11 +140,8 @@
@flaky(max_runs=3)
-def test_shutdown_notebook_kernel(qtbot):
+def test_shutdown_notebook_kernel(notebook, qtbot):
"""Test that kernel is shutdown from server when closing a notebook."""
- # Create notebook
- notebook = setup_notebook(qtbot)
-
# Wait for prompt
nbwidget = notebook.get_current_nbwidget()
qtbot.waitUntil(lambda: prompt_present(nbwidget), timeout=NOTEBOOK_UP)
@@ -166,8 +160,26 @@
assert not is_kernel_up(kernel_id, sessions_url)
+def test_file_in_temp_dir_deleted_after_notebook_closed(notebook, qtbot):
+ """Test that notebook file in temporary directory is deleted after the
+ notebook is closed."""
+ # Wait for prompt
+ nbwidget = notebook.get_current_nbwidget()
+ qtbot.waitUntil(lambda: prompt_present(nbwidget), timeout=NOTEBOOK_UP)
+
+ # Get file name
+ client = notebook.get_current_client()
+ filename = client.get_filename()
+
+ # Close the current client
+ notebook.close_client()
+
+ # Assert file is deleted
+ assert not osp.exists(filename)
+
+
@flaky(max_runs=3)
-def test_open_notebook(qtbot, tmpdir_under_home):
+def test_open_notebook(notebook, qtbot, tmpdir_under_home):
"""Test that a notebook can be opened from a non-ascii directory."""
# Move the test file to non-ascii directory
test_notebook = osp.join(LOCATION, 'test.ipynb')
@@ -178,9 +190,6 @@
os.mkdir(os.path.join(tmpdir_under_home, u'äöüß'))
shutil.copyfile(test_notebook, test_notebook_non_ascii)
- # Create notebook
- notebook = setup_notebook(qtbot)
-
# Wait for prompt
notebook.open_notebook(filenames=[test_notebook_non_ascii])
nbwidget = notebook.get_current_nbwidget()
@@ -194,11 +203,8 @@
@flaky(max_runs=3)
-def test_save_notebook(qtbot, tmpdir):
+def test_save_notebook(notebook, qtbot, tmpdir):
"""Test that a notebook can be saved."""
- # Create notebook
- notebook = setup_notebook(qtbot)
-
# Wait for prompt
nbwidget = notebook.get_current_nbwidget()
qtbot.waitUntil(lambda: prompt_present(nbwidget), timeout=NOTEBOOK_UP)
@@ -233,11 +239,8 @@
@flaky(max_runs=3)
-def test_new_notebook(qtbot):
+def test_new_notebook(notebook, qtbot):
"""Test that a new client is really a notebook."""
- # Create notebook
- notebook = setup_notebook(qtbot)
-
# Wait for prompt
nbwidget = notebook.get_current_nbwidget()
qtbot.waitUntil(lambda: prompt_present(nbwidget), timeout=NOTEBOOK_UP)
@@ -246,10 +249,9 @@
assert len(notebook.clients) == 2
-def test_open_console_when_no_kernel(qtbot, mocker):
+def test_open_console_when_no_kernel(notebook, qtbot, mocker):
"""Test that open_console() handles the case when there is no kernel."""
- # Create notebook and mock IPython console plugin and QMessageBox
- notebook = setup_notebook(qtbot)
+ # Create mock IPython console plugin and QMessageBox
notebook.ipyconsole = mocker.Mock()
MockMessageBox = mocker.patch('spyder_notebook.notebookplugin.QMessageBox')
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/spyder-notebook-0.1.3/spyder_notebook.egg-info/PKG-INFO
new/spyder-notebook-0.1.4/spyder_notebook.egg-info/PKG-INFO
--- old/spyder-notebook-0.1.3/spyder_notebook.egg-info/PKG-INFO 2018-09-01
12:14:47.000000000 +0200
+++ new/spyder-notebook-0.1.4/spyder_notebook.egg-info/PKG-INFO 2018-12-22
19:46:12.000000000 +0100
@@ -1,6 +1,6 @@
Metadata-Version: 1.1
Name: spyder-notebook
-Version: 0.1.3
+Version: 0.1.4
Summary: Jupyter notebook integration with Spyder
Home-page: https://github.com/spyder-ide/spyder-notebook
Author: Spyder Development Team
