Hello community,
here is the log from the commit of package yast2-network for openSUSE:Factory
checked in at 2019-10-05 16:17:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-network (Old)
and /work/SRC/openSUSE:Factory/.yast2-network.new.2352 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network"
Sat Oct 5 16:17:01 2019 rev:411 rq:735348 version:4.2.19
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes
2019-10-03 14:07:29.924402927 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-network.new.2352/yast2-network.changes
2019-10-05 16:17:03.229945213 +0200
@@ -1,0 +2,12 @@
+Fri Oct 4 13:51:42 UTC 2019 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix CLI tests for network (bsc#957537)
+- 4.2.19
+
+-------------------------------------------------------------------
+Thu Oct 3 14:27:53 UTC 2019 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix blink positioning in UI (bsc#1119407)
+- 4.2.18
+
+-------------------------------------------------------------------
Old:
----
yast2-network-4.2.17.tar.bz2
New:
----
yast2-network-4.2.19.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-network.spec ++++++
--- /var/tmp/diff_new_pack.IW60dx/_old 2019-10-05 16:17:04.025943141 +0200
+++ /var/tmp/diff_new_pack.IW60dx/_new 2019-10-05 16:17:04.033943119 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.2.17
+Version: 4.2.19
Release: 0
Summary: YaST2 - Network Configuration
License: GPL-2.0-only
++++++ yast2-network-4.2.17.tar.bz2 -> yast2-network-4.2.19.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.2.17/package/yast2-network.changes
new/yast2-network-4.2.19/package/yast2-network.changes
--- old/yast2-network-4.2.17/package/yast2-network.changes 2019-10-03
09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/package/yast2-network.changes 2019-10-04
21:10:51.000000000 +0200
@@ -1,4 +1,16 @@
-------------------------------------------------------------------
+Fri Oct 4 13:51:42 UTC 2019 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix CLI tests for network (bsc#957537)
+- 4.2.19
+
+-------------------------------------------------------------------
+Thu Oct 3 14:27:53 UTC 2019 - Josef Reidinger <jreidin...@suse.com>
+
+- Fix blink positioning in UI (bsc#1119407)
+- 4.2.18
+
+-------------------------------------------------------------------
Wed Oct 2 22:02:30 UTC 2019 - Knut Anderssen <kanders...@suse.com>
- bsc#1152840
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.2.17/package/yast2-network.spec
new/yast2-network-4.2.19/package/yast2-network.spec
--- old/yast2-network-4.2.17/package/yast2-network.spec 2019-10-03
09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/package/yast2-network.spec 2019-10-04
21:10:51.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-network
-Version: 4.2.17
+Version: 4.2.19
Release: 0
Summary: YaST2 - Network Configuration
License: GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/include/network/lan/hardware.rb
new/yast2-network-4.2.19/src/include/network/lan/hardware.rb
--- old/yast2-network-4.2.17/src/include/network/lan/hardware.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/include/network/lan/hardware.rb
2019-10-04 21:10:51.000000000 +0200
@@ -27,48 +27,14 @@
# Authors: Michal Svec <ms...@suse.cz>
#
-include Yast::UIShortcuts
-
require "y2network/dialogs/s390_device_activation"
module Yast
module NetworkLanHardwareInclude
- def initialize_network_lan_hardware(include_target)
- Yast.import "UI"
-
+ def initialize_network_lan_hardware(_include_target)
textdomain "network"
Yast.import "Arch"
- Yast.import "CWM"
- Yast.import "Label"
- Yast.import "Lan"
- Yast.import "NetworkInterfaces"
- Yast.import "Popup"
- Yast.import "Wizard"
- Yast.import "LanItems"
- Yast.include include_target, "network/routines.rb"
- Yast.include include_target, "network/lan/cards.rb"
-
- @hardware = nil
- end
-
- # Dynamic initialization of help text.
- #
- # @return content of the help
- def initHelp
- if Arch.s390
- # overwrite help
- # Manual dialog help 5/4
- hw_help = _(
- "<p>Here, set up your networking device. The values will be\nwritten
to <i>/etc/modprobe.conf</i> or <i>/etc/chandev.conf</i>.</p>\n"
- ) +
- # Manual dialog help 6/4
- _(
- "<p>Options for the module should be written in the format
specified\nin the <b>IBM Device Drivers and Installation Commands</b>
manual.</p>"
- )
- end
-
- hw_help
end
# S/390 devices configuration dialog
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.2.17/src/lib/y2network/hwinfo.rb
new/yast2-network-4.2.19/src/lib/y2network/hwinfo.rb
--- old/yast2-network-4.2.17/src/lib/y2network/hwinfo.rb 2019-10-03
09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/hwinfo.rb 2019-10-04
21:10:51.000000000 +0200
@@ -21,8 +21,6 @@
require "y2network/driver"
require "y2network/udev_rule"
-Yast.import "LanItems"
-
module Y2Network
# A helper for {Hwinfo}.
class HardwareWrapper
@@ -60,6 +58,8 @@
# Makes sure that the hardware information was read
def read_hardware
+ Yast.import "LanItems"
+
Yast::LanItems.ReadHw if Yast::LanItems.Hardware.empty?
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/interface_config_builder.rb
new/yast2-network-4.2.19/src/lib/y2network/interface_config_builder.rb
--- old/yast2-network-4.2.17/src/lib/y2network/interface_config_builder.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/interface_config_builder.rb
2019-10-04 21:10:51.000000000 +0200
@@ -27,10 +27,6 @@
require "y2firewall/firewalld"
require "y2firewall/firewalld/interface"
-Yast.import "LanItems"
-Yast.import "NetworkInterfaces"
-Yast.import "Host"
-
module Y2Network
# Collects data from the UI until we have enough of it to create a
# {Y2Network::ConnectionConfig::Base} object.
@@ -179,6 +175,8 @@
# gets valid characters that can be used in interface name
# TODO: looks sysconfig specific
def name_valid_characters
+ Yast.import "NetworkInterfaces"
+
Yast::NetworkInterfaces.ValidCharsIfcfg
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/ctc.rb
new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/ctc.rb
--- old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/ctc.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/ctc.rb
2019-10-04 21:10:51.000000000 +0200
@@ -20,9 +20,6 @@
require "yast"
require "y2network/interface_config_builder"
-Yast.import "LanItems"
-Yast.import "NetworkInterfaces"
-
module Y2Network
module InterfaceConfigBuilders
class Ctc < InterfaceConfigBuilder
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/lcs.rb
new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/lcs.rb
--- old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/lcs.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/lcs.rb
2019-10-04 21:10:51.000000000 +0200
@@ -20,9 +20,6 @@
require "yast"
require "y2network/interface_config_builder"
-Yast.import "LanItems"
-Yast.import "NetworkInterfaces"
-
module Y2Network
module InterfaceConfigBuilders
class Lcs < InterfaceConfigBuilder
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/qeth.rb
new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/qeth.rb
---
old/yast2-network-4.2.17/src/lib/y2network/interface_config_builders/qeth.rb
2019-10-03 09:49:25.000000000 +0200
+++
new/yast2-network-4.2.19/src/lib/y2network/interface_config_builders/qeth.rb
2019-10-04 21:10:51.000000000 +0200
@@ -20,9 +20,6 @@
require "yast"
require "y2network/interface_config_builder"
-Yast.import "LanItems"
-Yast.import "NetworkInterfaces"
-
module Y2Network
module InterfaceConfigBuilders
# Builder for S390 qeth interfaces. It also assumes the activation
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/widgets/blink_button.rb
new/yast2-network-4.2.19/src/lib/y2network/widgets/blink_button.rb
--- old/yast2-network-4.2.17/src/lib/y2network/widgets/blink_button.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/widgets/blink_button.rb
2019-10-04 21:10:51.000000000 +0200
@@ -44,7 +44,10 @@
100,
5
),
- PushButton(Id(:blink_button), _("Blink"))
+ VBox(
+ VSpacing(),
+ PushButton(Id(:blink_button), _("Blink"))
+ )
)
)
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-network-4.2.17/src/lib/y2network/widgets/slave_items.rb
new/yast2-network-4.2.19/src/lib/y2network/widgets/slave_items.rb
--- old/yast2-network-4.2.17/src/lib/y2network/widgets/slave_items.rb
2019-10-03 09:49:25.000000000 +0200
+++ new/yast2-network-4.2.19/src/lib/y2network/widgets/slave_items.rb
2019-10-04 21:10:51.000000000 +0200
@@ -20,7 +20,6 @@
require "yast"
Yast.import "NetworkInterfaces"
-Yast.import "LanItems"
module Y2Network
module Widgets
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.2.17/t/README.md
new/yast2-network-4.2.19/t/README.md
--- old/yast2-network-4.2.17/t/README.md 2019-10-03 09:49:25.000000000
+0200
+++ new/yast2-network-4.2.19/t/README.md 2019-10-04 21:10:51.000000000
+0200
@@ -13,7 +13,8 @@
way), so use them in a scratch VM.
```sh
-prove
+# run in top level directory as prove searching for 't' directory
+prove --verbose
```
`prove` is a runner for the [Test Anything Protocol](http://testanything.org/),
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-network-4.2.17/t/add-del.t
new/yast2-network-4.2.19/t/add-del.t
--- old/yast2-network-4.2.17/t/add-del.t 2019-10-03 09:49:25.000000000
+0200
+++ new/yast2-network-4.2.19/t/add-del.t 2019-10-04 21:10:51.000000000
+0200
@@ -25,7 +25,7 @@
set -eu
# test plan
-echo 1..7
+echo 1..8
# usage:
# foo || tapfail
@@ -35,33 +35,37 @@
echo -n "not "
}
+echo "# check if wicked runs"
+rcwicked status || tapfail
+echo "ok 1 wicked running"
+
YAST=/usr/sbin/yast
echo "# find the base device for the vlan"
BASEDEVICE=$(ip -o addr show scope global | head -n1 | cut -d' ' -f2)
-ip addr show dev $BASEDEVICE
-echo "ok 1 $BASEDEVICE: found"
+ip addr show dev $BASEDEVICE || tapfail
+echo "ok 2 $BASEDEVICE: found"
echo "# add a (virtual) interface"
$YAST lan add name=vlan50 type=vlan ethdevice=$BASEDEVICE bootproto=dhcp ||
tapfail
-echo "ok 2 vlan50: added"
+echo "ok 3 vlan50: added"
# check it has worked
ip addr show dev vlan50
-echo "ok 3 vlan50: interface exists"
+echo "ok 4 vlan50: interface exists"
ls /etc/sysconfig/network/ifcfg-vlan50 || tapfail
-echo "ok 4 vlan50: ifcfg exists"
+echo "ok 5 vlan50: ifcfg exists"
echo "# find it and delete it"
# the embarassing part: no way to identify by "vlan50"
-ID=$($YAST lan list |& grep Virtual.LAN | cut -f1)
+ID=$($YAST lan list |& grep vlan50 | cut -f1)
$YAST lan delete id=$ID verbose || tapfail
-echo "ok 5 vlan50: deleted"
+echo "ok 6 vlan50: deleted"
# how to assert nonexistence?
! ip addr show dev vlan50 || tapfail
-echo "ok 6 vlan50: interface does not exist"
+echo "ok 7 vlan50: interface does not exist"
! ls /etc/sysconfig/network/ifcfg-vlan50 || tapfail
-echo "ok 7 vlan50: ifcfg does not exist"
+echo "ok 8 vlan50: ifcfg does not exist"
