Hello community, here is the log from the commit of package guile-gcrypt for openSUSE:Factory checked in at 2019-12-21 12:31:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/guile-gcrypt (Old) and /work/SRC/openSUSE:Factory/.guile-gcrypt.new.6675 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "guile-gcrypt" Sat Dec 21 12:31:06 2019 rev:4 rq:758240 version:0.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/guile-gcrypt/guile-gcrypt.changes 2019-09-25 08:13:00.498512134 +0200 +++ /work/SRC/openSUSE:Factory/.guile-gcrypt.new.6675/guile-gcrypt.changes 2019-12-21 12:31:28.163365748 +0100 @@ -1,0 +2,13 @@ +Thu Dec 19 15:09:11 UTC 2019 - Jonathan Brielmaier <jbrielma...@suse.de> + +- Add guile-gcrypt-rpmlintrc as source to the spec file + +------------------------------------------------------------------- +Tue Dec 17 09:17:45 UTC 2019 - Jonathan Brielmaier <jbrielma...@suse.de> + +- Update to version 0.2.1: + * libgcrypt is now always properly initialized (https://bugs.gnu.org/37616) + * (gcrypt base64) no longer imports (rnrs) +- Add guile-gcrypt-rpmlintrc to silence false positives + +------------------------------------------------------------------- Old: ---- v0.2.0.tar.gz New: ---- guile-gcrypt-rpmlintrc v0.2.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ guile-gcrypt.spec ++++++ --- /var/tmp/diff_new_pack.5OHr8W/_old 2019-12-21 12:31:29.659366459 +0100 +++ /var/tmp/diff_new_pack.5OHr8W/_new 2019-12-21 12:31:29.659366459 +0100 @@ -1,7 +1,7 @@ # # spec file for package guile-gcrypt # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2019 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,13 +17,14 @@ Name: guile-gcrypt -Version: 0.2.0 +Version: 0.2.1 Release: 0 Summary: Cryptography library for Guile using Libgcrypt License: GPL-3.0-or-later Group: Development/Libraries/Other -Url: https://notabug.org/cwebber/guile-gcrypt +URL: https://notabug.org/cwebber/guile-gcrypt Source0: https://notabug.org/cwebber/%{name}/archive/v%{version}.tar.gz +Source1: guile-gcrypt-rpmlintrc BuildRequires: autoconf BuildRequires: automake BuildRequires: guile-devel >= 2.0.10 ++++++ guile-gcrypt-rpmlintrc ++++++ # guile .go files are "special" # no shared libraries addFilter("W: shared-lib-without-dependency-information /usr/lib64/guile/2.[02]/.*") # maybe a wrong linker addFilter("W: missing-PT_GNU_STACK-section /usr/lib64/guile/2.[02]/.*") ++++++ v0.2.0.tar.gz -> v0.2.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/NEWS new/guile-gcrypt/NEWS --- old/guile-gcrypt/NEWS 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/NEWS 2019-12-15 21:22:10.000000000 +0100 @@ -10,6 +10,11 @@ Please send Guix bug reports to <https://notabug.org/cwebber/guile-gcrypt>. +* Changes in 0.2.1 (since 0.2.0) + +** libgcrypt is now always properly initialized (https://bugs.gnu.org/37616) +** (gcrypt base64) no longer imports (rnrs) + * Changes in 0.2.0 (since 0.1.0) ** (gcrypt hash) now exposes all the algorithms supported by Libgcrypt diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/gcrypt/base64.scm new/guile-gcrypt/gcrypt/base64.scm --- old/guile-gcrypt/gcrypt/base64.scm 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/gcrypt/base64.scm 2019-12-15 21:22:10.000000000 +0100 @@ -53,11 +53,10 @@ base64url-alphabet get-delimited-base64 put-delimited-base64) - #:use-module (rnrs) - #:use-module ((srfi srfi-13) - #:select (string-index - string-prefix? string-suffix? - string-concatenate string-trim-both))) + #:use-module (srfi srfi-11) + #:use-module (srfi srfi-60) + #:use-module (rnrs bytevectors) + #:use-module (rnrs io ports)) (define-syntax define-alias @@ -68,12 +67,19 @@ ;; Force the use of Guile's own primitives to avoid the overhead of its 'fx' ;; procedures. -(define-alias fxbit-field bitwise-bit-field) +(define-alias fxbit-field bit-field) (define-alias fxarithmetic-shift ash) (define-alias fxarithmetic-shift-left ash) (define-alias fxand logand) (define-alias fxior logior) (define-alias fxxor logxor) +(define-alias fx=? =) +(define-alias fx+ +) +(define-alias mod modulo) + +(define-syntax-rule (assert exp) + (unless exp + (throw 'assertion-failure 'exp))) (define base64-alphabet "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/gcrypt/common.scm new/guile-gcrypt/gcrypt/common.scm --- old/guile-gcrypt/gcrypt/common.scm 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/gcrypt/common.scm 2019-12-15 21:22:10.000000000 +0100 @@ -21,25 +21,15 @@ #:use-module (gcrypt internal) #:use-module (system foreign) #:use-module (ice-9 match) - #:export (gcrypt-version - error-source error-string)) + #:re-export (gcrypt-version) + #:export (error-source error-string)) ;;; Commentary: ;;; -;;; Common code for the GNU Libgcrypt bindings. Loading this module -;;; initializes Libgcrypt as a side effect. +;;; Common code for the GNU Libgcrypt bindings. ;;; ;;; Code: -(define gcrypt-version - ;; According to the manual, this function must be called before any other, - ;; and it's not clear whether it can be called more than once. So call it - ;; right here from the top level. - (let ((proc (libgcrypt->procedure '* "gcry_check_version" '(*)))) - (lambda () - "Return the version number of libgcrypt as a string." - (pointer->string (proc %null-pointer))))) - (define error-source (let ((proc (libgcrypt->procedure '* "gcry_strsource" (list int)))) (lambda (err) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/gcrypt/internal.scm new/guile-gcrypt/gcrypt/internal.scm --- old/guile-gcrypt/gcrypt/internal.scm 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/gcrypt/internal.scm 2019-12-15 21:22:10.000000000 +0100 @@ -23,12 +23,15 @@ libgcrypt->procedure define-enumerate-type - define-lookup-procedure)) + define-lookup-procedure + + gcrypt-version)) ;;; Code: ;;; ;;; This module provides tools for internal use. The API of this module may -;;; change anytime; you should not rely on it. +;;; change anytime; you should not rely on it. Loading this module +;;; initializes Libgcrypt as a side effect. ;;; ;;; Comment: @@ -94,3 +97,17 @@ (and (<= integer #,max) (>= integer #,min) (let ((result (vector-ref values (- integer #,min)))) (and (> result 0) result))))))))))) + +(define gcrypt-version + ;; According to the manual, this function must be called before any other, + ;; and it's not clear whether it can be called more than once. So call it + ;; right here from the top level. During cross-compilation, the call to + ;; PROC fails with a 'system-error exception; catch it. + (let* ((proc (libgcrypt->procedure '* "gcry_check_version" '(*))) + (version (catch 'system-error + (lambda () + (pointer->string (proc %null-pointer))) + (const "")))) + (lambda () + "Return the version number of libgcrypt as a string." + version))) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/gcrypt/pk-crypto.scm new/guile-gcrypt/gcrypt/pk-crypto.scm --- old/guile-gcrypt/gcrypt/pk-crypto.scm 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/gcrypt/pk-crypto.scm 2019-12-15 21:22:10.000000000 +0100 @@ -329,7 +329,7 @@ result (loop (+ 1 index) ;; XXX: Call 'nth-data' *before* 'nth' to work around - ;; <https://bugs.g10code.com/gnupg/issue1594>, which + ;; <https://dev.gnupg.org/T1594>, which ;; affects 1.6.0 and earlier versions. (proc (or (canonical-sexp-nth-data sexp index) (canonical-sexp-nth sexp index)) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/guile-gcrypt/tests/pk-crypto.scm new/guile-gcrypt/tests/pk-crypto.scm --- old/guile-gcrypt/tests/pk-crypto.scm 2019-09-11 12:34:03.000000000 +0200 +++ new/guile-gcrypt/tests/pk-crypto.scm 2019-12-15 21:22:10.000000000 +0100 @@ -1,5 +1,5 @@ ;;; guile-gcrypt --- crypto tooling for guile -;;; Copyright © 2013, 2014, 2017 Ludovic Courtès <l...@gnu.org> +;;; Copyright © 2013, 2014, 2017, 2019 Ludovic Courtès <l...@gnu.org> ;;; ;;; This file is part of guile-gcrypt. ;;; @@ -278,7 +278,7 @@ (rsa (n ,(make-bytevector 1024 1)) (e ,(base16-string->bytevector "010001"))))))) - (test-equal "https://bugs.g10code.com/gnupg/issue1594"; + (test-equal "https://dev.gnupg.org/T1594"; ;; The gcrypt bug above was primarily affecting our uses in ;; 'canonical-sexp->sexp', typically when applied to a signature sexp (in ;; 'guix authenticate -verify') with a "big" RSA key, such as 4096 bits.
