Hello community, here is the log from the commit of package yast2-nfs-client for openSUSE:Leap:15.2 checked in at 2020-01-17 11:58:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/yast2-nfs-client (Old) and /work/SRC/openSUSE:Leap:15.2/.yast2-nfs-client.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-nfs-client" Fri Jan 17 11:58:51 2020 rev:39 rq:764550 version:4.2.4 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/yast2-nfs-client/yast2-nfs-client.changes 2020-01-15 16:32:15.452881083 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.yast2-nfs-client.new.26092/yast2-nfs-client.changes 2020-01-17 11:58:52.112436115 +0100 @@ -1,0 +2,7 @@ +Wed Jan 8 22:49:11 UTC 2020 - David Diaz <dgonza...@suse.com> + +- Avoids displaying phantom NFS entries adding an action to + refresh the UI (related to bsc#1156446). +- 4.2.4 + +------------------------------------------------------------------- Old: ---- yast2-nfs-client-4.2.3.tar.bz2 New: ---- yast2-nfs-client-4.2.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-nfs-client.spec ++++++ --- /var/tmp/diff_new_pack.1Ujprq/_old 2020-01-17 11:58:52.480436277 +0100 +++ /var/tmp/diff_new_pack.1Ujprq/_new 2020-01-17 11:58:52.484436278 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-nfs-client # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-nfs-client -Version: 4.2.3 +Version: 4.2.4 Release: 0 Url: https://github.com/yast/yast-nfs-client Summary: YaST2 - NFS Configuration ++++++ yast2-nfs-client-4.2.3.tar.bz2 -> yast2-nfs-client-4.2.4.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-nfs-client-4.2.3/package/yast2-nfs-client.changes new/yast2-nfs-client-4.2.4/package/yast2-nfs-client.changes --- old/yast2-nfs-client-4.2.3/package/yast2-nfs-client.changes 2019-10-30 12:54:23.000000000 +0100 +++ new/yast2-nfs-client-4.2.4/package/yast2-nfs-client.changes 2020-01-09 16:00:38.000000000 +0100 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Wed Jan 8 22:49:11 UTC 2020 - David Diaz <dgonza...@suse.com> + +- Avoids displaying phantom NFS entries adding an action to + refresh the UI (related to bsc#1156446). +- 4.2.4 + +------------------------------------------------------------------- Wed Oct 30 08:31:58 UTC 2019 - Knut Anderssen <kanders...@suse.com> - Removed nfsidmap hardcoded dependency once libnfsidmap was merged diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-nfs-client-4.2.3/package/yast2-nfs-client.spec new/yast2-nfs-client-4.2.4/package/yast2-nfs-client.spec --- old/yast2-nfs-client-4.2.3/package/yast2-nfs-client.spec 2019-10-30 12:54:23.000000000 +0100 +++ new/yast2-nfs-client-4.2.4/package/yast2-nfs-client.spec 2020-01-09 16:00:38.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-nfs-client -Version: 4.2.3 +Version: 4.2.4 Release: 0 Url: https://github.com/yast/yast-nfs-client Summary: YaST2 - NFS Configuration diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-nfs-client-4.2.3/src/clients/nfs-client4part.rb new/yast2-nfs-client-4.2.4/src/clients/nfs-client4part.rb --- old/yast2-nfs-client-4.2.3/src/clients/nfs-client4part.rb 2019-10-30 12:54:23.000000000 +0100 +++ new/yast2-nfs-client-4.2.4/src/clients/nfs-client4part.rb 2020-01-09 16:00:38.000000000 +0100 @@ -30,16 +30,17 @@ end end - if @func == "CreateUI" - Wizard.SetHelpText(@help_text1) - return FstabTab() - elsif @func == "FromStorage" - shares = Ops.get_list(@param, "shares", []) + case @func + when "CreateUI" + return create_ui + when "FromStorage" + shares = @param.fetch("shares", []) @nfs_entries = Nfs.load_nfs_entries(shares) - elsif @func == "Read" + refresh_ui + when "Read" Nfs.skip_fstab = true Nfs.Read - elsif @func == "HandleEvent" + when "HandleEvent" @widget_id = Ops.get(@param, "widget_id") @w_ids = [:newbut, :editbut, :delbut] @@ -54,6 +55,33 @@ nil end + + private + + # Generates the UI that allows to manage the NFS shares entries + # + # @return [Yast::Term] a term defining the UI + def create_ui + Wizard.SetHelpText(@help_text1) + + ReplacePoint(ui_id, FstabTab()) + end + + # Updates the UI that allows to manage the NFS shares entries + # + # @return [Boolean] true when entries are successfully replaced; false otherwise. + def refresh_ui + # The UI could be not available yet as FromStorage action can be called just to sync + # the NFS entries before create the interface. + return unless UI.WidgetExists(ui_id) + + UI.ReplaceWidget(ui_id, FstabTab()) + end + + # Returns the id for the NFS shares UI replace point + def ui_id + @ui_id ||= Id(:fstab_rp) + end end end
