Hello community,

here is the log from the commit of package libyui-ncurses-pkg for 
openSUSE:Leap:15.2 checked in at 2020-01-17 11:58:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Leap:15.2/libyui-ncurses-pkg (Old)
 and      /work/SRC/openSUSE:Leap:15.2/.libyui-ncurses-pkg.new.26092 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "libyui-ncurses-pkg"

Fri Jan 17 11:58:40 2020 rev:15 rq:761866 version:2.50.2

Changes:
--------
--- 
/work/SRC/openSUSE:Leap:15.2/libyui-ncurses-pkg/libyui-ncurses-pkg-doc.changes  
    2020-01-15 15:25:53.362592243 +0100
+++ 
/work/SRC/openSUSE:Leap:15.2/.libyui-ncurses-pkg.new.26092/libyui-ncurses-pkg-doc.changes
   2020-01-17 11:58:41.372431386 +0100
@@ -1,0 +2,6 @@
+Wed Dec 11 09:44:57 UTC 2019 - Rodion Iafarov <riafa...@suse.com>
+
+- Increase SO version to 11 (bsc#1132247)
+- 2.50.0
+
+-------------------------------------------------------------------
--- /work/SRC/openSUSE:Leap:15.2/libyui-ncurses-pkg/libyui-ncurses-pkg.changes  
2020-01-15 15:25:53.406592267 +0100
+++ 
/work/SRC/openSUSE:Leap:15.2/.libyui-ncurses-pkg.new.26092/libyui-ncurses-pkg.changes
       2020-01-17 11:58:41.444431418 +0100
@@ -1,0 +2,19 @@
+Fri Dec 13 11:59:32 CET 2019 - aschn...@suse.com
+
+- adapted to changes in libyui-ncurses (needed for bsc#1159177)
+- 2.50.2
+
+-------------------------------------------------------------------
+Wed Dec 11 14:27:17 UTC 2019 - Ladislav Slezák <lsle...@suse.cz>
+
+- Added multiversion package list to the package classification
+  filter (related to the bsc#1155132)
+- 2.50.1
+
+-------------------------------------------------------------------
+Tue Dec 10 16:31:06 UTC 2019 - Rodion Iafarov <riafa...@suse.com>
+
+- Increase SO version to 11 (bsc#1132247)
+- 2.50.0
+
+-------------------------------------------------------------------

Old:
----
  libyui-ncurses-pkg-2.49.1.tar.bz2

New:
----
  libyui-ncurses-pkg-2.50.2.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ libyui-ncurses-pkg-doc.spec ++++++
--- /var/tmp/diff_new_pack.wt0snD/_old  2020-01-17 11:58:41.828431587 +0100
+++ /var/tmp/diff_new_pack.wt0snD/_new  2020-01-17 11:58:41.836431591 +0100
@@ -15,11 +15,12 @@
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
+
 %define parent libyui-ncurses-pkg
-%define so_version 10
+%define so_version 11
 
 Name:           %{parent}-doc
-Version:        2.49.1
+Version:        2.50.2
 Release:        0
 Source:         %{parent}-%{version}.tar.bz2
 
@@ -30,7 +31,7 @@
 BuildRequires:  fdupes
 BuildRequires:  gcc-c++
 BuildRequires:  graphviz-gnome
-BuildRequires:  libyui-devel >= 3.0.4
+BuildRequires:  libyui-devel >= 3.9.0
 BuildRequires:  texlive-latex
 
 Url:            http://github.com/libyui/

++++++ libyui-ncurses-pkg.spec ++++++
--- /var/tmp/diff_new_pack.wt0snD/_old  2020-01-17 11:58:41.868431604 +0100
+++ /var/tmp/diff_new_pack.wt0snD/_new  2020-01-17 11:58:41.868431604 +0100
@@ -17,11 +17,11 @@
 
 
 Name:           libyui-ncurses-pkg
-Version:        2.49.1
+Version:        2.50.2
 Release:        0
 Source:         %{name}-%{version}.tar.bz2
 
-%define so_version 10
+%define so_version 11
 %define bin_name %{name}%{so_version}
 
 %if 0%{?suse_version} > 1325
@@ -31,10 +31,10 @@
 %endif
 BuildRequires:  cmake >= 2.8
 BuildRequires:  gcc-c++
-BuildRequires:  libyui-devel >= 3.0.4
+BuildRequires:  libyui-devel >= 3.9.0
 BuildRequires:  pkg-config
 
-%define libyui_ncurses_devel_version    libyui-ncurses-devel >= 2.43.9
+%define libyui_ncurses_devel_version    libyui-ncurses-devel >= 2.54.0
 BuildRequires:  %{libyui_ncurses_devel_version}
 %define libzypp_devel_version           libzypp-devel >= 15.11.0
 BuildRequires:  %{libzypp_devel_version}
@@ -54,8 +54,8 @@
 Requires:       libyui%{so_version}
 Provides:       %{name} = %{version}
 
-Provides:       yast2-ncurses-pkg = 2.42.0
-Obsoletes:      yast2-ncurses-pkg < 2.42.0
+Provides:       yast2-ncurses-pkg = 2.50.0
+Obsoletes:      yast2-ncurses-pkg < 2.50.0
 
 # force removal of all previous library versions (bsc#1148622),
 # expands to: libyui-ncurses-pkg1 libyui-ncurses-pkg2 ... 
libyui-ncurses-pkg{so_version - 1}

++++++ libyui-ncurses-pkg-2.49.1.tar.bz2 -> libyui-ncurses-pkg-2.50.2.tar.bz2 
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/libyui-ncurses-pkg-2.49.1/Dockerfile 
new/libyui-ncurses-pkg-2.50.2/Dockerfile
--- old/libyui-ncurses-pkg-2.49.1/Dockerfile    2019-09-06 15:55:18.000000000 
+0200
+++ new/libyui-ncurses-pkg-2.50.2/Dockerfile    2019-12-13 15:51:34.000000000 
+0100
@@ -1,4 +1,4 @@
 # Use the libyui/devel image as the base
-FROM libyui/devel
+FROM 
registry.opensuse.org/devel/libraries/libyui/containers/libyui-devel:latest
 
 COPY . /usr/src/app
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/libyui-ncurses-pkg-2.49.1/VERSION.cmake 
new/libyui-ncurses-pkg-2.50.2/VERSION.cmake
--- old/libyui-ncurses-pkg-2.49.1/VERSION.cmake 2019-09-06 15:55:18.000000000 
+0200
+++ new/libyui-ncurses-pkg-2.50.2/VERSION.cmake 2019-12-13 15:51:34.000000000 
+0100
@@ -1,6 +1,6 @@
 SET( VERSION_MAJOR "2" )
-SET( VERSION_MINOR "49" )
-SET( VERSION_PATCH "1" )
+SET( VERSION_MINOR "50" )
+SET( VERSION_PATCH "2" )
 SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}" )
 
 ##### This is need for the libyui core, ONLY.
@@ -9,4 +9,3 @@
 SET( SONAME_MINOR "0" )
 SET( SONAME_PATCH "0" )
 SET( SONAME "${SONAME_MAJOR}.${SONAME_MINOR}.${SONAME_PATCH}" )
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg-doc.changes 
new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg-doc.changes
--- old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg-doc.changes        
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg-doc.changes        
2019-12-13 15:51:34.000000000 +0100
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Wed Dec 11 09:44:57 UTC 2019 - Rodion Iafarov <riafa...@suse.com>
+
+- Increase SO version to 11 (bsc#1132247)
+- 2.50.0
+
+-------------------------------------------------------------------
 Thu Jun 12 14:45:00 CEST 2012 - bjoern.es...@gmail.com
 
 - initial package
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg-doc.spec 
new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg-doc.spec
--- old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg-doc.spec   
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg-doc.spec   
2019-12-13 15:51:34.000000000 +0100
@@ -16,10 +16,10 @@
 #
 
 %define parent libyui-ncurses-pkg
-%define so_version 10
+%define so_version 11
 
 Name:           %{parent}-doc
-Version:        2.49.1
+Version:        2.50.2
 Release:        0
 Source:         %{parent}-%{version}.tar.bz2
 
@@ -30,7 +30,7 @@
 BuildRequires:  fdupes
 BuildRequires:  gcc-c++
 BuildRequires:  graphviz-gnome
-BuildRequires:  libyui-devel >= 3.0.4
+BuildRequires:  libyui-devel >= 3.9.0
 BuildRequires:  texlive-latex
 
 Url:            http://github.com/libyui/
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg.changes 
new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg.changes
--- old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg.changes    
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg.changes    
2019-12-13 15:51:34.000000000 +0100
@@ -1,4 +1,23 @@
 -------------------------------------------------------------------
+Fri Dec 13 11:59:32 CET 2019 - aschn...@suse.com
+
+- adapted to changes in libyui-ncurses (needed for bsc#1159177)
+- 2.50.2
+
+-------------------------------------------------------------------
+Wed Dec 11 14:27:17 UTC 2019 - Ladislav Slezák <lsle...@suse.cz>
+
+- Added multiversion package list to the package classification
+  filter (related to the bsc#1155132)
+- 2.50.1
+
+-------------------------------------------------------------------
+Tue Dec 10 16:31:06 UTC 2019 - Rodion Iafarov <riafa...@suse.com>
+
+- Increase SO version to 11 (bsc#1132247)
+- 2.50.0
+
+-------------------------------------------------------------------
 Thu Sep  5 15:39:32 UTC 2019 - Ladislav Slezák <lsle...@suse.cz>
 
 - Added a new generic dependency to force upgrade from all previous
@@ -162,7 +181,7 @@
 -------------------------------------------------------------------
 Thu Jun 27 12:13:36 CEST 2013 - g...@suse.de
 
-- Show and handle multiple versions of packages correctly 
+- Show and handle multiple versions of packages correctly
   (bnc #822962)
 - Version 2.44.0
 
@@ -193,7 +212,7 @@
 -------------------------------------------------------------------
 Tue Jan 22 11:43:43 CET 2013 - g...@suse.de
 
-- Bug-fix for package search (concerning package summary) 
+- Bug-fix for package search (concerning package summary)
 - V 2.43.3
 
 -------------------------------------------------------------------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg.spec 
new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg.spec
--- old/libyui-ncurses-pkg-2.49.1/package/libyui-ncurses-pkg.spec       
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/package/libyui-ncurses-pkg.spec       
2019-12-13 15:51:34.000000000 +0100
@@ -17,11 +17,11 @@
 
 
 Name:           libyui-ncurses-pkg
-Version:        2.49.1
+Version:        2.50.2
 Release:        0
 Source:         %{name}-%{version}.tar.bz2
 
-%define so_version 10
+%define so_version 11
 %define bin_name %{name}%{so_version}
 
 %if 0%{?suse_version} > 1325
@@ -31,10 +31,10 @@
 %endif
 BuildRequires:  cmake >= 2.8
 BuildRequires:  gcc-c++
-BuildRequires:  libyui-devel >= 3.0.4
+BuildRequires:  libyui-devel >= 3.9.0
 BuildRequires:  pkg-config
 
-%define libyui_ncurses_devel_version    libyui-ncurses-devel >= 2.43.9
+%define libyui_ncurses_devel_version    libyui-ncurses-devel >= 2.54.0
 BuildRequires:  %{libyui_ncurses_devel_version}
 %define libzypp_devel_version           libzypp-devel >= 15.11.0
 BuildRequires:  %{libzypp_devel_version}
@@ -54,8 +54,8 @@
 Requires:       libyui%{so_version}
 Provides:       %{name} = %{version}
 
-Provides:       yast2-ncurses-pkg = 2.42.0
-Obsoletes:      yast2-ncurses-pkg < 2.42.0
+Provides:       yast2-ncurses-pkg = 2.50.0
+Obsoletes:      yast2-ncurses-pkg < 2.50.0
 
 # force removal of all previous library versions (bsc#1148622),
 # expands to: libyui-ncurses-pkg1 libyui-ncurses-pkg2 ... 
libyui-ncurses-pkg{so_version - 1}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/libyui-ncurses-pkg-2.49.1/src/NCPackageSelector.cc 
new/libyui-ncurses-pkg-2.50.2/src/NCPackageSelector.cc
--- old/libyui-ncurses-pkg-2.49.1/src/NCPackageSelector.cc      2019-09-06 
15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/src/NCPackageSelector.cc      2019-12-13 
15:51:34.000000000 +0100
@@ -1664,8 +1664,7 @@
     pkgList->setPackager( this );
 
     // set sort strategy
-    std::vector<std::string> pkgHeader;
-    pkgList->getHeader( pkgHeader );
+    std::vector<std::string> pkgHeader = pkgList->getHeader( );
     pkgList->setSortStrategy( new NCPkgTableSort( pkgHeader ) );
 
     // HBox for Filter and Disk Space (both in additional HBoxes )
@@ -1785,8 +1784,7 @@
     pkgList->fillHeader();
 
     // set sort strategy
-    std::vector<std::string> pkgHeader;
-    pkgList->getHeader( pkgHeader );
+    std::vector<std::string> pkgHeader = pkgList->getHeader( );
     pkgList->setSortStrategy( new NCPkgTableSort( pkgHeader ) );
 
     // label text + actions menu
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/src/NCPkgFilterClassification.cc 
new/libyui-ncurses-pkg-2.50.2/src/NCPkgFilterClassification.cc
--- old/libyui-ncurses-pkg-2.49.1/src/NCPkgFilterClassification.cc      
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/src/NCPkgFilterClassification.cc      
2019-12-13 15:51:34.000000000 +0100
@@ -71,18 +71,24 @@
     ,packager(pkg)
 {
     // fill seclection box
-    recommended = new YItem( _("Recommended") );
-    addItem( recommended );
-
-    suggested = new YItem( _("Suggested") );
+    suggested = new YItem( _("Suggested Packages") );
     addItem( suggested );
 
-    orphaned = new YItem( _("Orphaned") );
+    recommended = new YItem( _("Recommended Packages") );
+    addItem( recommended );
+
+    orphaned = new YItem( _("Orphaned Packages") );
     addItem( orphaned );
 
-    unneeded = new YItem( _("Unneeded" ) );
+    unneeded = new YItem( _("Unneeded Packages" ) );
     addItem( unneeded );
 
+    multiversion = new YItem( _("Multiversion Packages" ) );
+    addItem( multiversion );
+
+    all = new YItem( _("All Packages" ) );
+    addItem( all );
+
     showPackages();
     showDescription();
 }
@@ -127,6 +133,12 @@
         {
            match = check( selectable, tryCastToZyppPkg( 
selectable->installedObj() ), group );
         }
+        // otherwise display the candidate object (the "best" version)
+        else if ( selectable->hasCandidateObj() )
+        {
+           match = check( selectable, tryCastToZyppPkg( 
selectable->candidateObj() ), group );
+        }
+
         // And then check the pick list which contain all availables and all 
objects for multi
         // version packages and the installed obj if there isn't same version 
in a repo.
         if ( !match )
@@ -187,6 +199,17 @@
         packageList->createListEntry( pkg, selectable );
         return true;
     }
+    if ( group == multiversion &&
+         selectable->multiversionInstall() )
+    {
+        packageList->createListEntry( pkg, selectable );
+        return true;
+    }
+    if ( group == all )
+    {
+        packageList->createListEntry( pkg, selectable );
+        return true;
+    }
 
     return false;
 }
@@ -200,7 +223,7 @@
 
     if ( group == recommended )
     {
-        description = _("This is a list of useful packages. They will be 
additionally installed if recommeded by a newly installed package.");
+        description = _("This is a list of useful packages. They will be 
additionally installed if recommended by a newly installed package.");
     }
     else if ( group == suggested )
     {
@@ -214,6 +237,14 @@
     {
         description = _("These packages might be unneeded because former 
dependencies don't apply any longer.");
     }
+    else if ( group == multiversion )
+    {
+        description = _("These packages might be installed in several versions 
in parallel.");
+    }
+    else if ( group == all )
+    {
+        description = _("All packages known by the package manager, no 
filtering applied.");
+    }
     packager->FilterDescription()->setText ( description );
 }
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/libyui-ncurses-pkg-2.49.1/src/NCPkgFilterClassification.h 
new/libyui-ncurses-pkg-2.50.2/src/NCPkgFilterClassification.h
--- old/libyui-ncurses-pkg-2.49.1/src/NCPkgFilterClassification.h       
2019-09-06 15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/src/NCPkgFilterClassification.h       
2019-12-13 15:51:34.000000000 +0100
@@ -72,6 +72,8 @@
     YItem *suggested;
     YItem *orphaned;
     YItem *unneeded;
+    YItem *multiversion;
+    YItem *all;
 
     bool check (ZyppSel selectable, ZyppPkg pkg, YItem * group );
     
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/libyui-ncurses-pkg-2.49.1/src/NCPkgTable.h 
new/libyui-ncurses-pkg-2.50.2/src/NCPkgTable.h
--- old/libyui-ncurses-pkg-2.49.1/src/NCPkgTable.h      2019-09-06 
15:55:18.000000000 +0200
+++ new/libyui-ncurses-pkg-2.50.2/src/NCPkgTable.h      2019-12-13 
15:51:34.000000000 +0100
@@ -48,7 +48,7 @@
 #include "NCTable.h"
 #include "NCPkgStrings.h"
 
-#include <map>          
+#include <map>
 #include <string>
 #include <utility>      // for STL std::pair
 
@@ -73,7 +73,7 @@
     ZyppObj dataPointer;
     // cannot get at it from dataPointer
     ZyppSel selPointer;
-    
+
   public:
 
     NCPkgTableTag( ZyppObj pkgPtr,
@@ -95,30 +95,32 @@
 class NCPkgTableSort : public NCTableSortStrategyBase {
 
 public:
-    
+
     NCPkgTableSort( const std::vector<std::string> & head )
        : _header ( head )
        { }
 
     virtual void sort (
                       std::vector<NCTableLine *>::iterator itemsBegin,
-                      std::vector<NCTableLine *>::iterator itemsEnd,
-                      int  uiColumn
-                      )
+                      std::vector<NCTableLine *>::iterator itemsEnd
+                      ) override
         {
-           if ( _header[ uiColumn ] == NCPkgStrings::PkgSize() )
+           if ( _header[ getColumn() ] == NCPkgStrings::PkgSize() )
            {
                std::sort( itemsBegin, itemsEnd, CompareSize() );
            }
-           else if ( _header[ uiColumn ] == NCPkgStrings::PkgName() )
+           else if ( _header[ getColumn() ] == NCPkgStrings::PkgName() )
            {
-               std::sort( itemsBegin, itemsEnd, CompareName( uiColumn ) );
+               std::sort( itemsBegin, itemsEnd, CompareName( getColumn() ) );
            }
            else
            {
-               std::sort( itemsBegin, itemsEnd, Compare( uiColumn ) );
+               std::sort( itemsBegin, itemsEnd, Compare( getColumn() ) );
            }
-        }
+
+           if ( isReverse() )
+               std::reverse( itemsBegin, itemsEnd );
+       }
 
 private:
     std::vector<std::string> _header;
@@ -129,19 +131,18 @@
        CompareSize ( )
            {}
 
-       bool operator() ( NCTableLine * first,
-                         NCTableLine * second
+       bool operator() ( const NCTableLine * first,
+                         const NCTableLine * second
                          ) const
            {
-               YTableItem *firstItem = dynamic_cast<YTableItem*> 
(first->origItem() );
-               YTableItem *secondItem = dynamic_cast<YTableItem*> 
(second->origItem() );
-               NCPkgTableTag *firstTag = static_cast<NCPkgTableTag *>( 
firstItem->cell(0) );
-               NCPkgTableTag *secondTag = static_cast<NCPkgTableTag *>( 
secondItem->cell(0) );
+               const YTableItem *firstItem = dynamic_cast<const YTableItem*> 
(first->origItem() );
+               const YTableItem *secondItem = dynamic_cast<const YTableItem*> 
(second->origItem() );
+               const NCPkgTableTag *firstTag = static_cast<const NCPkgTableTag 
*>( firstItem->cell(0) );
+               const NCPkgTableTag *secondTag = static_cast<const 
NCPkgTableTag *>( secondItem->cell(0) );
 
                return firstTag->getDataPointer()->installSize() <
                       secondTag->getDataPointer()->installSize();
            }
-
     };
 
     class CompareName
@@ -151,8 +152,8 @@
            : _uiCol(uiCol)
            {}
 
-       bool operator() ( NCTableLine * first,
-                         NCTableLine * second
+       bool operator() ( const NCTableLine * first,
+                         const NCTableLine * second
                          ) const
            {
                 std::wstring w1 = first->GetCol( _uiCol 
)->Label().getText().begin()->str();
@@ -165,11 +166,11 @@
                 // plain wrong.
                 int result = wcscasecmp( w1.data(), w2.data() );
 
-                return result < 0;
+               return result < 0;
            }
 
     private:
-       int _uiCol;
+       const int _uiCol;
     };
 
     class Compare
@@ -179,24 +180,22 @@
            : _uiCol (uiCol)
            {}
 
-       bool operator() ( NCTableLine * first,
-                         NCTableLine * second
+       bool operator() ( const NCTableLine * first,
+                         const NCTableLine * second
                          ) const
            {
                 std::wstring w1 = first->GetCol( _uiCol 
)->Label().getText().begin()->str();
                 std::wstring w2 = second->GetCol( _uiCol 
)->Label().getText().begin()->str();
-                int result = wcscoll ( w1.data(), w2.data() );
-                
-                if ( result < 0 )
-                    return true;
-                else
-                    return false;
+
+               int result = wcscoll ( w1.data(), w2.data() );
+
+               return result < 0;
            }
     private:
-       int _uiCol;
+       const int _uiCol;
     };
 };
-    
+
 /**
  * The package table class. Provides methods to fill the table,
  * set the status info and so on.
@@ -243,26 +242,26 @@
        I_PatchDescr,
        I_PatchPkgs
     };
-    
+
 private:
 
     NCPkgTable & operator=( const NCPkgTable & );
     NCPkgTable            ( const NCPkgTable & );
-    
+
     NCPackageSelector * packager;              // connection to the 
PackageSelector,
 
     NCPkgStatusStrategy * statusStrategy;      // particular methods to get 
the status
 
     NCPkgTableType tableType;  // the type (e.g. table of packages, patches)
     bool haveInstalledVersion; // for T_Packages and T_Update
-    
+
     // returns the first column of line with 'index' (the tag)
     NCPkgTableTag * getTag ( const int & index );
 
     NCPkgTableInfoType visibleInfo;
 
     std::vector<std::string> header;           // the table header
-    
+
 protected:
 
 
@@ -291,9 +290,9 @@
 
    /**
      * Draws the package list (has to be called after the loop with addLine() 
calls)
-     */ 
+     */
    void drawList( ) { myPad()->setOrder(1); return DrawPad(); }
-    
+
    /**
     * Clears the package list
     */
@@ -336,7 +335,7 @@
      * the currently selected package and updates the states
      * of all packages in the list
      * @param newstat The new status
-     * @param slbPtr The pointer to the object to change 
+     * @param slbPtr The pointer to the object to change
      * @param objPtr is candidatePtr or what the user selected instead of it.
      * @return bool
      */
@@ -344,7 +343,7 @@
                       const ZyppSel & slbPtr,
                       ZyppObj objPtr,
                       bool singleChange );
-    
+
     bool changeObjStatus( int key );
 
     bool changeListObjStatus( NCPkgTableListAction key );
@@ -352,27 +351,27 @@
     bool toggleObjStatus( );
 
    /**
-     * Set the status information if status has changed 
+     * Set the status information if status has changed
      * @return bool
-     */  
+     */
     bool updateTable();
 
     /**
      * Gets the currently displayed package status.
      * @param index The index in package table (the line)
      * @return ZyppStatus
-     */ 
+     */
     ZyppStatus getStatus( int index );
 
 #ifdef FIXME
     /**
      * Toggles the installation of the source package.
-     * @param install 
+     * @param install
      * @return bool
-     */ 
+     */
     bool SourceInstall( bool install );
 #endif
-    
+
     /**
      * Sets the type of the table and the status strategy (which means call 
particular methods
      * to set/get the status for different zypp::ResObjects (zypp::Patch, 
zypp::Package or available zypp::Package)
@@ -384,7 +383,7 @@
     bool setTableType( NCPkgTableType type, NCPkgStatusStrategy * strategy ) {
        if ( !strategy )
            return false;
-       
+
        delete statusStrategy;
        statusStrategy = strategy;
        tableType = type;
@@ -393,31 +392,31 @@
     }
 
     NCPkgTableType getTableType() { return tableType; }
-    
+
     /**
      * Gets the data pointer of a certain package.
      * @param index The index in package table (the line)
      * @return ZyppObj
-     */ 
+     */
     ZyppObj getDataPointer( int index );
 
     /**
      * Gets the selectable pointer of a certain package.
      * @param index The index in package table (the line)
      * @return ZyppSel
-     */ 
+     */
     ZyppSel getSelPointer( int index );
 
    /**
      * Returns the number of lines in the table (the table size)
      * @return unsigned int
-     */ 
+     */
     unsigned int getNumLines( ) { return myPad()->Lines(); }
 
     /**
      * Fills the header of the table
      * @return void
-     */  
+     */
     void fillHeader( );
 
     /**
@@ -425,38 +424,38 @@
      * @param pkgPtr The package pointer
      * @param slbPtr The selectable pointer
      * @return bool
-     */  
+     */
    bool createListEntry ( ZyppPkg pkgPtr, ZyppSel slbPtr );
 
    /**
      * Creates a line in the YOU patch table.
-     * @param pkgPtr The YOU patch pointer 
+     * @param pkgPtr The YOU patch pointer
      * @return bool
-     */  
+     */
    bool createPatchEntry ( ZyppPatch pkgPtr,  ZyppSel slbPtr );
 
    /**
     * Creates a line in the table shwing an info text.
     * @param text The information
     * @return bool
-    */   
+    */
    bool createInfoEntry ( std::string text );
 
    /**
     * Show the corresponding information (e.g. the package description).
     * @return bool
-    */     
+    */
    bool showInformation ( );
 
    void setVisibleInfo( NCPkgTableInfoType info) { visibleInfo = info;  }
 
    NCPkgTableInfoType VisibleInfo() { return visibleInfo ; }
 
-   bool fillAvailableList ( ZyppSel slb ); 
-   bool fillSummaryList ( NCPkgTableListType type ); 
+   bool fillAvailableList ( ZyppSel slb );
+   bool fillSummaryList ( NCPkgTableListType type );
 
    void updateInfo( ZyppObj pkgPtr, ZyppSel slbPtr, NCPkgTableInfoType mode );
- 
+
 };
 
 ///////////////////////////////////////////////////////////////////


Reply via email to