Hello community, here is the log from the commit of package gnome-boxes for openSUSE:Leap:15.2 checked in at 2020-02-27 06:40:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/gnome-boxes (Old) and /work/SRC/openSUSE:Leap:15.2/.gnome-boxes.new.26092 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-boxes" Thu Feb 27 06:40:08 2020 rev:49 rq:778290 version:3.34.4 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/gnome-boxes/gnome-boxes.changes 2020-01-30 16:11:02.445873155 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.gnome-boxes.new.26092/gnome-boxes.changes 2020-02-27 06:40:09.325441156 +0100 @@ -1,0 +2,8 @@ +Tue Feb 18 16:00:12 UTC 2020 - Bjørn Lie <bjorn....@gmail.com> + +- Update to version 3.34.4: + + Only add CDROM device if file exists. + + Don't delete faulty VMs automatically. + + Keep live VMs permanently (until user deletion). + +------------------------------------------------------------------- Old: ---- gnome-boxes-3.34.3.tar.xz New: ---- gnome-boxes-3.34.4.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-boxes.spec ++++++ --- /var/tmp/diff_new_pack.GagxRh/_old 2020-02-27 06:40:09.741442022 +0100 +++ /var/tmp/diff_new_pack.GagxRh/_new 2020-02-27 06:40:09.745442030 +0100 @@ -22,7 +22,7 @@ %define govf_sover 0.1 %define gfrdp_sover 0.1 Name: gnome-boxes -Version: 3.34.3 +Version: 3.34.4 Release: 0 Summary: A GNOME 3 application to access remote or virtual systems License: LGPL-2.0-or-later ++++++ gnome-boxes-3.34.3.tar.xz -> gnome-boxes-3.34.4.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.34.3/NEWS new/gnome-boxes-3.34.4/NEWS --- old/gnome-boxes-3.34.3/NEWS 2020-01-06 18:52:09.000000000 +0100 +++ new/gnome-boxes-3.34.4/NEWS 2020-02-18 15:54:37.000000000 +0100 @@ -1,3 +1,16 @@ +3.34.4 - Feb 18, 2020 +===================== + +Changes since 3.34.3 + + - Only add CDROM device if file exists + - Don't delete faulty VMs automatically + - Keep live VMs permanently (until user deletion) + +All contributors to this release: + +Felipe Borges <felipebor...@gnome.org> + 3.34.3 - Jan 06, 2020 ===================== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.34.3/build-aux/flatpak/org.gnome.Boxes.json new/gnome-boxes-3.34.4/build-aux/flatpak/org.gnome.Boxes.json --- old/gnome-boxes-3.34.3/build-aux/flatpak/org.gnome.Boxes.json 2020-01-06 18:52:09.000000000 +0100 +++ new/gnome-boxes-3.34.4/build-aux/flatpak/org.gnome.Boxes.json 2020-02-18 15:54:37.000000000 +0100 @@ -313,20 +313,6 @@ ] }, { - "name" : "python-mako", - "buildsystem" : "simple", - "build-commands" : [ - "pip3 install --prefix=/app --no-deps ." - ], - "sources" : [ - { - "type" : "archive", - "url" : "https://files.pythonhosted.org/packages/b0/3c/8dcd6883d009f7cae0f3157fb53e9afb05a0d3d33b3db1268ec2e6f4a56b/Mako-1.1.0.tar.gz", - "sha256" : "a36919599a9b7dc5d86a7a8988f23a9a3a3d083070023bab23d64f7f1d1e0a4b" - } - ] - }, - { "name" : "mesa", "buildsystem" : "meson", "config-opts" : [ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.34.3/meson.build new/gnome-boxes-3.34.4/meson.build --- old/gnome-boxes-3.34.3/meson.build 2020-01-06 18:52:09.000000000 +0100 +++ new/gnome-boxes-3.34.4/meson.build 2020-02-18 15:54:37.000000000 +0100 @@ -1,6 +1,6 @@ project ('gnome-boxes', ['vala', 'c'], - version: '3.34.3', + version: '3.34.4', license: 'LGPLv2+', meson_version: '>= 0.46.0', ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.34.3/src/vm-configurator.vala new/gnome-boxes-3.34.4/src/vm-configurator.vala --- old/gnome-boxes-3.34.3/src/vm-configurator.vala 2020-01-06 18:52:09.000000000 +0100 +++ new/gnome-boxes-3.34.4/src/vm-configurator.vala 2020-02-18 15:54:37.000000000 +0100 @@ -281,8 +281,14 @@ var domain_disk = device as DomainDisk; var device_type = domain_disk.get_guest_device_type (); if (device_type == DomainDiskGuestDeviceType.CDROM) { - if (domain_disk.get_source () != null) - supports_alternative_boot_device = true; + if (domain_disk.get_source () != null) { + if (!FileUtils.test (domain_disk.get_source (), FileTest.EXISTS)) { + debug ("CDROM media '%s' cannot be found", domain_disk.get_source ()); + domain_disk.set_source (""); + } else { + supports_alternative_boot_device = true; + } + } } devices.prepend (device); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-boxes-3.34.3/src/vm-creator.vala new/gnome-boxes-3.34.4/src/vm-creator.vala --- old/gnome-boxes-3.34.3/src/vm-creator.vala 2020-01-06 18:52:09.000000000 +0100 +++ new/gnome-boxes-3.34.4/src/vm-creator.vala 2020-02-18 15:54:37.000000000 +0100 @@ -97,10 +97,7 @@ } if (!FileUtils.test (install_media.device_file, FileTest.EXISTS)) { - warning ("Source installer media '%s' no longer exists. Deleting machine '%s'..", - install_media.device_file, - machine.name); - App.app.delete_machine (machine); + warning ("Source installer media '%s' no longer exists.", install_media.device_file); return; } @@ -160,27 +157,12 @@ machine.vm_creator = null; machine.schedule_autosave (); try_create_snapshot.begin (machine); - } else { - if (VMConfigurator.is_live_config (machine.domain_config)) { - // No installation during live session, so lets delete the VM - machine.disconnect (state_changed_id); - install_media.clean_up (); - var items = new GLib.List<CollectionItem> (); - items.append (machine); - - Boxes.App.UndoNotifyCallback undo_notify_callback = () => { - debug ("Live box deletion cancelled. Invoking post installation setup..."); - set_post_install_config (machine); - }; - - var msg = _("Live box “%s” has been deleted automatically.").printf (machine.name); - App.app.delete_machines_undoable ((owned) items, msg, (owned) undo_notify_callback); - } else - try { - domain.start (0); - } catch (GLib.Error error) { - warning ("Failed to start domain '%s': %s", domain.get_name (), error.message); - } + } else if (!VMConfigurator.is_live_config (machine.domain_config)) { + try { + domain.start (0); + } catch (GLib.Error error) { + warning ("Failed to start domain '%s': %s", domain.get_name (), error.message); + } } }