Hello community, here is the log from the commit of package pam_kwallet for openSUSE:Leap:15.2 checked in at 2020-04-08 12:49:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/pam_kwallet (Old) and /work/SRC/openSUSE:Leap:15.2/.pam_kwallet.new.3248 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pam_kwallet" Wed Apr 8 12:49:06 2020 rev:74 rq:791661 version:5.18.4.1 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/pam_kwallet/pam_kwallet.changes 2020-03-13 11:01:21.460605050 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.pam_kwallet.new.3248/pam_kwallet.changes 2020-04-08 12:49:32.626378525 +0200 @@ -1,0 +2,16 @@ +Tue Mar 31 15:16:35 UTC 2020 - Fabian Vogt <fab...@ritter-vogt.de> + +- Update to 5.18.4.1: + * Version fixed + +------------------------------------------------------------------- +Tue Mar 31 14:47:41 UTC 2020 - Fabian Vogt <fab...@ritter-vogt.de> + +- Update to 5.18.4 + * New bugfix release + * For more details please see: + * https://www.kde.org/announcements/plasma-5.18.4.php +- Changes since 5.18.3: + * Make kwallet-pam work with pam_fscrypt + +------------------------------------------------------------------- Old: ---- kwallet-pam-5.18.3.tar.xz kwallet-pam-5.18.3.tar.xz.sig New: ---- kwallet-pam-5.18.4.1.tar.xz kwallet-pam-5.18.4.1.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pam_kwallet.spec ++++++ --- /var/tmp/diff_new_pack.6T6Z59/_old 2020-04-08 12:49:33.118378782 +0200 +++ /var/tmp/diff_new_pack.6T6Z59/_new 2020-04-08 12:49:33.122378784 +0200 @@ -19,15 +19,15 @@ %bcond_without lang Name: pam_kwallet -Version: 5.18.3 +Version: 5.18.4.1 Release: 0 Summary: A PAM Module for KWallet signing License: LGPL-2.1-only AND GPL-2.0-or-later AND GPL-3.0-only Group: System/GUI/KDE URL: http://www.kde.org/ -Source: https://download.kde.org/stable/plasma/%{version}/kwallet-pam-%{version}.tar.xz +Source: https://download.kde.org/stable/plasma/5.18.4/kwallet-pam-%{version}.tar.xz %if %{with lang} -Source1: https://download.kde.org/stable/plasma/%{version}/kwallet-pam-%{version}.tar.xz.sig +Source1: https://download.kde.org/stable/plasma/5.18.4/kwallet-pam-%{version}.tar.xz.sig Source2: plasma.keyring %endif Source3: baselibs.conf ++++++ kwallet-pam-5.18.3.tar.xz -> kwallet-pam-5.18.4.1.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kwallet-pam-5.18.3/CMakeLists.txt new/kwallet-pam-5.18.4.1/CMakeLists.txt --- old/kwallet-pam-5.18.3/CMakeLists.txt 2020-03-10 14:05:33.000000000 +0100 +++ new/kwallet-pam-5.18.4.1/CMakeLists.txt 2020-03-31 16:16:46.000000000 +0200 @@ -1,7 +1,7 @@ project(pam_kwallet) cmake_minimum_required(VERSION 2.8.12) set(KF5_MIN_VERSION "5.66.0") -set(PROJECT_VERSION "5.18.3") +set(PROJECT_VERSION "5.18.4") set(PROJECT_VERSION_MAJOR 5) find_package (ECM ${KF5_MIN_VERSION} REQUIRED NO_MODULE) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kwallet-pam-5.18.3/pam_kwallet.c new/kwallet-pam-5.18.4.1/pam_kwallet.c --- old/kwallet-pam-5.18.3/pam_kwallet.c 2020-03-10 14:05:33.000000000 +0100 +++ new/kwallet-pam-5.18.4.1/pam_kwallet.c 2020-03-31 16:16:46.000000000 +0200 @@ -310,18 +310,12 @@ return PAM_IGNORE; } - char *key = malloc(KWALLET_PAM_KEYSIZE); - if (!key || kwallet_hash(pamh, password, userInfo, key) != 0) { - free(key); - pam_syslog(pamh, LOG_ERR, "%s: Fail into creating the hash", logPrefix); - return PAM_IGNORE; - } - + char *key = strdup(password); result = pam_set_data(pamh, kwalletPamDataKey, key, cleanup_free); if (result != PAM_SUCCESS) { free(key); - pam_syslog(pamh, LOG_ERR, "%s: Impossible to store the hashed password: %s", logPrefix + pam_syslog(pamh, LOG_ERR, "%s: Impossible to store the password: %s", logPrefix , pam_strerror(pamh, result)); return PAM_IGNORE; } @@ -574,15 +568,22 @@ return PAM_IGNORE; } - const char *kwalletKey; - result = pam_get_data(pamh, kwalletPamDataKey, (const void **)&kwalletKey); + char *password; + result = pam_get_data(pamh, kwalletPamDataKey, (const void **)&password); if (result != PAM_SUCCESS) { pam_syslog(pamh, LOG_INFO, "%s: open_session called without %s", logPrefix, kwalletPamDataKey); return PAM_SUCCESS;//We will wait for pam_sm_authenticate } - start_kwallet(pamh, userInfo, kwalletKey); + char *key = malloc(KWALLET_PAM_KEYSIZE); + if (!key || kwallet_hash(pamh, password, userInfo, key) != 0) { + free(key); + pam_syslog(pamh, LOG_ERR, "%s: Fail into creating the hash", logPrefix); + return PAM_IGNORE; + } + + start_kwallet(pamh, userInfo, key); return PAM_SUCCESS; }
