Hello community, here is the log from the commit of package perl-Mojo-IOLoop-ReadWriteProcess for openSUSE:Factory checked in at 2020-04-11 23:46:59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Mojo-IOLoop-ReadWriteProcess (Old) and /work/SRC/openSUSE:Factory/.perl-Mojo-IOLoop-ReadWriteProcess.new.3248 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-Mojo-IOLoop-ReadWriteProcess" Sat Apr 11 23:46:59 2020 rev:9 rq:793056 version:0.25 Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Mojo-IOLoop-ReadWriteProcess/perl-Mojo-IOLoop-ReadWriteProcess.changes 2019-10-21 12:28:36.111974379 +0200 +++ /work/SRC/openSUSE:Factory/.perl-Mojo-IOLoop-ReadWriteProcess.new.3248/perl-Mojo-IOLoop-ReadWriteProcess.changes 2020-04-11 23:47:24.683128731 +0200 @@ -1,0 +2,10 @@ +Thu Apr 9 03:08:35 UTC 2020 - <timueller+p...@suse.de> + +- updated to 0.25 + see /usr/share/doc/packages/perl-Mojo-IOLoop-ReadWriteProcess/Changes + + 0.25 2020-04-08T14:48:01Z + - In "stop" sleep only after sending the first signal to speedup termination by okurz + - Various fixups in test suite + +------------------------------------------------------------------- Old: ---- Mojo-IOLoop-ReadWriteProcess-0.24.tar.gz New: ---- Mojo-IOLoop-ReadWriteProcess-0.25.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Mojo-IOLoop-ReadWriteProcess.spec ++++++ --- /var/tmp/diff_new_pack.EvZNkr/_old 2020-04-11 23:47:25.339129231 +0200 +++ /var/tmp/diff_new_pack.EvZNkr/_new 2020-04-11 23:47:25.339129231 +0200 @@ -1,7 +1,7 @@ # # spec file for package perl-Mojo-IOLoop-ReadWriteProcess # -# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: perl-Mojo-IOLoop-ReadWriteProcess -Version: 0.24 +Version: 0.25 Release: 0 %define cpan_name Mojo-IOLoop-ReadWriteProcess Summary: Execute external programs or internal code blocks as separate process @@ -43,16 +43,13 @@ %prep %setup -q -n %{cpan_name}-%{version} -find . -type f ! -path "*/t/*" ! -name "*.pl" ! -name "*.sh" -print0 | xargs -0 chmod 644 +find . -type f ! -path "*/t/*" ! -name "*.pl" ! -path "*/bin/*" ! -path "*/script/*" ! -name "configure" -print0 | xargs -0 chmod 644 %build perl Build.PL installdirs=vendor ./Build build flags=%{?_smp_mflags} %check -# https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess/issues/4 -# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939460 -rm t/10_cgroupv?.t ./Build test %install ++++++ Mojo-IOLoop-ReadWriteProcess-0.24.tar.gz -> Mojo-IOLoop-ReadWriteProcess-0.25.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/Changes new/Mojo-IOLoop-ReadWriteProcess-0.25/Changes --- old/Mojo-IOLoop-ReadWriteProcess-0.24/Changes 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/Changes 2020-04-08 16:51:25.000000000 +0200 @@ -1,5 +1,9 @@ Revision history for Perl extension Mojo-IOLoop-ReadWriteProcess +0.25 2020-04-08T14:48:01Z + - In "stop" sleep only after sending the first signal to speedup termination by okurz + - Various fixups in test suite + 0.24 2019-10-15T11:11:50Z - Fix compatibility with Mojolicious 8.23 by kraih diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/META.json new/Mojo-IOLoop-ReadWriteProcess-0.25/META.json --- old/Mojo-IOLoop-ReadWriteProcess-0.24/META.json 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/META.json 2020-04-08 16:51:25.000000000 +0200 @@ -4,7 +4,7 @@ "Ettore Di Giacinto <edigiaci...@suse.com>" ], "dynamic_config" : 0, - "generated_by" : "Minilla/v3.1.7", + "generated_by" : "Minilla/v3.1.2", "license" : [ "perl_5" ], @@ -36,7 +36,7 @@ "requires" : { "Test::CPAN::Meta" : "0", "Test::MinimumVersion::Fast" : "0.04", - "Test::PAUSE::Permissions" : "0.07", + "Test::PAUSE::Permissions" : "0.04", "Test::Pod" : "1.41", "Test::Spellunker" : "v0.2.7" } @@ -56,7 +56,7 @@ "provides" : { "Mojo::IOLoop::ReadWriteProcess" : { "file" : "lib/Mojo/IOLoop/ReadWriteProcess.pm", - "version" : "0.24" + "version" : "0.25" }, "Mojo::IOLoop::ReadWriteProcess::CGroup" : { "file" : "lib/Mojo/IOLoop/ReadWriteProcess/CGroup.pm" @@ -148,12 +148,14 @@ "web" : "https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess" } }, - "version" : "0.24", + "version" : "0.25", "x_contributors" : [ "Clemens Famulla-Conrad <cfamullacon...@suse.de>", "Ettore Di Giacinto <mud...@gentoo.org>", "Ettore Di Giacinto <mud...@users.noreply.github.com>", "Mohammad S Anwar <mohammad.an...@yahoo.com>", + "Oliver Kurz <ok...@suse.de>", + "Santiago Zarate <santiago+git...@zarate.co>", "Sebastian Riedel <s...@cpan.org>" ], "x_serialization_backend" : "JSON::PP version 2.97001", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/META.yml new/Mojo-IOLoop-ReadWriteProcess-0.25/META.yml --- old/Mojo-IOLoop-ReadWriteProcess-0.24/META.yml 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/META.yml 2020-04-08 16:51:25.000000000 +0200 @@ -8,7 +8,7 @@ Module::Build: '0.4005' perl: 5.008_001 dynamic_config: 0 -generated_by: 'Minilla/v3.1.7, CPAN::Meta::Converter version 2.150010' +generated_by: 'Minilla/v3.1.2, CPAN::Meta::Converter version 2.150010' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -27,7 +27,7 @@ provides: Mojo::IOLoop::ReadWriteProcess: file: lib/Mojo/IOLoop/ReadWriteProcess.pm - version: '0.24' + version: '0.25' Mojo::IOLoop::ReadWriteProcess::CGroup: file: lib/Mojo/IOLoop/ReadWriteProcess/CGroup.pm Mojo::IOLoop::ReadWriteProcess::CGroup::v1: @@ -87,12 +87,14 @@ bugtracker: https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess/issues homepage: https://github.com/mudler/Mojo-IOLoop-ReadWriteProcess repository: git://github.com/mudler/Mojo-IOLoop-ReadWriteProcess.git -version: '0.24' +version: '0.25' x_contributors: - 'Clemens Famulla-Conrad <cfamullacon...@suse.de>' - 'Ettore Di Giacinto <mud...@gentoo.org>' - 'Ettore Di Giacinto <mud...@users.noreply.github.com>' - 'Mohammad S Anwar <mohammad.an...@yahoo.com>' + - 'Oliver Kurz <ok...@suse.de>' + - 'Santiago Zarate <santiago+git...@zarate.co>' - 'Sebastian Riedel <s...@cpan.org>' x_serialization_backend: 'CPAN::Meta::YAML version 0.018' x_static_install: 0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/lib/Mojo/IOLoop/ReadWriteProcess.pm new/Mojo-IOLoop-ReadWriteProcess-0.25/lib/Mojo/IOLoop/ReadWriteProcess.pm --- old/Mojo-IOLoop-ReadWriteProcess-0.24/lib/Mojo/IOLoop/ReadWriteProcess.pm 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/lib/Mojo/IOLoop/ReadWriteProcess.pm 2020-04-08 16:51:25.000000000 +0200 @@ -1,6 +1,6 @@ package Mojo::IOLoop::ReadWriteProcess; -our $VERSION = '0.24'; +our $VERSION = '0.25'; use Mojo::Base 'Mojo::EventEmitter'; use Mojo::File 'path'; @@ -516,7 +516,6 @@ . ") to kill process: " . $self->pid) if DEBUG; - sleep $self->sleeptime_during_kill if $self->sleeptime_during_kill; $self->session->_protect( sub { local $?; @@ -525,6 +524,7 @@ $self->_status($?) if $ret == $self->process_id; }); $attempt++; + sleep $self->sleeptime_during_kill if $self->sleeptime_during_kill; } sleep $self->kill_sleeptime if $self->kill_sleeptime; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/t/01_run.t new/Mojo-IOLoop-ReadWriteProcess-0.25/t/01_run.t --- old/Mojo-IOLoop-ReadWriteProcess-0.24/t/01_run.t 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/t/01_run.t 2020-04-08 16:51:25.000000000 +0200 @@ -21,7 +21,7 @@ local *STDERR = $handle; $c->_diag("FOOTEST"); }; - like $buffer, qr/>> main::__ANON__\(\): FOOTEST/, + like $buffer, qr/>> main::__ANON__(.*\])*\(\): FOOTEST/, "diag() correct output format"; }; @@ -52,11 +52,9 @@ open STDERR, ">&", \*CHILD or die $!; print STDERR "FOOBARFTW\n" while 1; })->start(); - sleep 1; # Give chance to print some output - $p->stop(); - close(CHILD); - @output = <PARENT>; + @output = scalar <PARENT>; + $p->stop(); chomp @output; } is $output[0], "FOOBARFTW", 'right output'; @@ -76,10 +74,10 @@ }); $p->start(); + close(CHILD); + @output = scalar <PARENT>; $p->stop(); - close(CHILD); - @output = <PARENT>; close(PARENT); chomp @output; is $output[0], "FOOBARFTW", 'right output from process'; @@ -96,9 +94,9 @@ }); $p->restart()->restart()->restart(); is $p->is_running, 1, "Process now is running"; - $p->stop(); close(CHILD); - @output = <PARENT>; + @output = scalar <PARENT>; + $p->stop(); chomp @output; is $output[0], "FOOBAZFTW", 'right output from process'; is $p->is_running, 0, "Process now is not running"; @@ -108,16 +106,16 @@ $p->restart(); # Give time to the child to be up - my $attempts = 10; + my $attempts = 100; until ($p->is_running || $attempts == 0) { - sleep 1; + sleep .1; $attempts--; } is $p->is_running, 1, "Process now is running"; - $p->stop(); close(CHILD); - @output = <PARENT>; + @output = scalar <PARENT>; + $p->stop(); chomp @output; is $output[0], "FOOBAZFTW", 'right output from process'; }; @@ -184,7 +182,7 @@ is $p->getline, "TEST error print\n", 'Get STDERR output from stdout, always in getline()'; $p->stop(); - is $p->getline, "TEST normal print\n", + like $p->getline, qr/TEST (exiting|normal print)/, 'Still able to get stdout output, always in getline()'; my $p2 = Mojo::IOLoop::ReadWriteProcess->new( @@ -194,7 +192,6 @@ ); $p2->start(); is $p2->getline, undef, "pipes are correctly disabled"; - is $p2->getline, undef, "pipes are correctly disabled"; $p2->stop(); is !!$p2->_status, 1, 'take exit status even with set_pipes = 0 (we killed it)'; @@ -208,11 +205,9 @@ $p->start(); $p->stop(); is $p->is_running, 1, 'process is still running'; - like( - ${(@{$p->error})[0]}, qr/Could not kill process/, - 'Error is not empty if process could not be -killed' - ); + my $err = ${(@{$p->error})[0]}; + my $exp = qr/Could not kill process/; + like $err, $exp , 'Error is not empty if process could not be killed'; $p->max_kill_attempts(50); $p->blocking_stop(0); $p->stop(); @@ -221,7 +216,7 @@ $p->max_kill_attempts(5); $p->stop; $p->wait; - is $p->is_running, 0, 'process is shutten down'; + is $p->is_running, 0, 'process is shut down'; is $p->errored, 1, 'Process died and errored'; @@ -232,10 +227,9 @@ execute => $test_script, max_kill_attempts => -1 # ;) )->start()->stop(); - sleep 4; is $p->is_running, 0, - 'process is shutten down by kill signal when "blocking_stop => 1"'; + 'process is shut down by kill signal when "blocking_stop => 1"'; my $pidfile = tempfile; $p = Mojo::IOLoop::ReadWriteProcess->new( @@ -306,11 +300,10 @@ is(IO::Select->new($p->read_stream)->can_read(10), 1, 'can read from stdout handle'); is $p->getline, "Enter something : you entered FOOBAR\n", 'can read output'; - $p->stop(); - is $p->channel_out->getline, "FOOBARftw\n", "can read from internal channel"; is $p->channel_read_handle->getline, "PONG\n", "can read from internal channel"; + $p->stop(); is $p->is_running, 0, 'process is not running'; $p->restart(); @@ -413,7 +406,6 @@ print STDERR "TEST error print\n" for (1 .. 6); my $a = <STDIN>; })->start(); - sleep 1; like $p->stderr_all, qr/TEST error print/, 'read all from stderr, is like reading all from stdout when separate_err = 0'; $p->stop()->separate_err(1)->start(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Mojo-IOLoop-ReadWriteProcess-0.24/t/data/process_check.sh new/Mojo-IOLoop-ReadWriteProcess-0.25/t/data/process_check.sh --- old/Mojo-IOLoop-ReadWriteProcess-0.24/t/data/process_check.sh 2019-10-15 13:15:23.000000000 +0200 +++ new/Mojo-IOLoop-ReadWriteProcess-0.25/t/data/process_check.sh 2020-04-08 16:51:25.000000000 +0200 @@ -1,5 +1,11 @@ #!/bin/bash +cleanup() { + echo "TEST exiting" +} + +trap cleanup EXIT + (>&2 echo "TEST error print") echo "TEST normal print"