Hello community,
here is the log from the commit of package qactus for openSUSE:Factory checked
in at 2020-05-05 18:55:48
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/qactus (Old)
and /work/SRC/openSUSE:Factory/.qactus.new.2738 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "qactus"
Tue May 5 18:55:48 2020 rev:7 rq:800167 version:2.0.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/qactus/qactus.changes 2020-04-21
13:07:52.392477928 +0200
+++ /work/SRC/openSUSE:Factory/.qactus.new.2738/qactus.changes 2020-05-05
18:55:54.565479764 +0200
@@ -1,0 +2,8 @@
+Mon May 4 19:42:47 UTC 2020 - Javier Llorente <jav...@opensuse.org>
+
+- Update to 2.0.1
+ * RequestStateEditor bugfixes:
+ - get the full diff for the selected request
+ - use the right OBS signal finishedParsingRequestStatus()
+
+-------------------------------------------------------------------
Old:
----
qactus-2.0.0.tar.gz
New:
----
qactus-2.0.1.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ qactus.spec ++++++
--- /var/tmp/diff_new_pack.ya3guN/_old 2020-05-05 18:55:55.453481676 +0200
+++ /var/tmp/diff_new_pack.ya3guN/_new 2020-05-05 18:55:55.453481676 +0200
@@ -23,7 +23,7 @@
%global devname %{libprefix}-devel
Name: qactus
-Version: 2.0.0
+Version: 2.0.1
Release: 0
Summary: A GUI client for OBS
License: GPL-2.0-only OR GPL-3.0-only
++++++ qactus-2.0.0.tar.gz -> qactus-2.0.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/CMakeLists.txt
new/qactus-2.0.1/CMakeLists.txt
--- old/qactus-2.0.0/CMakeLists.txt 2020-04-20 10:28:13.000000000 +0200
+++ new/qactus-2.0.1/CMakeLists.txt 2020-05-04 20:28:16.000000000 +0200
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.5)
project(Qactus
- VERSION 2.0.0
+ VERSION 2.0.1
LANGUAGES CXX)
add_definitions(-DQACTUS_VERSION="${PROJECT_VERSION}")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/ChangeLog new/qactus-2.0.1/ChangeLog
--- old/qactus-2.0.0/ChangeLog 2020-04-20 10:28:13.000000000 +0200
+++ new/qactus-2.0.1/ChangeLog 2020-05-04 20:28:16.000000000 +0200
@@ -1,5 +1,10 @@
Qactus ChangeLog
================
+v2.0.1 (2020-05-04)
+- RequestStateEditor bugfixes:
+ * get the full diff for the selected request
+ * use the right OBS signal finishedParsingRequestStatus()
+
v2.0.0 (2020-04-20)
libqobs:
Binary files old/qactus-2.0.0/Qactus_screenshot.png and
new/qactus-2.0.1/Qactus_screenshot.png differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/README.md new/qactus-2.0.1/README.md
--- old/qactus-2.0.0/README.md 2020-04-20 10:28:13.000000000 +0200
+++ new/qactus-2.0.1/README.md 2020-05-04 20:28:16.000000000 +0200
@@ -10,6 +10,8 @@
This project was originally hosted on Nokia Developer Projects until 2013,
when the service was discontinued.
+
+
Installation
------------
RPM packages are available at http://software.opensuse.org/package/qactus
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/qactus.spec new/qactus-2.0.1/qactus.spec
--- old/qactus-2.0.0/qactus.spec 2020-04-20 10:28:13.000000000 +0200
+++ new/qactus-2.0.1/qactus.spec 2020-05-04 20:28:16.000000000 +0200
@@ -22,7 +22,7 @@
%global devname %{libprefix}-devel
Name: qactus
-Version: 2.0.0
+Version: 2.0.1
Release: 0
Summary: A GUI client for OBS
License: GPL-2.0 or GPL-3.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.cpp
new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.cpp
--- old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.cpp 2020-04-20
10:28:13.000000000 +0200
+++ new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.cpp 2020-05-04
20:28:16.000000000 +0200
@@ -1,7 +1,7 @@
/*
* Qactus - A Qt-based OBS client
*
- * Copyright (C) 2015-2019 Javier Llorente <jav...@opensuse.org>
+ * Copyright (C) 2015-2020 Javier Llorente <jav...@opensuse.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -43,13 +43,13 @@
ui->dateLabelText->setText(m_request->getDate());
connect(this, SIGNAL(changeSubmitRequest(QString,QString,bool)), m_obs,
SLOT(slotChangeSubmitRequest(QString,QString,bool)));
- connect(m_obs, SIGNAL(srStatus(QString)), this,
SLOT(slotSrStatus(QString)));
+ connect(m_obs, &OBS::finishedParsingRequestStatus, this,
&RequestStateEditor::slotRequestStatusFetched);
connect(m_obs, SIGNAL(srDiffFetched(QString)), this,
SLOT(slotSrDiffFetched(QString)));
connect(m_obs, SIGNAL(finishedParsingResult(OBSResult*)), this,
SLOT(slotAddBuildResults(OBSResult*)));
if (m_request->getActionType()=="submit") {
// Get SR diff
- m_obs->getRequestDiff(m_request->getSource());
+ m_obs->getRequestDiff(m_request->getId());
// Setup build results tree view
QStandardItemModel *sourceModelBuildResults = new
QStandardItemModel(ui->treeBuildResults);
@@ -111,15 +111,16 @@
emit changeSubmitRequest(m_request->getId(),
ui->commentsTextBrowser->toPlainText(), false);
}
-void RequestStateEditor::slotSrStatus(const QString &status)
+void RequestStateEditor::slotRequestStatusFetched(OBSStatus *status)
{
- qDebug() << "RequestStateEditor::slotSrStatus" << status;
+ qDebug() << __PRETTY_FUNCTION__ << status->getCode();
QString errorStr = tr("Error changing SR!");
- if (status == "ok") {
+ if (status->getCode() == "ok") {
close();
} else {
- QMessageBox::critical(this, errorStr, status, QMessageBox::Ok);
+ QMessageBox::critical(this, errorStr, status->getCode(),
QMessageBox::Ok);
}
+ delete status;
}
void RequestStateEditor::slotSrDiffFetched(const QString &diff)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.h
new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.h
--- old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.h 2020-04-20
10:28:13.000000000 +0200
+++ new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.h 2020-05-04
20:28:16.000000000 +0200
@@ -1,7 +1,7 @@
/*
* Qactus - A Qt-based OBS client
*
- * Copyright (C) 2015-2019 Javier Llorente <jav...@opensuse.org>
+ * Copyright (C) 2015-2020 Javier Llorente <jav...@opensuse.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -51,7 +51,7 @@
private slots:
void on_acceptPushButton_clicked();
void on_declinePushButton_clicked();
- void slotSrStatus(const QString &status);
+ void slotRequestStatusFetched(OBSStatus *status);
void slotSrDiffFetched(const QString &diff);
void slotAddBuildResults(OBSResult *obsResult);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.ui
new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.ui
--- old/qactus-2.0.0/src/gui/requestbox/requeststateeditor.ui 2020-04-20
10:28:13.000000000 +0200
+++ new/qactus-2.0.1/src/gui/requestbox/requeststateeditor.ui 2020-05-04
20:28:16.000000000 +0200
@@ -6,8 +6,8 @@
<rect>
<x>0</x>
<y>0</y>
- <width>600</width>
- <height>550</height>
+ <width>800</width>
+ <height>800</height>
</rect>
</property>
<property name="windowTitle">
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qactus-2.0.0/src/qobs/obs.cpp
new/qactus-2.0.1/src/qobs/obs.cpp
--- old/qactus-2.0.0/src/qobs/obs.cpp 2020-04-20 10:28:13.000000000 +0200
+++ new/qactus-2.0.1/src/qobs/obs.cpp 2020-05-04 20:28:16.000000000 +0200
@@ -225,9 +225,8 @@
void OBS::getRequestDiff(const QString &source)
{
- qDebug() << "OBS::getRequestDiff()";
- QString resource =
QString("/source/%1?unified=1&tarlimit=0&cmd=diff&filelimit=0&expand=1")
- .arg(source);
+ qDebug() << __PRETTY_FUNCTION__;
+ QString resource = QString("/request/%1?cmd=diff").arg(source);
obsCore->getSRDiff(resource);
}
