Hello community, here is the log from the commit of package gtk-sharp3 for openSUSE:Leap:15.2 checked in at 2020-05-14 16:58:21 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/gtk-sharp3 (Old) and /work/SRC/openSUSE:Leap:15.2/.gtk-sharp3.new.2738 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gtk-sharp3" Thu May 14 16:58:21 2020 rev:17 rq:805529 version:2.99.4 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/gtk-sharp3/gtk-sharp3.changes 2020-01-15 15:09:30.518041921 +0100 +++ /work/SRC/openSUSE:Leap:15.2/.gtk-sharp3.new.2738/gtk-sharp3.changes 2020-05-14 16:58:26.474779102 +0200 @@ -1,0 +2,12 @@ +Fri Apr 10 22:21:38 UTC 2020 - Michael Gorse <mgo...@suse.com> + +- Add cs8-build-fix.patch: fix build failure caused by C# 8 + changes in mcs. + +------------------------------------------------------------------- +Mon Jun 11 19:05:39 UTC 2018 - bjorn....@gmail.com + +- Drop pkgconfig(vte) BuildRequires: No longer needed, nor used. +- Run spec-cleaner, modernize spec file. + +------------------------------------------------------------------- New: ---- cs8-build-fix.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gtk-sharp3.spec ++++++ --- /var/tmp/diff_new_pack.86on9y/_old 2020-05-14 16:58:26.786779699 +0200 +++ /var/tmp/diff_new_pack.86on9y/_new 2020-05-14 16:58:26.790779707 +0200 @@ -1,7 +1,7 @@ # # spec file for package gtk-sharp3 # -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,34 +12,32 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # %define vsuffix git.2017.01.16.9ef7d3f39 - Name: gtk-sharp3 # package "libmono-profiler-gui-thread-check0-devel" does not allow us to add even a single symbol to version string without invoking rpmlint warning "W: filename-too-long-for-joliet" Version: 2.99.4 Release: 0 Summary: C-Sharp Language Bindings for GTK+ -License: GPL-2.0 +License: GPL-2.0-only Group: System/GUI/GNOME -Url: https://github.com/mono/gtk-sharp +URL: https://github.com/mono/gtk-sharp Source: gtk-sharp3-%{vsuffix}.tar.xz Source99: create-source-archive.sh Patch1: profiler-update.patch +Patch2: cs8-build-fix.patch BuildRequires: gtkhtml2-devel BuildRequires: libmono-2_0-devel BuildRequires: librsvg-devel BuildRequires: libtool BuildRequires: mono-devel BuildRequires: monodoc-core -BuildRequires: pkg-config +BuildRequires: pkgconfig BuildRequires: update-desktop-files -BuildRequires: pkgconfig(vte) Requires: mono-core -BuildRoot: %{_tmppath}/%{name}-%{version}-build %description This package contains C-Sharp bindings for Gtk+, Gdk, Atk, and Pango. @@ -47,7 +45,7 @@ %package devel Summary: .NET/C-Sharp Bindings for GIO -License: LGPL-2.1 +License: LGPL-2.1-only Group: Development/Languages/Mono Requires: gtk-sharp3 = %{version} @@ -56,7 +54,7 @@ %package gapi Summary: C Source Parser and C Generator -License: GPL-2.0 +License: GPL-2.0-only Group: System/GUI/GNOME Requires: perl-XML-LibXML Requires: perl-XML-LibXML-Common @@ -69,7 +67,7 @@ %package -n gtk-sharp3-gapi-devel Summary: .NET/C-Sharp Bindings for GIO -License: LGPL-2.1 +License: LGPL-2.1-only Group: Development/Languages/Mono Requires: gtk-sharp3-gapi = %{version} @@ -78,7 +76,7 @@ %package -n gtk-sharp3-doc Summary: Monodoc documentation for gtk-sharp2 -License: LGPL-2.1 +License: LGPL-2.1-only Group: System/GUI/GNOME %description -n gtk-sharp3-doc @@ -86,7 +84,7 @@ %package -n glib-sharp3 Summary: Mono bindings for glib -License: LGPL-2.1 +License: LGPL-2.1-only Group: System/GUI/GNOME %description -n glib-sharp3 @@ -94,7 +92,7 @@ %package -n gio-sharp3 Summary: Mono bindings for gio -License: LGPL-2.1 +License: LGPL-2.1-only Group: System/GUI/GNOME %description -n gio-sharp3 @@ -102,7 +100,7 @@ %package -n gio-sharp3-devel Summary: .NET/C-Sharp Bindings for GIO -License: LGPL-2.1 +License: LGPL-2.1-only Group: Development/Languages/Mono Requires: gio-sharp3 = %{version} @@ -111,7 +109,7 @@ %package -n libmono-profiler-gui-thread-check0 Summary: Profiler for gtk-sharp3 -License: GPL-2.0 +License: GPL-2.0-only Group: Development/Languages/Mono %description -n libmono-profiler-gui-thread-check0 @@ -119,12 +117,11 @@ part of the install for debugging purposes. %post -n libmono-profiler-gui-thread-check0 -p /sbin/ldconfig - %postun -n libmono-profiler-gui-thread-check0 -p /sbin/ldconfig %package -n libmono-profiler-gui-thread-check0-devel Summary: Profiler for gtk-sharp3 -License: GPL-2.0 +License: GPL-2.0-only Group: Development/Languages/Mono Requires: libmono-profiler-gui-thread-check0 = %{version} @@ -134,7 +131,7 @@ %package -n gtk-sharp3-complete Summary: GTK+ and GNOME bindings for Mono (virtual package) -License: LGPL-2.1 +License: LGPL-2.1-only Group: System/GUI/GNOME Requires: glib-sharp3 = %{version} Requires: gtk-sharp3 = %{version} @@ -151,6 +148,7 @@ %prep %setup -q -n gtk-sharp3-%{vsuffix} %patch1 -p1 +%patch2 -p1 NOCONFIGURE=1 ./autogen.sh %build @@ -163,11 +161,9 @@ rm %{buildroot}%{_libdir}/*.*a %post -p /sbin/ldconfig - %postun -p /sbin/ldconfig %files -%defattr(-, root, root) %{_libdir}/libatksharpglue-3.so %{_libdir}/libgtksharpglue-3.so %{_libdir}/libgiosharpglue-3.so @@ -186,14 +182,12 @@ %{_libexecdir}/mono/gac/pango-sharp/ %files devel -%defattr(-, root, root) %{_libdir}/pkgconfig/gtk-sharp-3.0.pc %{_libdir}/pkgconfig/gdk-sharp-3.0.pc %{_libdir}/pkgconfig/gtk-dotnet-3.0.pc %{_libdir}/pkgconfig/glib-sharp-3.0.pc %files gapi -%defattr(-, root, root) %dir %{_libexecdir}/gapi-3.0 %{_bindir}/gapi3-codegen %{_bindir}/gapi3-fixup @@ -206,38 +200,31 @@ %{_libexecdir}/gapi-3.0/gapi2xml.pl %files -n gtk-sharp3-gapi-devel -%defattr(-, root, root) %{_libdir}/pkgconfig/gapi-3.0.pc %files -n gtk-sharp3-doc -%defattr(-, root, root) -%doc COPYING README +%license COPYING +%doc README %{_libexecdir}/monodoc %files -n glib-sharp3 -%defattr(-, root, root) %{_libexecdir}/mono/gac/glib-sharp/ %{_libexecdir}/mono/gtk-sharp-3.0/glib-sharp.dll %files -n gio-sharp3 -%defattr(-, root, root) %{_libexecdir}/mono/gac/gio-sharp/ %{_libexecdir}/mono/gtk-sharp-3.0/gio-sharp.dll %files -n gio-sharp3-devel -%defattr(-, root, root) %{_libdir}/pkgconfig/gio-sharp-3.0.pc %files -n libmono-profiler-gui-thread-check0 -%defattr(-, root, root) %{_libdir}/libmono-profiler-gui-thread-check.so.* %files -n libmono-profiler-gui-thread-check0-devel -%defattr(-, root, root) %{_libdir}/libmono-profiler-gui-thread-check.so %files -n gtk-sharp3-complete -%defattr(-, root, root) %dir %{_libexecdir}/mono/gtk-sharp-3.0 %changelog ++++++ cs8-build-fix.patch ++++++ >From a00552ad68ae349e89e440dca21b86dbd6bccd30 Mon Sep 17 00:00:00 2001 From: Ankit Jain <radi...@gmail.com> Date: Tue, 19 Feb 2019 23:53:27 -0500 Subject: [PATCH] Fix build failure with mcs caused by C#8 changes in mcs (#263) Recent addition of C#8 features to mcs possibly broke this: ``` mcs -out:WidgetViewer.exe -r:../../glib/glib-sharp.dll -r:../../pango/pango-sharp.dll -r:../../atk/atk-sharp.dll -r:../../gdk/gdk-sharp.dll -r:../../gtk/gtk-sharp.dll ./TestCheckButton.cs ./TestColorSelection.cs ./TestRadioButton.cs ./TestRange.cs ./TestStatusbar.cs ./TestDialog.cs ./TestFlipping.cs ./TestSizeGroup.cs ./TestCombo.cs ./TestComboBox.cs ./WidgetViewer.cs ./TestCombo.cs(17,14): warning CS0612: `Gtk.Combo' is obsolete ./TestRange.cs(35,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(35,13): error CS0030: Cannot convert type `Gtk.HScale' to `System.Range' ./TestRange.cs(42,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(42,13): error CS0030: Cannot convert type `Gtk.HScrollbar' to `System.Range' ./TestRange.cs(62,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(62,13): error CS0030: Cannot convert type `Gtk.VScale' to `System.Range' ``` This is because the compiler is resolving `Range` in the test as `System.Range` instead of `Gtk.Range`, so we disambiguate it. /cc @marek-safar --- sample/test/TestRange.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sample/test/TestRange.cs b/sample/test/TestRange.cs index 35fc8a6dd..d44a77d85 100644 --- a/sample/test/TestRange.cs +++ b/sample/test/TestRange.cs @@ -9,6 +9,8 @@ using System; using Gtk; +// disambiguate, Gtk.Range vs System.Range +using Range=Gtk.Range; namespace WidgetViewer { -- 2.26.0
