Hello community, here is the log from the commit of package ksystemlog for openSUSE:Leap:15.2 checked in at 2020-05-31 13:45:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Leap:15.2/ksystemlog (Old) and /work/SRC/openSUSE:Leap:15.2/.ksystemlog.new.3606 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ksystemlog" Sun May 31 13:45:43 2020 rev:45 rq:809904 version:20.04.1 Changes: -------- --- /work/SRC/openSUSE:Leap:15.2/ksystemlog/ksystemlog.changes 2020-05-25 13:42:23.363371962 +0200 +++ /work/SRC/openSUSE:Leap:15.2/.ksystemlog.new.3606/ksystemlog.changes 2020-05-31 13:46:12.633764821 +0200 @@ -1,0 +2,7 @@ +Wed May 27 09:56:54 UTC 2020 - Wolfgang Bauer <wba...@tmo.at> + +- Add patch to fix a possible crash when closing the window: + (boo#1164633, kde#409375) + * Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch + +------------------------------------------------------------------- New: ---- Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ksystemlog.spec ++++++ --- /var/tmp/diff_new_pack.0689NW/_old 2020-05-31 13:46:13.033766059 +0200 +++ /var/tmp/diff_new_pack.0689NW/_new 2020-05-31 13:46:13.037766071 +0200 @@ -28,6 +28,8 @@ Group: System/Monitoring URL: https://www.kde.org Source: https://download.kde.org/stable/release-service/%{version}/src/%{name}-%{version}.tar.xz +# PATCH-FIX-UPSTREAM +Patch: Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch BuildRequires: extra-cmake-modules BuildRequires: oxygen5-icon-theme-large BuildRequires: pkgconfig @@ -57,6 +59,7 @@ %prep %setup -q +%autopatch -p1 %build %cmake_kf5 -d build ++++++ Disconnect-QtabWidget_currentChanged-signal-on-window-close.patch ++++++ >From eeab31a116535efc6d4757f027897265736ed161 Mon Sep 17 00:00:00 2001 From: Wolfgang Bauer <wba...@tmo.at> Date: Sun, 17 May 2020 20:22:45 +0000 Subject: Disconnect `QtabWidget::currentChanged` signal on window close event Otherwise `MainWindow::changeCurrentTab()` may still get called when things are already being destroyed, leading to crashes. BUG: 409375 FIXED-IN: 20.04.2 --- src/mainWindow.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mainWindow.cpp b/src/mainWindow.cpp index 3607f6c..a30449c 100644 --- a/src/mainWindow.cpp +++ b/src/mainWindow.cpp @@ -350,6 +350,8 @@ void MainWindow::updateReloading() void MainWindow::closeEvent(QCloseEvent *event) { + disconnect(d->tabs, &QTabWidget::currentChanged, this, &MainWindow::changeCurrentTab); + LogManager *currentLogManager = d->tabs->activeLogManager(); if (currentLogManager) { currentLogManager->stopWatching(); -- cgit v1.1
