Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2020-07-03 00:44:11 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new.3060 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Fri Jul 3 00:44:11 2020 rev:427 rq:818067 version:4.3.11 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2020-06-27 23:22:14.797756462 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-network.new.3060/yast2-network.changes 2020-07-03 00:44:14.969907803 +0200 @@ -1,0 +2,8 @@ +Wed Jul 01 08:52:44 UTC 2020 - Knut Anderssen <kanders...@suse.com> + +- Do not remove automatically aliases from /etc/hosts during an + autoinstallation (bsc#1173213) +- Parse correctly udev rules keys using underscores (bsc#1167256) +- 4.3.11 + +------------------------------------------------------------------- Old: ---- yast2-network-4.3.10.tar.bz2 New: ---- yast2-network-4.3.11.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.rinXV4/_old 2020-07-03 00:44:15.749910189 +0200 +++ /var/tmp/diff_new_pack.rinXV4/_new 2020-07-03 00:44:15.753910201 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.3.10 +Version: 4.3.11 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only ++++++ yast2-network-4.3.10.tar.bz2 -> yast2-network-4.3.11.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/package/yast2-network.changes new/yast2-network-4.3.11/package/yast2-network.changes --- old/yast2-network-4.3.10/package/yast2-network.changes 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/package/yast2-network.changes 2020-07-01 11:51:00.000000000 +0200 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Wed Jul 01 08:52:44 UTC 2020 - Knut Anderssen <kanders...@suse.com> + +- Do not remove automatically aliases from /etc/hosts during an + autoinstallation (bsc#1173213) +- Parse correctly udev rules keys using underscores (bsc#1167256) +- 4.3.11 + +------------------------------------------------------------------- Fri Jun 26 08:00:33 UTC 2020 - Knut Anderssen <kanders...@suse.com> - AutoYaST schema: add the setup_before_proposal element to the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/package/yast2-network.spec new/yast2-network-4.3.11/package/yast2-network.spec --- old/yast2-network-4.3.10/package/yast2-network.spec 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/package/yast2-network.spec 2020-07-01 11:51:00.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.3.10 +Version: 4.3.11 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/src/lib/y2network/sysconfig/connection_config_writer.rb new/yast2-network-4.3.11/src/lib/y2network/sysconfig/connection_config_writer.rb --- old/yast2-network-4.3.10/src/lib/y2network/sysconfig/connection_config_writer.rb 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/src/lib/y2network/sysconfig/connection_config_writer.rb 2020-07-01 11:51:00.000000000 +0200 @@ -21,6 +21,7 @@ require "y2network/sysconfig/routes_file" Yast.import "Host" +Yast.import "Mode" module Y2Network module Sysconfig @@ -53,7 +54,10 @@ def remove(conn) ifcfg = Y2Network::Sysconfig::InterfaceFile.find(conn.interface) ifcfg&.remove - Yast::Host.remove_ip(conn.ip.address.address.to_s) if conn.ip + # During an autoinstallation do not remove /etc/hosts entries + # associated with the static IP address (bsc#1173213). + # The hook or original behavior was introduced because of (bsc#951330) + Yast::Host.remove_ip(conn.ip.address.address.to_s) if !Yast::Mode.auto && conn.ip end private diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/src/lib/y2network/udev_rule_part.rb new/yast2-network-4.3.11/src/lib/y2network/udev_rule_part.rb --- old/yast2-network-4.3.10/src/lib/y2network/udev_rule_part.rb 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/src/lib/y2network/udev_rule_part.rb 2020-07-01 11:51:00.000000000 +0200 @@ -27,7 +27,7 @@ class UdevRulePart include Yast::Logger # Regular expression to match a udev rule part - PART_REGEXP = Regexp.new("\\A(?<key>[A-Za-z\{\}]+)(?<operator>[^\"]+)\"(?<value>.+)\"\\Z") + PART_REGEXP = Regexp.new("\\A(?<key>[A-Za-z\{\}_]+)(?<operator>[^\"]+)\"(?<value>.+)\"\\Z") class << self # Returns a rule part from a string diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/test/y2network/sysconfig/connection_config_writer_test.rb new/yast2-network-4.3.11/test/y2network/sysconfig/connection_config_writer_test.rb --- old/yast2-network-4.3.10/test/y2network/sysconfig/connection_config_writer_test.rb 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/test/y2network/sysconfig/connection_config_writer_test.rb 2020-07-01 11:51:00.000000000 +0200 @@ -93,8 +93,10 @@ end describe "#remove" do + let(:autoinstallation) { false } before do allow(Y2Network::Sysconfig::InterfaceFile).to receive(:find).and_return(file) + allow(Yast::Mode).to receive(:auto).and_return(autoinstallation) end it "removes the configuration file" do @@ -112,6 +114,15 @@ it "does not try to remove the hostname" do expect(Yast::Host).to_not receive(:remove_ip) + writer.remove(conn) + end + end + + context "during an autoinstallation" do + let(:autoinstallation) { true } + + it "does not try to remove the hostname" do + expect(Yast::Host).to_not receive(:remove_ip) writer.remove(conn) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.3.10/test/y2network/udev_rule_part_test.rb new/yast2-network-4.3.11/test/y2network/udev_rule_part_test.rb --- old/yast2-network-4.3.10/test/y2network/udev_rule_part_test.rb 2020-06-26 10:09:04.000000000 +0200 +++ new/yast2-network-4.3.11/test/y2network/udev_rule_part_test.rb 2020-07-01 11:51:00.000000000 +0200 @@ -33,6 +33,11 @@ expect(part.key).to eq("ACTION") expect(part.operator).to eq("==") expect(part.value).to eq("add") + + part = described_class.from_string("ATTR{dev_id}==\"0x0\"") + expect(part.key).to eq("ATTR{dev_id}") + expect(part.operator).to eq("==") + expect(part.value).to eq("0x0") end it "returns nil in case of an invalid udev rule" do