Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2020-09-12 00:07:48 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.4249 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Sat Sep 12 00:07:48 2020 rev:208 rq:833580 version:2.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2020-08-06 10:39:38.466045539 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.4249/virt-manager.changes 2020-09-12 00:08:02.108957075 +0200 @@ -1,0 +2,18 @@ +Thu Sep 3 13:59:39 MDT 2020 - carn...@suse.com + +- bsc#1176080 - selecting one UEFI firmware in install wizard + resets UI to BIOS + e8bf16b9-details-fix-detection-of-firmware-auto-selection.patch +- Upstream bug fix (bsc#1027942) + 5573aeb4-createnet-Fix-XML-editor-error-when-dhcp-fields-are-empty.patch + 7e3fb3f2-graphics-Default-to-vga-instead-of-qxl-for-non-spice.patch + +------------------------------------------------------------------- +Wed Sep 2 11:42:02 MDT 2020 - carn...@suse.com + +- jsc#SLE-11773, Dev: virt-manager: AppIndicator3 + virt-manager.spec +- jsc#SLE-15926 - Dev: XEN: drop netware support + Drop virtman-keycombo.patch + +------------------------------------------------------------------- Old: ---- virtman-keycombo.patch New: ---- 5573aeb4-createnet-Fix-XML-editor-error-when-dhcp-fields-are-empty.patch 7e3fb3f2-graphics-Default-to-vga-instead-of-qxl-for-non-spice.patch e8bf16b9-details-fix-detection-of-firmware-auto-selection.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.u0Qgaf/_old 2020-09-12 00:08:05.544960363 +0200 +++ /var/tmp/diff_new_pack.u0Qgaf/_new 2020-09-12 00:08:05.548960367 +0200 @@ -1,7 +1,7 @@ # # spec file for package virt-manager # -# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2020 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # @@ -26,7 +26,7 @@ Summary: Virtual Machine Manager License: GPL-2.0-or-later Group: System/Monitoring -Url: http://virt-manager.org/ +URL: http://virt-manager.org/ Source0: %{name}-%{version}.tar.bz2 Source1: virt-install.rb Source2: virt-install.desktop @@ -48,16 +48,18 @@ Patch14: d934d6f2-domcaps-Fix-check-for-uncached-security-features.patch Patch15: 29f9f5f2-virt-xml-fix-defined_xml_is_unchanged.patch Patch16: 15a9502b-Fix-showing-the-firmware-type-in-case-of-firmware-auto-selection.patch +Patch17: 5573aeb4-createnet-Fix-XML-editor-error-when-dhcp-fields-are-empty.patch +Patch18: e8bf16b9-details-fix-detection-of-firmware-auto-selection.patch +Patch19: 7e3fb3f2-graphics-Default-to-vga-instead-of-qxl-for-non-spice.patch # SUSE Only Patch70: virtman-desktop.patch Patch71: virtman-kvm.patch -Patch72: virtman-keycombo.patch -Patch73: virtman-show-suse-install-repos.patch -Patch74: virtman-dont-allow-grub.xen-to-be-deleted.patch -Patch75: virtinst-pvgrub2-bootloader.patch -Patch76: virtinst-change-location-for-grub_xen.patch -Patch77: virtman-fix-env-script-interpreter.patch -Patch78: virtinst-set-qemu-emulator.patch +Patch72: virtman-show-suse-install-repos.patch +Patch73: virtman-dont-allow-grub.xen-to-be-deleted.patch +Patch74: virtinst-pvgrub2-bootloader.patch +Patch75: virtinst-change-location-for-grub_xen.patch +Patch76: virtman-fix-env-script-interpreter.patch +Patch77: virtinst-set-qemu-emulator.patch # Features or Enhancements Patch103: virtman-load-stored-uris.patch Patch120: virtinst-default-xen-to-qcow2-format.patch @@ -147,13 +149,10 @@ Requires: python3-libvirt-python >= 0.7.0 Requires: python3-libxml2-python Requires: python3-pycurl +Requires: typelib(AppIndicator3) Requires: typelib(LibvirtGLib) Suggests: python3-virt-bootstrap BuildRequires: gobject-introspection -# No AppIndicator package on SLE -%if 0%{?is_opensuse} == 0 -%define __requires_exclude typelib\\(AppIndicator3\\) -%endif %description common Common files used by the different virt-manager interfaces, as well as @@ -198,6 +197,9 @@ %patch14 -p1 %patch15 -p1 %patch16 -p1 +%patch17 -p1 +%patch18 -p1 +%patch19 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 @@ -207,7 +209,6 @@ %patch75 -p1 %patch76 -p1 %patch77 -p1 -%patch78 -p1 # Enhancements %patch103 -p1 %patch120 -p1 ++++++ 5573aeb4-createnet-Fix-XML-editor-error-when-dhcp-fields-are-empty.patch ++++++ Subject: createnet: Fix XML editor error when dhcp fields are empty From: Cole Robinson crobi...@redhat.com Wed Jan 29 18:43:58 2020 -0500 Date: Wed Jan 29 18:53:31 2020 -0500: Git: 5573aeb44100bcabdc24ab1cd19ec96bb4cb9d62 We need to handle the case when ip == None https://bugzilla.redhat.com/show_bug.cgi?id=1726586 Signed-off-by: Cole Robinson <crobi...@redhat.com> --- virt-manager-2.2.1.orig/virtManager/createnet.py +++ virt-manager-2.2.1/virtManager/createnet.py @@ -414,31 +414,35 @@ class vmmCreateNetwork(vmmGObjectUI): if self.get_config_ipv4_enable(): ip = self.get_config_ip4() ipobj = net.ips.add_new() - ipobj.address = str(ip.network_address + 1) - ipobj.netmask = str(ip.netmask) + if ip: + ipobj.address = str(ip.network_address + 1) + ipobj.netmask = str(ip.netmask) if self.get_config_dhcpv4_enable(): dhcpobj = ipobj.ranges.add_new() - dhcpobj.start = str( - self.get_config_dhcpv4_start().network_address - ) - dhcpobj.end = str(self.get_config_dhcpv4_end().network_address) + start = self.get_config_dhcpv4_start() + end = self.get_config_dhcpv4_end() + if start: + dhcpobj.start = str(start.network_address) + if end: + dhcpobj.end = str(end.network_address) if self.get_config_ipv6_enable(): ip = self.get_config_ip6() ipobj = net.ips.add_new() ipobj.family = "ipv6" - ipobj.address = str(ip.network_address + 1) - ipobj.prefix = str(ip.prefixlen) + if ip: + ipobj.address = str(ip.network_address + 1) + ipobj.prefix = str(ip.prefixlen) if self.get_config_dhcpv6_enable(): dhcpobj = ipobj.ranges.add_new() - dhcpobj.start = str( - self.get_config_dhcpv6_start().network_address - ) - dhcpobj.end = str( - self.get_config_dhcpv6_end().network_address - ) + start = self.get_config_dhcpv6_start() + end = self.get_config_dhcpv6_end() + if start: + dhcpobj.start = str(start.network_address) + if end: + dhcpobj.end = str(end.network_address) return net ++++++ 7e3fb3f2-graphics-Default-to-vga-instead-of-qxl-for-non-spice.patch ++++++ Subject: graphics: Default to 'vga' instead of 'qxl' for non-spice From: Cole Robinson crobi...@redhat.com Mon Aug 31 13:43:56 2020 -0400 Date: Mon Aug 31 13:43:56 2020 -0400: Git: 7e3fb3f281835ba6779886a89b27376cc423ef94 qxl doesn't add anything for the VNC case, and qxl is more likely to be compiled out of qemu since it is dependent on spice, so vga is the safer default for getting a working config https://bugzilla.redhat.com/show_bug.cgi?id=1833704 Signed-off-by: Cole Robinson <crobi...@redhat.com> diff --git a/tests/cli-test-xml/compare/virt-install-x86_64-graphics.xml b/tests/cli-test-xml/compare/virt-install-x86_64-graphics.xml index ea9b184f..c1b06ca1 100644 --- a/tests/cli-test-xml/compare/virt-install-x86_64-graphics.xml +++ b/tests/cli-test-xml/compare/virt-install-x86_64-graphics.xml @@ -48,7 +48,7 @@ <input type="tablet" bus="usb"/> <graphics type="vnc" port="-1"/> <video> - <model type="qxl"/> + <model type="vga"/> </video> <memballoon model="virtio"/> <rng model="virtio"> diff --git a/virtinst/devices/video.py b/virtinst/devices/video.py index fcca91b6..f9383131 100644 --- a/virtinst/devices/video.py +++ b/virtinst/devices/video.py @@ -42,8 +42,6 @@ class DeviceVideo(Device): if (guest.is_uefi() and guest.lookup_domcaps().supports_video_bochs()): return "bochs" - if guest.conn.is_qemu(): - return "qxl" return "vga" def set_defaults(self, guest): ++++++ e8bf16b9-details-fix-detection-of-firmware-auto-selection.patch ++++++ Subject: details: fix detection of firmware auto-selection From: Pavel Hrdina phrd...@redhat.com Tue Jul 21 12:33:56 2020 +0200 Date: Thu Aug 13 16:40:53 2020 +0200: Git: e8bf16b983558010cc9645e09eb36117e9e4fba4 Commit <15a9502b7b7a263c4d66ff2b3f31c209f58fe0b4> fixed firmware detection but incorrectly. It will always show only "UEFI" even if the firmware auto-selection is not used because the function is_uefi() checks both the old style and the new auto-selection. We have to check only for the auto-selection option. Signed-off-by: Pavel Hrdina <phrd...@redhat.com> --- virt-manager-2.2.1.orig/virtManager/details/details.py +++ virt-manager-2.2.1/virtManager/details/details.py @@ -2017,7 +2017,7 @@ class vmmDetails(vmmGObjectUI): # Firmware domcaps = self.vm.get_domain_capabilities() - if self.vm.get_xmlobj().is_uefi(): + if self.vm.get_xmlobj().os.firmware == "efi": firmware = 'UEFI' else: firmware = domcaps.label_for_firmware_path(
