Hello community, here is the log from the commit of package cifs-utils for openSUSE:Factory checked in at 2012-06-25 13:50:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/cifs-utils (Old) and /work/SRC/openSUSE:Factory/.cifs-utils.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "cifs-utils", Maintainer is "sjayara...@suse.com" Changes: -------- --- /work/SRC/openSUSE:Factory/cifs-utils/cifs-utils.changes 2012-06-06 16:05:51.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.cifs-utils.new/cifs-utils.changes 2012-06-25 13:50:07.000000000 +0200 @@ -1,0 +2,5 @@ +Tue Jun 12 11:54:14 UTC 2012 - lmue...@suse.com + +- mount.cifs: set rc to 0 in libcap toggle_dac_capability + +------------------------------------------------------------------- New: ---- set-rc-libcap-toggle_dac_capability.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ cifs-utils.spec ++++++ --- /var/tmp/diff_new_pack.qFHM1d/_old 2012-06-25 13:50:09.000000000 +0200 +++ /var/tmp/diff_new_pack.qFHM1d/_new 2012-06-25 13:50:09.000000000 +0200 @@ -27,6 +27,7 @@ Source1: cifs.init Source2: mkinitrd_scripts_boot-cifs.sh Source3: mkinitrd_scripts_setup-cifs.sh +Patch: set-rc-libcap-toggle_dac_capability.diff %if 0%{?suse_version} PreReq: insserv %{?fillup_prereq} mkinitrd %else @@ -73,6 +74,7 @@ %prep %setup -q +%patch -p1 %build export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE -fpie" ++++++ set-rc-libcap-toggle_dac_capability.diff ++++++ From: Jeff Layton <jlay...@samba.org> To: linux-c...@vger.kernel.org Cc: roderb...@uni-koeln.de Date: Tue, 12 Jun 2012 06:12:30 -0400 Subject: [PATCH] mount.cifs: set rc to 0 in libcap toggle_dac_capability Thus spake Jochen: The mount.cifs program from the cifs-utils package 5.5 did not work on my Linux system. It just exited without an error message and did not mount anything. [...] I think, when this variable rc is now used in this function, it has also to be properly initialized there. Reported-by: Jochen Roderburg <roderb...@uni-koeln.de> Signed-off-by: Jeff Layton <jlay...@samba.org> --- mount.cifs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mount.cifs.c b/mount.cifs.c index a1b0454..6f3f382 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -495,7 +495,7 @@ free_caps: static int toggle_dac_capability(int writable, int enable) { - int rc; + int rc = 0; cap_t caps; cap_value_t capability = writable ? CAP_DAC_OVERRIDE : CAP_DAC_READ_SEARCH; -- 1.7.7.6 -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org