Hello community, here is the log from the commit of package yast2-control-center-gnome for openSUSE:Factory checked in at 2014-06-06 14:36:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-control-center-gnome (Old) and /work/SRC/openSUSE:Factory/.yast2-control-center-gnome.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-control-center-gnome" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-control-center-gnome/yast2-control-center-gnome.changes 2014-06-02 07:00:48.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-control-center-gnome.new/yast2-control-center-gnome.changes 2014-06-06 14:36:15.000000000 +0200 @@ -1,0 +2,7 @@ +Tue Jun 2 07:11:29 UTC 2014 - fezh...@suse.com + +- Fix keyboard navigation in the search results (bnc#863950) + + The patch is ported from upstream gnome-control-center +- 3.1.4 + +------------------------------------------------------------------- Old: ---- yast2-control-center-gnome-3.1.3.tar.bz2 New: ---- yast2-control-center-gnome-3.1.4.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-control-center-gnome.spec ++++++ --- /var/tmp/diff_new_pack.DlSAOX/_old 2014-06-06 14:36:16.000000000 +0200 +++ /var/tmp/diff_new_pack.DlSAOX/_new 2014-06-06 14:36:16.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-control-center-gnome -Version: 3.1.3 +Version: 3.1.4 Release: 0 Summary: YaST2 - Control Center (GNOME version) ++++++ yast2-control-center-gnome-3.1.3.tar.bz2 -> yast2-control-center-gnome-3.1.4.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-control-center-gnome-3.1.3/package/yast2-control-center-gnome.changes new/yast2-control-center-gnome-3.1.4/package/yast2-control-center-gnome.changes --- old/yast2-control-center-gnome-3.1.3/package/yast2-control-center-gnome.changes 2014-05-30 16:36:45.000000000 +0200 +++ new/yast2-control-center-gnome-3.1.4/package/yast2-control-center-gnome.changes 2014-06-03 10:21:30.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Tue Jun 2 07:11:29 UTC 2014 - fezh...@suse.com + +- Fix keyboard navigation in the search results (bnc#863950) + + The patch is ported from upstream gnome-control-center +- 3.1.4 + +------------------------------------------------------------------- Fri May 30 08:00:43 UTC 2014 - fezh...@suse.com - Remove redundant icon in search entry (bnc#873641) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-control-center-gnome-3.1.3/package/yast2-control-center-gnome.spec new/yast2-control-center-gnome-3.1.4/package/yast2-control-center-gnome.spec --- old/yast2-control-center-gnome-3.1.3/package/yast2-control-center-gnome.spec 2014-05-30 16:36:45.000000000 +0200 +++ new/yast2-control-center-gnome-3.1.4/package/yast2-control-center-gnome.spec 2014-06-03 10:21:30.000000000 +0200 @@ -16,7 +16,7 @@ # Name: yast2-control-center-gnome -Version: 3.1.3 +Version: 3.1.4 Release: 0 Summary: YaST2 - Control Center (GNOME version) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-control-center-gnome-3.1.3/src/gnome-control-center.c new/yast2-control-center-gnome-3.1.4/src/gnome-control-center.c --- old/yast2-control-center-gnome-3.1.3/src/gnome-control-center.c 2014-05-30 16:36:45.000000000 +0200 +++ new/yast2-control-center-gnome-3.1.4/src/gnome-control-center.c 2014-06-03 10:21:30.000000000 +0200 @@ -650,13 +650,18 @@ } static void -on_search_selection_changed (GtkTreeSelection *selection, - GnomeControlCenter *shell) +on_search_row_activated (GtkTreeView *treeview, + GtkTreePath *path, + GtkTreeViewColumn *column, + GnomeControlCenter *shell) { + GtkTreeSelection *selection; GtkTreeModel *model; GtkTreeIter iter; char *id = NULL; + selection = gtk_tree_view_get_selection (treeview); + if (!gtk_tree_selection_get_selected (selection, &model, &iter)) return; @@ -672,6 +677,49 @@ g_free (id); } +static gboolean +on_search_button_press_event (GtkTreeView *treeview, + GdkEventButton *event, + GnomeControlCenter *shell) +{ + if (event->type == GDK_BUTTON_PRESS && event->button == 1) + { + GtkTreePath *path = NULL; + GtkTreeSelection *selection; + GtkTreeModel *model; + GtkTreeIter iter; + + /* We don't check for the position being blank, + * it could be the dead space between columns */ + gtk_tree_view_is_blank_at_pos (treeview, + event->x, event->y, + &path, + NULL, + NULL, + NULL); + if (path == NULL) + return FALSE; + + model = gtk_tree_view_get_model (treeview); + if (gtk_tree_model_get_iter (model, &iter, path) == FALSE) + { + gtk_tree_path_free (path); + return FALSE; + } + + selection = gtk_tree_view_get_selection (treeview); + gtk_tree_selection_select_iter (selection, &iter); + + on_search_row_activated (treeview, NULL, NULL, shell); + + gtk_tree_path_free (path); + + return TRUE; + } + + return FALSE; +} + static void setup_search (GnomeControlCenter *shell) { @@ -733,10 +781,10 @@ priv->search_scrolled = W (priv->builder, "search-scrolled-window"); gtk_container_add (GTK_CONTAINER (priv->search_scrolled), search_view); - g_signal_connect (gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->search_view)), - "changed", - G_CALLBACK (on_search_selection_changed), - shell); + g_signal_connect (priv->search_view, "row-activated", + G_CALLBACK (on_search_row_activated), shell); + g_signal_connect (priv->search_view, "button-press-event", + G_CALLBACK (on_search_button_press_event), shell); /* setup the search entry widget */ widget = (GtkWidget*) gtk_builder_get_object (priv->builder, "search-entry"); -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org