Hello community, here is the log from the commit of package spice for openSUSE:Factory checked in at 2014-10-19 19:27:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/spice (Old) and /work/SRC/openSUSE:Factory/.spice.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "spice" Changes: -------- --- /work/SRC/openSUSE:Factory/spice/spice.changes 2013-08-05 21:21:08.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.spice.new/spice.changes 2014-10-19 19:27:26.000000000 +0200 @@ -1,0 +2,25 @@ +Wed Oct 15 12:02:03 UTC 2014 - zai...@opensuse.org + +- Update to version 0.12.5: + + Added Opus support. Celt support will be obsoleted in a future + release. + + Addition of webdav channel. + + Force use of TLS 1.0 or newer for TLS connections. + + Reference manual. + + Some optimizations improving CPU use. + + Various bug fixes for race conditions, memory corruption, which + could be triggered on client disconnections, migration, and + cause spice-server to misbehave. + + Portability fixes. + + Code cleanups. +- Add pkconfig(opus) BuildRequires: Needed to build new opus + support. +- Add spice-Don-t-use-48kHz-for-playback-recording-rates.patch: + Fix advertised sound playback/recording rates in public headers + (rh#1129961). +- Drop spice-glibc217.patch: No longer needed. +- Run spec-clean on spec file, remove conditionals for obsolete + versions of openSUSE, enable parallel build and drop obsolete + clean section. + +------------------------------------------------------------------- Old: ---- spice-0.12.4.tar.bz2 spice-glibc217.patch New: ---- spice-0.12.5.tar.bz2 spice-Don-t-use-48kHz-for-playback-recording-rates.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ spice.spec ++++++ --- /var/tmp/diff_new_pack.LwM8AH/_old 2014-10-19 19:27:27.000000000 +0200 +++ /var/tmp/diff_new_pack.LwM8AH/_new 2014-10-19 19:27:27.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package spice # -# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,26 +18,21 @@ # Common info Name: spice -Version: 0.12.4 +Version: 0.12.5 Release: 0 Summary: SPICE client and server library License: LGPL-2.1+ Group: Productivity/Networking/Other Url: http://www.spice-space.org/ - -# Install-time parameters -Requires: celt051 - +Source: http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2 +# PATCH-FIX-UPSTREAM spice-Don-t-use-48kHz-for-playback-recording-rates.patch rh#1129961 zai...@opensuse.org -- Change back to 44100 from 48000. Patch taken from fedora. +Patch0: spice-Don-t-use-48kHz-for-playback-recording-rates.patch # Build-time parameters BuildRequires: alsa-devel BuildRequires: celt051-devel BuildRequires: cyrus-sasl-devel BuildRequires: gcc-c++ -%if 0%{?suse_version} >= 1220 BuildRequires: libcacard-devel -%endif -Source: http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2 -Patch1: spice-glibc217.patch BuildRequires: libjpeg-devel BuildRequires: libopenssl-devel BuildRequires: libpixman-1-0-devel >= 0.17.7 @@ -47,6 +42,9 @@ BuildRequires: xorg-x11-devel BuildRequires: xorg-x11-libXfixes-devel BuildRequires: pkgconfig(glib-2.0) >= 2.22 +BuildRequires: pkgconfig(opus) +# Install-time parameters +Requires: celt051 BuildRoot: %{_tmppath}/%{name}-%{version}-build ExclusiveArch: %ix86 x86_64 @@ -74,7 +72,6 @@ %package -n libspice-server-devel Summary: Development files for building SPICE-server Group: Development/Languages/C and C++ - Requires: libspice-server1 = %{version} %description -n libspice-server-devel @@ -84,26 +81,19 @@ %prep %setup -q -%patch1 -p1 +%patch0 -p1 %build %configure \ --disable-static \ --enable-client \ -%if 0%{?suse_version} < 1220 - --disable-smartcard -%else --enable-smartcard -%endif LDFLAGS="-Wl,--as-needed -Wl,--strip-all" make %{?_smp_mflags} %install -%makeinstall DESTDIR=%{buildroot} -find %{buildroot} -type f -name '*.la' -delete -print - -%clean -[ %{buildroot} != "/" ] && rm -rf %{buildroot} +make DESTDIR=%{buildroot} install %{?_smp_mflags} +find %{buildroot} -type f -name "*.la" -delete -print %post -n libspice-server1 -p /sbin/ldconfig ++++++ spice-0.12.4.tar.bz2 -> spice-0.12.5.tar.bz2 ++++++ ++++ 37057 lines of diff (skipped) ++++++ spice-Don-t-use-48kHz-for-playback-recording-rates.patch ++++++ >From 288cf77f804187a3e77ae2a5a21d108d101d22ce Mon Sep 17 00:00:00 2001 From: Christophe Fergeau <cferg...@redhat.com> Date: Tue, 19 Aug 2014 11:09:05 +0200 Subject: [PATCH] spice.h: Don't use 48kHz for playback/recording rates When adding Opus support, SPICE_INTERFACE_PLAYBACK_FREQ and SPICE_INTERFACE_RECORD_FREQ in the public header 'spice.h' were changed from 44100 to 48000. However, this was not really useful as these constants are not used in spice-server, but only by users of spice-server (ie QEMU). It turns out changing these values is actually harmful. QEMU uses these constants in 2 situations: 1. when it's a version of QEMU with this commit, but we are compiling against older spice-server headers (before Opus support was added) 2. when it's a version of QEMU without commit 795ca114d35 which added what is needed for Opus support When we are in the second situation, having 48000 in the public header will actually cause issues as spice-server will know QEMU does not support Opus, so internally spice-server will be using a 44100 rate for audio. However, QEMU will be using SPICE_INTERFACE_.*_FREQ and think it should use a 48000 rate, which will cause distorsions as experienced in bug https://bugzilla.redhat.com/show_bug.cgi?id=1129961 Reverting these constants back to 44100 will fix audio in the 'new spice-server/old QEMU' scenario, and won't cause issues either when both support Opus as in this case these constants are not used. --- server/spice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/spice.h b/server/spice.h index c648a1d..58700d1 100644 --- a/server/spice.h +++ b/server/spice.h @@ -342,7 +342,7 @@ enum { SPICE_INTERFACE_AUDIO_FMT_S16 = 1, }; -#define SPICE_INTERFACE_PLAYBACK_FREQ 48000 +#define SPICE_INTERFACE_PLAYBACK_FREQ 44100 #define SPICE_INTERFACE_PLAYBACK_CHAN 2 #define SPICE_INTERFACE_PLAYBACK_FMT SPICE_INTERFACE_AUDIO_FMT_S16 @@ -372,7 +372,7 @@ typedef struct SpiceRecordInterface SpiceRecordInterface; typedef struct SpiceRecordInstance SpiceRecordInstance; typedef struct SpiceRecordState SpiceRecordState; -#define SPICE_INTERFACE_RECORD_FREQ 48000 +#define SPICE_INTERFACE_RECORD_FREQ 44100 #define SPICE_INTERFACE_RECORD_CHAN 2 #define SPICE_INTERFACE_RECORD_FMT SPICE_INTERFACE_AUDIO_FMT_S16 -- 1.9.3 -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org
