Hello community,

here is the log from the commit of package rubygem-rhc for openSUSE:Factory 
checked in at 2015-01-29 09:55:59
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rubygem-rhc (Old)
 and      /work/SRC/openSUSE:Factory/.rubygem-rhc.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "rubygem-rhc"

Changes:
--------
--- /work/SRC/openSUSE:Factory/rubygem-rhc/rubygem-rhc.changes  2014-12-10 
23:44:51.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.rubygem-rhc.new/rubygem-rhc.changes     
2015-01-29 09:56:01.000000000 +0100
@@ -1,0 +2,5 @@
+Tue Jan 27 07:49:15 UTC 2015 - dmitr...@opensuse.org
+
+- updated to version 1.34.2
+
+-------------------------------------------------------------------

Old:
----
  rhc-1.33.4.gem

New:
----
  rhc-1.34.2.gem

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ rubygem-rhc.spec ++++++
--- /var/tmp/diff_new_pack.OBRD3m/_old  2015-01-29 09:56:02.000000000 +0100
+++ /var/tmp/diff_new_pack.OBRD3m/_new  2015-01-29 09:56:02.000000000 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package rubygem-rhc
 #
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:           rubygem-rhc
-Version:        1.33.4
+Version:        1.34.2
 Release:        0
 %define mod_name rhc
 %define mod_full_name %{mod_name}-%{version}

++++++ rhc-1.33.4.gem -> rhc-1.34.2.gem ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/lib/rhc/commands/ssh.rb new/lib/rhc/commands/ssh.rb
--- old/lib/rhc/commands/ssh.rb 1970-01-01 01:00:00.000000000 +0100
+++ new/lib/rhc/commands/ssh.rb 1970-01-01 01:00:00.000000000 +0100
@@ -15,6 +15,10 @@
 
       You may run a specific SSH command by passing one or more arguments, or 
use a
       different SSH executable or pass options to SSH with the '--ssh' option.
+
+      To use the '--ssh' flag with an SSH executable path containing a space, 
wrap
+      the executable path with double quotes:
+      --ssh '"C:\\path with spaces\\ssh"'
       DESC
     syntax "[--ssh path_to_ssh_executable] [--gears] [<app> --] <command>"
     takes_application :argument => true
@@ -42,16 +46,7 @@
         command_line = [RHC::Helpers.split_path(ssh), ('-vv' if debug?), 
rest_app.ssh_string.to_s, command].flatten.compact
 
         debug "Invoking Kernel.exec with #{command_line.inspect}"
-        begin
-          Kernel.send(:exec, *command_line)
-        rescue Errno::ENOENT
-          debug "SSH executable #{ssh.inspect} not found, splitting and trying 
again..."
-
-          command_line = [ssh.chomp('"').reverse.chomp('"').reverse.split(' 
'), ('-vv' if debug?), rest_app.ssh_string.to_s, command].flatten.compact
-          debug "Invoking Kernel.exec with #{command_line.inspect}"
-
-          Kernel.send(:exec, *command_line)
-        end
+        Kernel.send(:exec, *command_line)
       end
     end
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/lib/rhc/ssh_helpers.rb new/lib/rhc/ssh_helpers.rb
--- old/lib/rhc/ssh_helpers.rb  1970-01-01 01:00:00.000000000 +0100
+++ new/lib/rhc/ssh_helpers.rb  1970-01-01 01:00:00.000000000 +0100
@@ -475,10 +475,10 @@
           raise RHC::InvalidSSHExecutableException.new("No system SSH 
available. Please use the --ssh option to specify the path to your SSH 
executable, or install SSH.#{windows? ? ' We recommend this free application: 
Git for Windows - a basic git command line and GUI client 
http://msysgit.github.io/.' : ''}") unless ssh_cmd or has_ssh?
         end
       else
-        bin_path = path.split(' ').first
+        bin_path = split_path(path)[0]
         raise RHC::InvalidSSHExecutableException.new("SSH executable 
'#{bin_path}' does not exist.") unless File.exist?(bin_path) or 
File.exist?(path) or exe?(bin_path)
         raise RHC::InvalidSSHExecutableException.new("SSH executable 
'#{bin_path}' is not executable.") unless File.executable?(path) or 
File.executable?(bin_path) or exe?(bin_path)
-        path =~ / / ? '"' + path + '"' : path
+        path
       end
     end
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/metadata new/metadata
--- old/metadata        1970-01-01 01:00:00.000000000 +0100
+++ new/metadata        1970-01-01 01:00:00.000000000 +0100
@@ -5,9 +5,9 @@
   prerelease: 
   segments: 
   - 1
-  - 33
-  - 4
-  version: 1.33.4
+  - 34
+  - 2
+  version: 1.34.2
 platform: ruby
 authors: 
 - Red Hat
@@ -15,7 +15,7 @@
 bindir: bin
 cert_chain: []
 
-date: 2014-12-04 00:00:00 Z
+date: 2015-01-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: net-ssh
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/spec/rhc/commands/ssh_spec.rb 
new/spec/rhc/commands/ssh_spec.rb
--- old/spec/rhc/commands/ssh_spec.rb   1970-01-01 01:00:00.000000000 +0100
+++ new/spec/rhc/commands/ssh_spec.rb   1970-01-01 01:00:00.000000000 +0100
@@ -171,8 +171,8 @@
     end
   end
 
-  describe 'app ssh custom ssh with spaces' do
-    let(:arguments) { ['app', 'ssh', 'app1', '--ssh', '/path/to/ssh 
--with_custom_flag'] }
+  describe 'app ssh custom ssh with spaces and arguments' do
+    let(:arguments) { ['app', 'ssh', 'app1', '--ssh', '"/path/to /ssh" 
--with_custom_flag'] }
     context 'when custom ssh does not exist as a path' do
       before(:each) do
         @domain = rest_client.add_domain("mockdomain")
@@ -181,8 +181,7 @@
         File.should_receive(:exist?).at_least(1).and_return(true)
         File.should_receive(:executable?).at_least(1).and_return(true)
         
subject.class.any_instance.stub(:discover_git_executable).and_return('git')
-        Kernel.should_receive(:exec).with('/path/to/ssh --with_custom_flag', 
"fakeuuidfortestsapp1@127.0.0.1").once.times.and_raise(Errno::ENOENT)
-        Kernel.should_receive(:exec).with('/path/to/ssh', 
'--with_custom_flag', "fakeuuidfortestsapp1@127.0.0.1").once.times.and_return(0)
+        Kernel.should_receive(:exec).with("/path/to /ssh", 
'--with_custom_flag', "fakeuuidfortestsapp1@127.0.0.1").once.times.and_return(0)
       end
       it { expect { run }.to exit_with_code(0) }
     end

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

Reply via email to