Hello community,
here is the log from the commit of package yast2-storage for openSUSE:Factory
checked in at 2016-04-28 20:30:12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage (Old)
and /work/SRC/openSUSE:Factory/.yast2-storage.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage"
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage/yast2-storage.changes
2016-04-06 11:51:28.000000000 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-storage.new/yast2-storage.changes
2016-04-28 20:30:14.000000000 +0200
@@ -1,0 +2,26 @@
+Fri Apr 22 12:22:46 UTC 2016 - dmuel...@suse.com
+
+- raise min /boot size for BTRFS/aarch64 (bsc#974280)
+- 3.1.90
+
+-------------------------------------------------------------------
+Wed Apr 13 15:37:33 CEST 2016 - g...@suse.de
+
+- Don't allow to create or change partition table on LDL
+ formatted DASDs (bsc#958893)
+- 3.1.89
+
+-------------------------------------------------------------------
+Wed Apr 13 09:09:42 CEST 2016 - aschn...@suse.com
+
+- updated requirement to libstorage (related to bnc#958893)
+- 3.1.88
+
+-------------------------------------------------------------------
+Mon Apr 11 15:57:48 CEST 2016 - aschn...@suse.com
+
+- set parameters for space aware cleanup algorithm in snapper (for
+ fate#312751)
+- 3.1.87
+
+-------------------------------------------------------------------
Old:
----
yast2-storage-3.1.86.tar.bz2
New:
----
yast2-storage-3.1.90.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-storage.spec ++++++
--- /var/tmp/diff_new_pack.BEyMwM/_old 2016-04-28 20:30:15.000000000 +0200
+++ /var/tmp/diff_new_pack.BEyMwM/_new 2016-04-28 20:30:15.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-storage
-Version: 3.1.86
+Version: 3.1.90
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -40,8 +40,8 @@
BuildRequires: yast2-testsuite >= 2.19.0
BuildRequires: rubygem(rspec)
BuildRequires: rubygem(ruby-dbus)
-Requires: libstorage-ruby >= 2.25.36
-Requires: libstorage6 >= 2.25.36
+Requires: libstorage-ruby >= 2.26.1
+Requires: libstorage7 >= 2.26.1
Requires: yast2 >= 3.1.22
Requires: yast2-core >= 2.18.3
Requires: yast2-libyui >= 2.18.7
++++++ yast2-storage-3.1.86.tar.bz2 -> yast2-storage-3.1.90.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/package/yast2-storage.changes
new/yast2-storage-3.1.90/package/yast2-storage.changes
--- old/yast2-storage-3.1.86/package/yast2-storage.changes 2016-04-05
15:19:25.000000000 +0200
+++ new/yast2-storage-3.1.90/package/yast2-storage.changes 2016-04-22
14:31:53.000000000 +0200
@@ -1,4 +1,30 @@
-------------------------------------------------------------------
+Fri Apr 22 12:22:46 UTC 2016 - dmuel...@suse.com
+
+- raise min /boot size for BTRFS/aarch64 (bsc#974280)
+- 3.1.90
+
+-------------------------------------------------------------------
+Wed Apr 13 15:37:33 CEST 2016 - g...@suse.de
+
+- Don't allow to create or change partition table on LDL
+ formatted DASDs (bsc#958893)
+- 3.1.89
+
+-------------------------------------------------------------------
+Wed Apr 13 09:09:42 CEST 2016 - aschn...@suse.com
+
+- updated requirement to libstorage (related to bnc#958893)
+- 3.1.88
+
+-------------------------------------------------------------------
+Mon Apr 11 15:57:48 CEST 2016 - aschn...@suse.com
+
+- set parameters for space aware cleanup algorithm in snapper (for
+ fate#312751)
+- 3.1.87
+
+-------------------------------------------------------------------
Mon Apr 4 10:22:20 CEST 2016 - sch...@suse.de
- Removed Builtins.time. Cleanup for bnc#956730.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/package/yast2-storage.spec
new/yast2-storage-3.1.90/package/yast2-storage.spec
--- old/yast2-storage-3.1.86/package/yast2-storage.spec 2016-04-05
15:19:25.000000000 +0200
+++ new/yast2-storage-3.1.90/package/yast2-storage.spec 2016-04-22
14:31:53.000000000 +0200
@@ -1,7 +1,7 @@
#
# spec file for package yast2-storage
#
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: yast2-storage
-Version: 3.1.86
+Version: 3.1.90
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -42,8 +42,8 @@
BuildRequires: yast2-devtools >= 3.1.10
BuildRequires: yast2-ruby-bindings >= 3.1.7
BuildRequires: yast2-testsuite >= 2.19.0
-Requires: libstorage-ruby >= 2.25.36
-Requires: libstorage6 >= 2.25.36
+Requires: libstorage-ruby >= 2.26.1
+Requires: libstorage7 >= 2.26.1
Requires: rubygem(%{rb_default_ruby_abi}:ruby-dbus)
Requires: yast2 >= 3.1.22
Requires: yast2-core >= 2.18.3
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-3.1.86/src/include/partitioning/ep-hd-lib.rb
new/yast2-storage-3.1.90/src/include/partitioning/ep-hd-lib.rb
--- old/yast2-storage-3.1.86/src/include/partitioning/ep-hd-lib.rb
2016-04-05 15:19:26.000000000 +0200
+++ new/yast2-storage-3.1.90/src/include/partitioning/ep-hd-lib.rb
2016-04-22 14:31:53.000000000 +0200
@@ -46,6 +46,12 @@
target_map = Storage.GetTargetMap
disk = Ops.get(target_map, disk_device, {})
+ if disk["dasd_format"] == ::Storage::DASDF_LDL
+ # error popup
+ Popup.Error(_("Cannot create partition table on LDL formatted DASD."))
+ return
+ end
+
if Storage.IsUsedBy(disk)
# error popup
Popup.Error(_("The disk is in use and cannot be modified."))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/src/modules/Partitions.rb
new/yast2-storage-3.1.90/src/modules/Partitions.rb
--- old/yast2-storage-3.1.86/src/modules/Partitions.rb 2016-04-05
15:19:26.000000000 +0200
+++ new/yast2-storage-3.1.90/src/modules/Partitions.rb 2016-04-22
14:31:53.000000000 +0200
@@ -225,7 +225,11 @@
}
Ops.set(@boot_size_k, :proposed, 150 * 1024) if EfiBoot()
- if Arch.ia64
+ if Arch.aarch64
+ # Has higher requirements on BTRFS since pagesize==sectorsize = 64k
+ Ops.set(@boot_size_k, :proposed, 500 * 1024)
+ Ops.set(@boot_size_k, :minimal, 490 * 1024)
+ elsif Arch.ia64
Ops.set(@boot_size_k, :proposed, 200 * 1024)
Ops.set(@boot_size_k, :minimal, 180 * 1024)
elsif Arch.board_chrp || Arch.board_prep || Arch.board_iseries
@@ -925,74 +929,71 @@
def RdonlyText(disk, expert_partitioner)
disk = deep_copy(disk)
text = ""
+ device = disk["device"] || ""
+ ldl_dasd = (disk["dasd_format"] == ::Storage::DASDF_LDL)
+
if expert_partitioner
- text = Builtins.sformat(
- _("Operation not permitted on disk %1.\n"),
- Ops.get_string(disk, "device", "")
- )
+ text = _("Operation not permitted on disk %{device}.\n") % {:device =>
device}
end
- if !Ops.get_boolean(disk, "has_fake_partition", false)
- # popup text %1 is replaced by disk name e.g. /dev/hda
- text = Ops.add(
- text,
- Builtins.sformat(
- _(
- "\n" +
- "The partitioning on your disk %1 is either not readable or
not \n" +
- "supported by the partitioning tool parted used to change
the\n" +
- "partition table.\n" +
+ if ldl_dasd
+ # popup text %{device} is replaced by disk name e.g. /dev/hda
+ text << _(
"\n" +
- "You can use the partitions on disk %1 as they are or\n" +
- "format them and assign mount points, but you cannot add,
edit, \n" +
- "resize, or remove partitions from that disk here.\n"
- ),
- Ops.get_string(disk, "device", "")
- )
- )
+ "It's not supported by the partitioning tool parted to
change\n" +
+ "the partition table on your disk %{device}\n" +
+ "(the disk is LDL formatted).\n" +
+ "\n" +
+ "You can use the partitions on disk %{device} as they are
or\n" +
+ "format them and assign mount points, but you cannot add,\n"
+
+ "resize, or remove partitions from that disk here.\n"
+ ) % {:device => device}
+ elsif !disk["has_fake_partition"]
+ # popup text %{device} is replaced by disk name e.g. /dev/hda
+ text << _(
+ "\n" +
+ "The partitioning on your disk %{device} is either not
readable or not \n" +
+ "supported by the partitioning tool parted used to change
the\n" +
+ "partition table.\n" +
+ "\n" +
+ "You can use the partitions on disk %{device} as they are
or\n" +
+ "format them and assign mount points, but you cannot add,
edit, \n" +
+ "resize, or remove partitions from that disk here.\n"
+ ) % {:device => device}
else
- # popup text %1 is replaced by disk name e.g. /dev/dasda
- text = Ops.add(
- text,
- Builtins.sformat(
- _(
- "\n" +
- "The disk %1 does not contain a partition table but for\n" +
- "compatibility the kernel has automatically generated a\n" +
- "partition spanning almost the entire disk.\n" +
+ # popup text %{device} is replaced by disk name e.g. /dev/dasda
+ text << _(
"\n" +
- "You can use the partition on disk %1 as it is or\n" +
- "format it and assign a mount point, but you cannot resize\n" +
- "or remove the partition from that disk here.\n"
- ),
- Ops.get_string(disk, "device", "")
- )
- )
+ "The disk %{device} does not contain a partition table but
for\n" +
+ "compatibility the kernel has automatically generated a\n" +
+ "partition spanning almost the entire disk.\n" +
+ "\n" +
+ "You can use the partition on disk %{device} as it is or\n" +
+ "format it and assign a mount point, but you cannot
resize\n" +
+ "or remove the partition from that disk here.\n"
+ ) % {:device => device}
end
if expert_partitioner
- # popup text
- text = Ops.add(
- text,
- _(
- "\n" +
- "\n" +
- "You can initialize the disk partition table to a sane state in
the Expert\n" +
- "Partitioner by selecting \"Expert\"->\"Create New Partition
Table\", \n" +
- "but this will destroy all data on all partitions of this
disk.\n"
- )
- )
+ # it's not supported to create a new partition table on LDL DASDs
(bnc#958893)
+ if !ldl_dasd
+ # popup text
+ text << _(
+ "\n" +
+ "\n" +
+ "You can initialize the disk partition table to a sane
state in the Expert\n" +
+ "Partitioner by selecting \"Expert\"->\"Create New
Partition Table\", \n" +
+ "but this will destroy all data on all partitions of this
disk.\n"
+ )
+ end
else
# popup text
- text = Ops.add(
- text,
- _(
- "\n" +
- "\n" +
- "Safely ignore this message if you do not intend to use \n" +
- "this disk during installation.\n"
- )
- )
+ text << _(
+ "\n" +
+ "\n" +
+ "Safely ignore this message if you do not intend to use \n" +
+ "this disk during installation.\n"
+ )
end
text
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/src/modules/Storage.rb
new/yast2-storage-3.1.90/src/modules/Storage.rb
--- old/yast2-storage-3.1.86/src/modules/Storage.rb 2016-04-05
15:19:26.000000000 +0200
+++ new/yast2-storage-3.1.90/src/modules/Storage.rb 2016-04-22
14:31:53.000000000 +0200
@@ -1280,6 +1280,8 @@
Ops.set(d, "orig_label", tmp) if Ops.greater_than(Builtins.size(tmp), 0)
Ops.set(d, "max_logical", dinfo.maxLogical)
Ops.set(d, "max_primary", dinfo.maxPrimary)
+ Ops.set(d, "dasd_format", dinfo.dasd_format)
+ Ops.set(d, "dasd_type", dinfo.dasd_type)
t = dinfo.transport
Ops.set(d, "transport", toSymbol(@conv_transport, t))
@@ -1888,6 +1890,8 @@
"udev_id",
"udev_path",
"has_fake_partition",
+ "dasd_format",
+ "dasd_type",
"userdata"
]
Builtins.foreach(l) do |s|
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/src/modules/StorageSnapper.rb
new/yast2-storage-3.1.90/src/modules/StorageSnapper.rb
--- old/yast2-storage-3.1.86/src/modules/StorageSnapper.rb 2016-04-05
15:19:26.000000000 +0200
+++ new/yast2-storage-3.1.90/src/modules/StorageSnapper.rb 2016-04-22
14:31:53.000000000 +0200
@@ -124,7 +124,7 @@
end
bash_log_output("/usr/bin/snapper --no-dbus set-config " <<
- "NUMBER_CLEANUP=yes NUMBER_LIMIT=10
NUMBER_LIMIT_IMPORTANT=10 " <<
+ "NUMBER_CLEANUP=yes NUMBER_LIMIT=2-10
NUMBER_LIMIT_IMPORTANT=4-10 " <<
"TIMELINE_CREATE=no")
SCR.Write(path(".sysconfig.yast2.USE_SNAPPER"), "yes")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/test/Makefile.am
new/yast2-storage-3.1.90/test/Makefile.am
--- old/yast2-storage-3.1.86/test/Makefile.am 2016-04-05 15:19:26.000000000
+0200
+++ new/yast2-storage-3.1.90/test/Makefile.am 2016-04-22 14:31:53.000000000
+0200
@@ -8,7 +8,8 @@
storage_get_disk_partition.rb \
storage_boot_on_raid1.rb \
partitions_test.rb \
- include/partitioning_custom_part_check_generated_include_test.rb
+ include/partitioning_custom_part_check_generated_include_test.rb\
+ ro_text_test.rb
TEST_EXTENSIONS = .rb
RB_LOG_COMPILER = rspec
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-3.1.86/test/ro_text_test.rb
new/yast2-storage-3.1.90/test/ro_text_test.rb
--- old/yast2-storage-3.1.86/test/ro_text_test.rb 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-storage-3.1.90/test/ro_text_test.rb 2016-04-22
14:31:53.000000000 +0200
@@ -0,0 +1,44 @@
+#!/usr/bin/env rspec
+
+require_relative "spec_helper"
+
+Yast.import "Partitions"
+Yast.import "Arch"
+
+describe Yast::Partitions do
+ subject(:partitions) { Yast::Partitions }
+
+ describe "#RdonlyText" do
+ context "when on readonly disk during installation" do
+ it "shows disk not readable text and hint to ignore this message" do
+ text = partitions.RdonlyText({"device" => "/dev/sda1"}, false)
+ expect(text).to include("not readable")
+ expect(text).to include("ignore this message")
+ end
+ end
+
+ context "when on readonly disk in expert partitioner" do
+ it "shows text containing hint to Create new Partition" do
+ text = partitions.RdonlyText({"device" => "/dev/sda1"}, true)
+ expect(text).to include("Create New Partition Table")
+ end
+ end
+
+ context "when on LDL DASD" do
+ it "shows LDL text (without hint to Create new Partition)" do
+ text = partitions.RdonlyText({"device" => "/dev/dasdd",
+ "dasd_format" =>
::Storage::DASDF_LDL}, true)
+ expect(text).to include("LDL")
+ expect(text).not_to include("Create New Partition Table")
+ end
+ end
+
+ context "when on readonly disk having fake partition" do
+ it "shows text about automatically generated partition" do
+ text = partitions.RdonlyText({"device" => "/dev/sda1",
"has_fake_partition" => true}, false)
+ expect(text).to include("automatically generated")
+ end
+ end
+
+ end
+end
